[{"id":15101,"web_url":"https://patchwork.libcamera.org/comment/15101/","msgid":"","date":"2021-02-11T20:55:08","subject":"Re: [libcamera-devel] [PATCH v2 0/6] Delete Copy-Move-Assign","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the series.\n\nOn Thu, Feb 11, 2021 at 01:34:38PM +0000, Kieran Bingham wrote:\n> Here's a series which has been niggling me on my task list since the\n> topic came up which highlighted that the non-copyability of the\n> FrameBufferAllocator had been incorrectly implemented.\n> \n> We previously discussed providing a non-copyable class which could be inherited\n> or the addition of a macro.\n> \n> I've chosen to go down the macro route, because I think its clearer,\n> easier to customise, and doesn't extend the inheritance (and thus\n> increase the size) of classes.\n\nJust a side note, inheriting doesn't necessarily increase the size of an\nobject, see https://en.cppreference.com/w/cpp/language/ebo.\n\n> Along the way, the following tasks have occured:\n> \n> - Classes which delete their copy constructor and copy assignment\n> operator, have had those replaced by LIBCAMERA_DISABLE_COPY_AND_MOVE.\n> Where the existing copy/assignment deletion occured in public:, the\n> LIBCAMERA_DISABLE_COPY_AND_MOVE addition has been placed in private: so\n> that Doxygen does not complain. (and it should have the same effect)\n> \n> - The Buffer class deletes all of the copy, and move constructor and\n> assignment operators, so this has been kept. But as the only class\n> which goes this far, it seems to stand out on its own. I have simply\n> converted to the new usage, I didn't want to change any functionality\n> here.\n> \n> - Media objects deleted only their copy construtor. I believe this to\n> be an oversight, as if the copy constructor is deleted, then the copy\n> assignment operator should also be deleted. Therefore I see this macro\n> as a win here.\n\nYes, I think it was an oversight indeed. See\nhttps://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rc-five.\n\n> - MappedBuffer : This did not delete it's copy constructor, and I\n> believe it should have - so I've added it. I have not done a thorough\n> search of the tree to find other instances that should also delete\n> anything yet though.\n\nAgreed as well.\n\n> I'm sure that more classes could be tightened up with the addition of\n> these restrictions where necessary, or perhaps other variants might crop\n> up. I'm not sure yet, but this can get the ball rolling in that case.\n> \n> \n> Since the first v1 posting of this series, DELETE_COPY_MOVE_AND_ASSIGN\n> is renamed to LIBCAMERA_DISABLE_COPY_AND_MOVE (using disable instead of\n> deleted), and 'assign' has been removed from the macro names.\n> \n> The extensible class was also merged during this time, so it is first\n> renamed to be a generic class.h and these macros are added there.\n> \n> Kieran Bingham (6):\n> libcamera: Move extensible to class\n> libcamera: class: Provide move and copy disablers\n> libcamera: buffer: Utilise DISABLE_COPY_AND_MOVE\n> libcamera: media_object: Utilise LIBCAMERA_DISABLE_COPY\n> libcamera: Utilise LIBCAMERA_DISABLE_COPY\n> libcamera: MappedBuffer: Disable copy and assignment\n> \n> include/libcamera/buffer.h | 10 +++----\n> include/libcamera/camera.h | 8 ++---\n> include/libcamera/camera_manager.h | 6 ++--\n> include/libcamera/{extensible.h => class.h} | 20 ++++++++++---\n> include/libcamera/controls.h | 7 ++---\n> include/libcamera/framebuffer_allocator.h | 7 +++--\n> include/libcamera/internal/buffer.h | 4 +++\n> .../libcamera/internal/byte_stream_buffer.h | 4 +--\n> include/libcamera/internal/camera_sensor.h | 6 ++--\n> include/libcamera/internal/file.h | 6 ++--\n> include/libcamera/internal/log.h | 6 +++-\n> include/libcamera/internal/media_object.h | 9 ++++--\n> include/libcamera/internal/pipeline_handler.h | 4 +--\n> include/libcamera/internal/v4l2_subdevice.h | 5 ++--\n> include/libcamera/internal/v4l2_videodevice.h | 6 ++--\n> include/libcamera/meson.build | 1 -\n> include/libcamera/request.h | 5 ++--\n> src/libcamera/{extensible.cpp => class.cpp} | 29 ++++++++++++++++---\n> src/libcamera/meson.build | 2 +-\n> 19 files changed, 94 insertions(+), 51 deletions(-)\n> rename include/libcamera/{extensible.h => class.h} (71%)\n> rename src/libcamera/{extensible.cpp => class.cpp} (85%)\n> \n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F05FBBD160\n\tfor ;\n\tThu, 11 Feb 2021 20:55:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6F28463746;\n\tThu, 11 Feb 2021 21:55:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1DF24601B5\n\tfor ;\n\tThu, 11 Feb 2021 21:55:35 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 82A4941;\n\tThu, 11 Feb 2021 21:55:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qINQFdv5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613076934;\n\tbh=2vFmLkjC7HgZ45nEeT0bxLSNObw1Jr19PhZBVPXRnn0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qINQFdv5ixREEwPJNW/+A+Jmg2V6d90/TFCS6OzxovViJTP8VPbpsPZAdD0KInob6\n\tejNxSj8LX5bw8r4kWx8JDAoQPPG8LT72otaxoaHbPgQjF5XX5QKA4AkQ0p/T/0uIFS\n\t/vcfU8KdDp3FU4IAYEjDVUi5N4FRjnF2wLNnsgc0=","Date":"Thu, 11 Feb 2021 22:55:08 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210211133444.764808-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210211133444.764808-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 0/6] Delete Copy-Move-Assign","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15129,"web_url":"https://patchwork.libcamera.org/comment/15129/","msgid":"<7c625f87-83d1-656c-430e-c665f5c0e72e@ideasonboard.com>","date":"2021-02-12T09:22:27","subject":"Re: [libcamera-devel] [PATCH v2 0/6] Delete Copy-Move-Assign","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 11/02/2021 20:55, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the series.\n> \n> On Thu, Feb 11, 2021 at 01:34:38PM +0000, Kieran Bingham wrote:\n>> Here's a series which has been niggling me on my task list since the\n>> topic came up which highlighted that the non-copyability of the\n>> FrameBufferAllocator had been incorrectly implemented.\n>>\n>> We previously discussed providing a non-copyable class which could be inherited\n>> or the addition of a macro.\n>>\n>> I've chosen to go down the macro route, because I think its clearer,\n>> easier to customise, and doesn't extend the inheritance (and thus\n>> increase the size) of classes.\n> \n> Just a side note, inheriting doesn't necessarily increase the size of an\n> object, see https://en.cppreference.com/w/cpp/language/ebo.\n\nGood point, somehow I had it in my head that the alternative approach\nextended the size of the class somehow, but if the objects are the same\nsize, it can just be a 'cast'.\n\n\n\n>> Along the way, the following tasks have occured:\n>>\n>> - Classes which delete their copy constructor and copy assignment\n>> operator, have had those replaced by LIBCAMERA_DISABLE_COPY_AND_MOVE.\n>> Where the existing copy/assignment deletion occured in public:, the\n>> LIBCAMERA_DISABLE_COPY_AND_MOVE addition has been placed in private: so\n>> that Doxygen does not complain. (and it should have the same effect)\n>>\n>> - The Buffer class deletes all of the copy, and move constructor and\n>> assignment operators, so this has been kept. But as the only class\n>> which goes this far, it seems to stand out on its own. I have simply\n>> converted to the new usage, I didn't want to change any functionality\n>> here.\n>>\n>> - Media objects deleted only their copy construtor. I believe this to\n>> be an oversight, as if the copy constructor is deleted, then the copy\n>> assignment operator should also be deleted. Therefore I see this macro\n>> as a win here.\n> \n> Yes, I think it was an oversight indeed. See\n> https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rc-five.\n> \n>> - MappedBuffer : This did not delete it's copy constructor, and I\n>> believe it should have - so I've added it. I have not done a thorough\n>> search of the tree to find other instances that should also delete\n>> anything yet though.\n> \n> Agreed as well.\n\n\nInteresting seeing that it didn't actually 'need' it, but I think I\nagree, making it explicit helps readability.\n\n--\nKieran\n\n\n> \n>> I'm sure that more classes could be tightened up with the addition of\n>> these restrictions where necessary, or perhaps other variants might crop\n>> up. I'm not sure yet, but this can get the ball rolling in that case.\n>>\n>>\n>> Since the first v1 posting of this series, DELETE_COPY_MOVE_AND_ASSIGN\n>> is renamed to LIBCAMERA_DISABLE_COPY_AND_MOVE (using disable instead of\n>> deleted), and 'assign' has been removed from the macro names.\n>>\n>> The extensible class was also merged during this time, so it is first\n>> renamed to be a generic class.h and these macros are added there.\n>>\n>> Kieran Bingham (6):\n>> libcamera: Move extensible to class\n>> libcamera: class: Provide move and copy disablers\n>> libcamera: buffer: Utilise DISABLE_COPY_AND_MOVE\n>> libcamera: media_object: Utilise LIBCAMERA_DISABLE_COPY\n>> libcamera: Utilise LIBCAMERA_DISABLE_COPY\n>> libcamera: MappedBuffer: Disable copy and assignment\n>>\n>> include/libcamera/buffer.h | 10 +++----\n>> include/libcamera/camera.h | 8 ++---\n>> include/libcamera/camera_manager.h | 6 ++--\n>> include/libcamera/{extensible.h => class.h} | 20 ++++++++++---\n>> include/libcamera/controls.h | 7 ++---\n>> include/libcamera/framebuffer_allocator.h | 7 +++--\n>> include/libcamera/internal/buffer.h | 4 +++\n>> .../libcamera/internal/byte_stream_buffer.h | 4 +--\n>> include/libcamera/internal/camera_sensor.h | 6 ++--\n>> include/libcamera/internal/file.h | 6 ++--\n>> include/libcamera/internal/log.h | 6 +++-\n>> include/libcamera/internal/media_object.h | 9 ++++--\n>> include/libcamera/internal/pipeline_handler.h | 4 +--\n>> include/libcamera/internal/v4l2_subdevice.h | 5 ++--\n>> include/libcamera/internal/v4l2_videodevice.h | 6 ++--\n>> include/libcamera/meson.build | 1 -\n>> include/libcamera/request.h | 5 ++--\n>> src/libcamera/{extensible.cpp => class.cpp} | 29 ++++++++++++++++---\n>> src/libcamera/meson.build | 2 +-\n>> 19 files changed, 94 insertions(+), 51 deletions(-)\n>> rename include/libcamera/{extensible.h => class.h} (71%)\n>> rename src/libcamera/{extensible.cpp => class.cpp} (85%)\n>>\n>> -- \n>> 2.25.1\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1780BD162\n\tfor ;\n\tFri, 12 Feb 2021 09:22:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3CE056376B;\n\tFri, 12 Feb 2021 10:22:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14B6D63762\n\tfor ;\n\tFri, 12 Feb 2021 10:22:31 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 86BBD8B5;\n\tFri, 12 Feb 2021 10:22:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qC2E7aPO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613121750;\n\tbh=XI8NMTGvYZFWCsk6RvX39RMNGDEQwojUYQafOUVUens=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=qC2E7aPOxif6k80+K9/BvtIsQmw9vryNbECXGlAXP2JCUg0A2/cpE3814HC/1cCrk\n\tHLx9S92oc1frovu1DycZFOgr2qFHeUrpw91MkSJMIA7tkBbkykTDTX9+EI0xWfQKVI\n\tkDm0+tnZ2pfcZIOJ9sX2KMebIMq6RQjyEMxAmWlc=","To":"Laurent Pinchart ","References":"<20210211133444.764808-1-kieran.bingham@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<7c625f87-83d1-656c-430e-c665f5c0e72e@ideasonboard.com>","Date":"Fri, 12 Feb 2021 09:22:27 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 0/6] Delete Copy-Move-Assign","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]