[{"id":15100,"web_url":"https://patchwork.libcamera.org/comment/15100/","msgid":"<YCVacOyh6Pw35Qfw@pendragon.ideasonboard.com>","date":"2021-02-11T16:25:20","subject":"Re: [libcamera-devel] [PATCH v2 0/2] Raspberry Pi AWB race\n\tcondition and maintenance","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nOn Wed, Feb 10, 2021 at 05:58:28PM +0000, David Plowman wrote:\n> Hi\n> \n> Thanks for the reviews. This v2 set is identical but for the addition\n> of an isAutoEnabled() method, as suggested. In the other patch I've\n> fixed a typo in the commit message (no prizes for spotting what it\n> was!).\n\nI'm afraid I had alreadu pushed the previous version of 1/2, so the typo\nwill make it to posterity, sorry about that :-)\n\n2/2 looks good, I'll push it shortly after the tests finish running.\n\n> David Plowman (2):\n>   ipa: raspberrypi: AWB: Remove unnecessary frame count variable\n>   ipa: raspberrypi: AWB: Fix race condition setting manual gains\n> \n>  src/ipa/raspberrypi/controller/rpi/awb.cpp | 90 +++++++++++-----------\n>  src/ipa/raspberrypi/controller/rpi/awb.hpp |  2 +-\n>  2 files changed, 45 insertions(+), 47 deletions(-)","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3031BD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Feb 2021 16:25:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5588A63745;\n\tThu, 11 Feb 2021 17:25:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC988601B5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Feb 2021 17:25:46 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2528441;\n\tThu, 11 Feb 2021 17:25:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hhDSx9bf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613060746;\n\tbh=qQjwbZTFirJ4ORxc0svMD51Bm55RLGEEaaJ5nhix/WM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hhDSx9bfhDpEUXRKIXWv4QMCZvUGXNCz/KGmeq+gCoC341Z23y6csZBCA1OPG6o4v\n\t/eFnRKjv5dhzRSZfhQA33D85MGiPJwwBnhHe7snNjB/zDLuKKJxLktwXcStCT3iw7f\n\tV08Lq5N8cS6UTBWyAuocRWey5+NtGICArmLHprxY=","Date":"Thu, 11 Feb 2021 18:25:20 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"David Plowman <david.plowman@raspberrypi.com>","Message-ID":"<YCVacOyh6Pw35Qfw@pendragon.ideasonboard.com>","References":"<20210210175830.32038-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210210175830.32038-1-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 0/2] Raspberry Pi AWB race\n\tcondition and maintenance","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]