[{"id":15088,"web_url":"https://patchwork.libcamera.org/comment/15088/","msgid":"<20210211041426.GA13040@pyrite.rasen.tech>","date":"2021-02-11T04:14:26","subject":"Re: [libcamera-devel] [RFC 0/2] ipu3: Translate IPA protocol to new\n\tmojo interface","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Niklas,\n\nThank for for the work.\n\nOn Tue, Feb 09, 2021 at 12:47:31AM +0100, Niklas Söderlund wrote:\n> Hi Paul,\n> \n> This is based on-top of your ipc7 branch and it enables me to run the \n> IPU3 IPA on CrOS Soraka. The first patch is a compile fix found with \n> gcc7 while the last patch is the real meat.\n> \n> Feel free to pick and choose what you wish and squash it into your \n> existing patches. I really like the new mojo interface, nice work!\n\nLooks good!\n\nFor both patches:\n\nReviewed-by: Paul Elder \n\nI'll pull the first one into my series as-is, and the second one there\nare a couple small changes that I'll apply and then pull into my series\nas well.\n\n\nThanks,\n\nPaul\n\n> Niklas Söderlund (2):\n> libcamera: IPCPipeUnixSocket: Check that insertion succeeds\n> ipu3: Translate IPA protocol to new mojo interface\n> \n> include/libcamera/ipa/ipu3.h | 23 -------\n> include/libcamera/ipa/ipu3.mojom | 43 ++++++++++++\n> include/libcamera/ipa/meson.build | 1 +\n> src/ipa/ipu3/ipu3.cpp | 74 ++++++++-------------\n> src/ipa/ipu3/meson.build | 6 +-\n> src/libcamera/ipc_pipe_unixsocket.cpp | 5 ++\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 96 +++++++++++----------------\n> 7 files changed, 118 insertions(+), 130 deletions(-)\n> delete mode 100644 include/libcamera/ipa/ipu3.h\n> create mode 100644 include/libcamera/ipa/ipu3.mojom\n> \n> -- \n> 2.30.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B1A27BD160\n\tfor ;\n\tThu, 11 Feb 2021 04:14:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2958561642;\n\tThu, 11 Feb 2021 05:14:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5453D602FD\n\tfor ;\n\tThu, 11 Feb 2021 05:14:34 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6C8C41;\n\tThu, 11 Feb 2021 05:14:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uMc5S4w3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613016873;\n\tbh=27Um0evCtdZ5sMMIb+DTfX3/Gbq0q41ONVBI1g05pgA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uMc5S4w3cNPXCUiOE1GdyBhXUVcm/nunY64OPRJYmvx56rsK8fB2zE+U3Nhf3GswM\n\tCdXpyaX1kI1W8RhXzpkb3K1hD6z+/Pj4lSCpx8w/DXs7Sw5FlQT84+dyG78SdeHFUV\n\t4GUFLDmk0FVC45LEzoEGY27utik8bp9L5VJ1f7ek=","Date":"Thu, 11 Feb 2021 13:14:26 +0900","From":"paul.elder@ideasonboard.com","To":"Niklas =?iso-8859-1?q?S=F6derlund?= ","Message-ID":"<20210211041426.GA13040@pyrite.rasen.tech>","References":"<20210208234733.2637061-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210208234733.2637061-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [RFC 0/2] ipu3: Translate IPA protocol to new\n\tmojo interface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]