[{"id":15079,"web_url":"https://patchwork.libcamera.org/comment/15079/","msgid":"","date":"2021-02-09T08:39:00","subject":"Re: [libcamera-devel] [PATCH 1/2] meson: Fix coding style when\n\tdeclaring arrays","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2021-02-09 00:20:43 +0200, Laurent Pinchart wrote:\n> The meson.build files mix array declarations with and without a space\n> after the opening and before the closing square bracket. The vast\n> majority of cases don't use spaces, so standardize on that.\n> \n> While it it, fix indentation in a few places.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/internal/meson.build | 4 ++--\n> src/android/meson.build | 4 ++--\n> src/gstreamer/meson.build | 2 +-\n> src/ipa/ipu3/meson.build | 6 +++---\n> src/ipa/raspberrypi/meson.build | 2 +-\n> src/ipa/rkisp1/meson.build | 2 +-\n> src/ipa/vimc/meson.build | 2 +-\n> src/libcamera/meson.build | 4 ++--\n> src/meson.build | 4 ++--\n> src/qcam/meson.build | 8 ++++----\n> src/v4l2/meson.build | 2 +-\n> test/camera/meson.build | 10 +++++-----\n> test/controls/meson.build | 8 ++++----\n> test/ipc/meson.build | 2 +-\n> test/process/meson.build | 2 +-\n> test/serialization/meson.build | 2 +-\n> test/stream/meson.build | 12 ++++++------\n> test/v4l2_subdevice/meson.build | 4 ++--\n> test/v4l2_videodevice/meson.build | 18 +++++++++---------\n> 19 files changed, 49 insertions(+), 49 deletions(-)\n> \n> diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\n> index e67a359fb865..a1071721967e 100644\n> --- a/include/libcamera/internal/meson.build\n> +++ b/include/libcamera/internal/meson.build\n> @@ -4,9 +4,9 @@ subdir('tracepoints')\n> \n> libcamera_tracepoint_header = custom_target(\n> 'tp_header',\n> - input: [ 'tracepoints.h.in', tracepoint_files ],\n> + input: ['tracepoints.h.in', tracepoint_files],\n> output: 'tracepoints.h',\n> - command: [ gen_tracepoints_header, '@OUTPUT@', '@INPUT@' ],\n> + command: [gen_tracepoints_header, '@OUTPUT@', '@INPUT@'],\n> )\n> \n> libcamera_internal_headers = files([\n> diff --git a/src/android/meson.build b/src/android/meson.build\n> index 95d0f420a5bc..f5567a1cd8eb 100644\n> --- a/src/android/meson.build\n> +++ b/src/android/meson.build\n> @@ -32,9 +32,9 @@ if android_enabled\n> libyuv_vars.append_link_args('-ljpeg')\n> libyuv = cmake.subproject('libyuv', options : libyuv_vars)\n> libyuv_dep = libyuv.dependency('yuv')\n> - endif\n> + endif\n> \n> - android_deps += [ libyuv_dep, ]\n> + android_deps += [libyuv_dep]\n> endif\n> \n> android_hal_sources = files([\n> diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\n> index c9f0c13d969d..9e93ffac28b6 100644\n> --- a/src/gstreamer/meson.build\n> +++ b/src/gstreamer/meson.build\n> @@ -29,7 +29,7 @@ if glib_dep.found() and gstvideo_dep.found() and gstallocator_dep.found()\n> # complain about the ones we are not using. Silence the -Wunused-function\n> # warning in that case.\n> if cc.get_id() == 'clang' and glib_dep.version().version_compare('<2.63.0')\n> - libcamera_gst_cpp_args += [ '-Wno-unused-function' ]\n> + libcamera_gst_cpp_args += ['-Wno-unused-function']\n> endif\n> \n> libcamera_gst = shared_library('gstlibcamera',\n> diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\n> index 444c82453eac..d31594fcb213 100644\n> --- a/src/ipa/ipu3/meson.build\n> +++ b/src/ipa/ipu3/meson.build\n> @@ -5,8 +5,8 @@ ipa_name = 'ipa_ipu3'\n> mod = shared_module(ipa_name,\n> 'ipu3.cpp',\n> name_prefix : '',\n> - include_directories : [ ipa_includes, libipa_includes ],\n> - dependencies : [ libatomic, libcamera_dep ],\n> + include_directories : [ipa_includes, libipa_includes],\n> + dependencies : [libatomic, libcamera_dep],\n> link_with : libipa,\n> install : true,\n> install_dir : ipa_install_dir)\n> @@ -15,7 +15,7 @@ if ipa_sign_module\n> custom_target(ipa_name + '.so.sign',\n> input : mod,\n> output : ipa_name + '.so.sign',\n> - command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],\n> + command : [ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@'],\n> install : false,\n> build_by_default : true)\n> endif\n> diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build\n> index 9445cd097df5..9e9ea80b93ad 100644\n> --- a/src/ipa/raspberrypi/meson.build\n> +++ b/src/ipa/raspberrypi/meson.build\n> @@ -54,7 +54,7 @@ if ipa_sign_module\n> custom_target(ipa_name + '.so.sign',\n> input : mod,\n> output : ipa_name + '.so.sign',\n> - command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],\n> + command : [ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@'],\n> install : false,\n> build_by_default : true)\n> endif\n> diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\n> index ed9a6b6b8ec8..95eb5393f76f 100644\n> --- a/src/ipa/rkisp1/meson.build\n> +++ b/src/ipa/rkisp1/meson.build\n> @@ -15,7 +15,7 @@ if ipa_sign_module\n> custom_target(ipa_name + '.so.sign',\n> input : mod,\n> output : ipa_name + '.so.sign',\n> - command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],\n> + command : [ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@'],\n> install : false,\n> build_by_default : true)\n> endif\n> diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build\n> index 8c9df854007a..b1544c289932 100644\n> --- a/src/ipa/vimc/meson.build\n> +++ b/src/ipa/vimc/meson.build\n> @@ -15,7 +15,7 @@ if ipa_sign_module\n> custom_target(ipa_name + '.so.sign',\n> input : mod,\n> output : ipa_name + '.so.sign',\n> - command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],\n> + command : [ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@'],\n> install : false,\n> build_by_default : true)\n> endif\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 5a4bf0d7ba4f..2b1850897aa4 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -111,9 +111,9 @@ libcamera_sources += version_cpp\n> \n> if ipa_sign_module\n> ipa_pub_key_cpp = custom_target('ipa_pub_key_cpp',\n> - input : [ ipa_priv_key, 'ipa_pub_key.cpp.in' ],\n> + input : [ipa_priv_key, 'ipa_pub_key.cpp.in'],\n> output : 'ipa_pub_key.cpp',\n> - command : [ gen_ipa_pub_key, '@INPUT@', '@OUTPUT@' ])\n> + command : [gen_ipa_pub_key, '@INPUT@', '@OUTPUT@'])\n> \n> libcamera_sources += ipa_pub_key_cpp\n> endif\n> diff --git a/src/meson.build b/src/meson.build\n> index 4b75f05878bc..0b26ca70f7de 100644\n> --- a/src/meson.build\n> +++ b/src/meson.build\n> @@ -3,8 +3,8 @@\n> openssl = find_program('openssl', required : true)\n> if openssl.found()\n> ipa_priv_key = custom_target('ipa-priv-key',\n> - output : [ 'ipa-priv-key.pem' ],\n> - command : [ gen_ipa_priv_key, '@OUTPUT@' ])\n> + output : ['ipa-priv-key.pem'],\n> + command : [gen_ipa_priv_key, '@OUTPUT@'])\n> config_h.set('HAVE_IPA_PUBKEY', 1)\n> ipa_sign_module = true\n> else\n> diff --git a/src/qcam/meson.build b/src/qcam/meson.build\n> index ebcd5ca010cf..8f3d50dd71c5 100644\n> --- a/src/qcam/meson.build\n> +++ b/src/qcam/meson.build\n> @@ -32,12 +32,12 @@ if qt5_dep.found()\n> qt5_dep,\n> ]\n> \n> - qt5_cpp_args = [ '-DQT_NO_KEYWORDS' ]\n> + qt5_cpp_args = ['-DQT_NO_KEYWORDS']\n> \n> tiff_dep = dependency('libtiff-4', required : false)\n> if tiff_dep.found()\n> - qt5_cpp_args += [ '-DHAVE_TIFF' ]\n> - qcam_deps += [ tiff_dep ]\n> + qt5_cpp_args += ['-DHAVE_TIFF']\n> + qcam_deps += [tiff_dep]\n> qcam_sources += files([\n> 'dng_writer.cpp',\n> ])\n> @@ -62,7 +62,7 @@ if qt5_dep.found()\n> if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> qt5_dep.version().version_compare('<5.13')) or\n> (cc.get_id() == 'clang' and cc.version().version_compare('>=10.0')))\n> - qt5_cpp_args += [ '-Wno-deprecated-copy' ]\n> + qt5_cpp_args += ['-Wno-deprecated-copy']\n> endif\n> \n> resources = qt5.preprocess(moc_headers: qcam_moc_headers,\n> diff --git a/src/v4l2/meson.build b/src/v4l2/meson.build\n> index dbe6a424b10e..c8b794247560 100644\n> --- a/src/v4l2/meson.build\n> +++ b/src/v4l2/meson.build\n> @@ -28,5 +28,5 @@ v4l2_compat = shared_library('v4l2-compat',\n> v4l2_compat_sources,\n> name_prefix : '',\n> install : true,\n> - dependencies : [ libcamera_dep, libdl ],\n> + dependencies : [libcamera_dep, libdl],\n> cpp_args : v4l2_compat_cpp_args)\n> diff --git a/test/camera/meson.build b/test/camera/meson.build\n> index 0395e7ddc7a4..9cb95affffab 100644\n> --- a/test/camera/meson.build\n> +++ b/test/camera/meson.build\n> @@ -3,11 +3,11 @@\n> # Tests are listed in order of complexity.\n> # They are not alphabetically sorted.\n> camera_tests = [\n> - [ 'configuration_default', 'configuration_default.cpp' ],\n> - [ 'configuration_set', 'configuration_set.cpp' ],\n> - [ 'buffer_import', 'buffer_import.cpp' ],\n> - [ 'statemachine', 'statemachine.cpp' ],\n> - [ 'capture', 'capture.cpp' ],\n> + ['configuration_default', 'configuration_default.cpp'],\n> + ['configuration_set', 'configuration_set.cpp'],\n> + ['buffer_import', 'buffer_import.cpp'],\n> + ['statemachine', 'statemachine.cpp'],\n> + ['capture', 'capture.cpp'],\n> ]\n> \n> foreach t : camera_tests\n> diff --git a/test/controls/meson.build b/test/controls/meson.build\n> index 545fb03b16c6..188c96da3336 100644\n> --- a/test/controls/meson.build\n> +++ b/test/controls/meson.build\n> @@ -1,10 +1,10 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> control_tests = [\n> - [ 'control_info', 'control_info.cpp' ],\n> - [ 'control_info_map', 'control_info_map.cpp' ],\n> - [ 'control_list', 'control_list.cpp' ],\n> - [ 'control_value', 'control_value.cpp' ],\n> + ['control_info', 'control_info.cpp'],\n> + ['control_info_map', 'control_info_map.cpp'],\n> + ['control_list', 'control_list.cpp'],\n> + ['control_value', 'control_value.cpp'],\n> ]\n> \n> foreach t : control_tests\n> diff --git a/test/ipc/meson.build b/test/ipc/meson.build\n> index 650df1d63444..9f413ff68efc 100644\n> --- a/test/ipc/meson.build\n> +++ b/test/ipc/meson.build\n> @@ -1,7 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> ipc_tests = [\n> - [ 'unixsocket', 'unixsocket.cpp' ],\n> + ['unixsocket', 'unixsocket.cpp'],\n> ]\n> \n> foreach t : ipc_tests\n> diff --git a/test/process/meson.build b/test/process/meson.build\n> index c215fa7e6c12..d2272d509db3 100644\n> --- a/test/process/meson.build\n> +++ b/test/process/meson.build\n> @@ -1,7 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> process_tests = [\n> - [ 'process_test', 'process_test.cpp' ],\n> + ['process_test', 'process_test.cpp'],\n> ]\n> \n> foreach t : process_tests\n> diff --git a/test/serialization/meson.build b/test/serialization/meson.build\n> index a9d9cbcb7d80..6fc54f6b6586 100644\n> --- a/test/serialization/meson.build\n> +++ b/test/serialization/meson.build\n> @@ -1,7 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> serialization_tests = [\n> - [ 'control_serialization', 'control_serialization.cpp' ],\n> + ['control_serialization', 'control_serialization.cpp'],\n> ]\n> \n> foreach t : serialization_tests\n> diff --git a/test/stream/meson.build b/test/stream/meson.build\n> index 2b9b29a9143b..5d3ef5881b44 100644\n> --- a/test/stream/meson.build\n> +++ b/test/stream/meson.build\n> @@ -1,13 +1,13 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> stream_tests = [\n> - [ 'stream_formats', 'stream_formats.cpp' ],\n> + ['stream_formats', 'stream_formats.cpp'],\n> ]\n> \n> foreach t : stream_tests\n> - exe = executable(t[0], t[1],\n> - dependencies : libcamera_dep,\n> - link_with : test_libraries,\n> - include_directories : test_includes_internal)\n> - test(t[0], exe, suite: 'stream')\n> + exe = executable(t[0], t[1],\n> + dependencies : libcamera_dep,\n> + link_with : test_libraries,\n> + include_directories : test_includes_internal)\n> + test(t[0], exe, suite: 'stream')\n> endforeach\n> diff --git a/test/v4l2_subdevice/meson.build b/test/v4l2_subdevice/meson.build\n> index 5f0882ca9772..40d39766af9b 100644\n> --- a/test/v4l2_subdevice/meson.build\n> +++ b/test/v4l2_subdevice/meson.build\n> @@ -1,8 +1,8 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> v4l2_subdevice_tests = [\n> - [ 'list_formats', 'list_formats.cpp'],\n> - [ 'test_formats', 'test_formats.cpp'],\n> + ['list_formats', 'list_formats.cpp'],\n> + ['test_formats', 'test_formats.cpp'],\n> ]\n> \n> foreach t : v4l2_subdevice_tests\n> diff --git a/test/v4l2_videodevice/meson.build b/test/v4l2_videodevice/meson.build\n> index b4bb30908027..e733518c0185 100644\n> --- a/test/v4l2_videodevice/meson.build\n> +++ b/test/v4l2_videodevice/meson.build\n> @@ -3,15 +3,15 @@\n> # Tests are listed in order of complexity.\n> # They are not alphabetically sorted.\n> v4l2_videodevice_tests = [\n> - [ 'double_open', 'double_open.cpp' ],\n> - [ 'controls', 'controls.cpp' ],\n> - [ 'formats', 'formats.cpp' ],\n> - [ 'request_buffers', 'request_buffers.cpp' ],\n> - [ 'buffer_cache', 'buffer_cache.cpp' ],\n> - [ 'stream_on_off', 'stream_on_off.cpp' ],\n> - [ 'capture_async', 'capture_async.cpp' ],\n> - [ 'buffer_sharing', 'buffer_sharing.cpp' ],\n> - [ 'v4l2_m2mdevice', 'v4l2_m2mdevice.cpp' ],\n> + ['double_open', 'double_open.cpp'],\n> + ['controls', 'controls.cpp'],\n> + ['formats', 'formats.cpp'],\n> + ['request_buffers', 'request_buffers.cpp'],\n> + ['buffer_cache', 'buffer_cache.cpp'],\n> + ['stream_on_off', 'stream_on_off.cpp'],\n> + ['capture_async', 'capture_async.cpp'],\n> + ['buffer_sharing', 'buffer_sharing.cpp'],\n> + ['v4l2_m2mdevice', 'v4l2_m2mdevice.cpp'],\n> ]\n> \n> foreach t : v4l2_videodevice_tests\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 926A2BD160\n\tfor ;\n\tTue, 9 Feb 2021 08:39:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 11CAB61624;\n\tTue, 9 Feb 2021 09:39:05 +0100 (CET)","from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com\n\t[IPv6:2a00:1450:4864:20::12e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B66860300\n\tfor ;\n\tTue, 9 Feb 2021 09:39:03 +0100 (CET)","by mail-lf1-x12e.google.com with SMTP id j19so6778035lfr.12\n\tfor ;\n\tTue, 09 Feb 2021 00:39:03 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tf4sm2422564lfs.133.2021.02.09.00.39.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Feb 2021 00:39:01 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"pPBLb4Sg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=xY3yNx+JqP4H9pZUohFzXSjAIECVX4STikL4+67MFJY=;\n\tb=pPBLb4SgRhoCjSAlKtEqgjdO6aPuBBOCcLy4jkpvVkMOFFtGW1B0qwvGLgLIHqTcrJ\n\tF8w+2OoBBVmEwqKgRa9LKLYHDxObqGSSctQbx5qNKfIdvoZVI6dcbvcs8Q7XLOw19Wj7\n\tQ512tumy29/bUGZErJgKg0VyFZ80tnGcq+Uudp8E1ZGuyHsErg6RJ+S8pWLX7RF8RRXZ\n\tZfGI67yyEUAEbIs6q7Qugok2qJVnwudseXYL/CB0qhyNhM1/fWufO69n+y/UwSGQfGvE\n\tZBA1haIZhviBkyQBY3FwQ64hIBmLivSDE9rquaPFCUW3bta9wonR6JwP+6tJpj21DOHb\n\thUZA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=xY3yNx+JqP4H9pZUohFzXSjAIECVX4STikL4+67MFJY=;\n\tb=Wy2dTtUuHHKneZLgwBZJ0Jh/4tgOXE404h3LxcCp8+Owdr3NGU4pP2Ni8NMouI+x6h\n\tsbGq/RkBufQRmjF3aErLp47gWpQtMDst4zSEMh5Jt0QVwF5A8DaUS3uJH6I35D5hIifZ\n\tEDXoym9cnZ3RFwpOG2pZyqBd+niOxz1qIhDUD8JJwmkJwvkSHdy7Ah99JiS3uqPG2fwf\n\tJAzPb2P+lFCJQw9L7YUT1BEO+PtNFsnA4Uz8UQzUo1pnsccvfybmHqVo03PO62Zdalye\n\tklxVu1pAp41VeLTbcQcXEHUtRgjvrm8Namv2hStmG1FirdaY9ymTmoM4g9YM9dM0jW07\n\tkEfA==","X-Gm-Message-State":"AOAM531b62z63HPmx7iNmc3wVdz1pqPbel81/T8zekiqQBhIB92/PKJ5\n\tN2RARsCFeMCFPeXI65/pZ6Vzp+HDVd/S2IMX","X-Google-Smtp-Source":"ABdhPJwBsko8EwO1J0f73f4dcIessO7nEnu3vCSzXqnVr6ue+pr+8R4K16w4ttyxkNEh03jEckwgRQ==","X-Received":"by 2002:a19:3806:: with SMTP id\n\tf6mr13229636lfa.242.1612859942602; \n\tTue, 09 Feb 2021 00:39:02 -0800 (PST)","Date":"Tue, 9 Feb 2021 09:39:00 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20210208222044.30514-1-laurent.pinchart@ideasonboard.com>\n\t<20210208222044.30514-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210208222044.30514-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] meson: Fix coding style when\n\tdeclaring arrays","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15080,"web_url":"https://patchwork.libcamera.org/comment/15080/","msgid":"","date":"2021-02-09T08:40:08","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Drop unneeded\n\tdepend_files from meson custom targets","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2021-02-09 00:20:44 +0200, Laurent Pinchart wrote:\n> The meson custom_target() function accepts a 'depend_files' argument to\n> list additional dependency files. Files already listed in the 'command'\n> argument are handled automatically, and don't need to be added manually.\n> Drop them.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/meson.build | 1 -\n> src/libcamera/meson.build | 1 -\n> 2 files changed, 2 deletions(-)\n> \n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index 13e9eeb6d6ad..eb787d44746a 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -46,7 +46,6 @@ foreach header : control_source_files\n> control_headers += custom_target(header + '_h',\n> input : input_files,\n> output : header + '.h',\n> - depend_files : gen_controls,\n> command : [gen_controls, '-o', '@OUTPUT@', '@INPUT@'],\n> install : true,\n> install_dir : join_paths('include', include_dir))\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 2b1850897aa4..ebce19d90c1e 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -94,7 +94,6 @@ foreach source : control_source_files\n> control_sources += custom_target(source + '_cpp',\n> input : input_files,\n> output : source + '.cpp',\n> - depend_files : gen_controls,\n> command : [gen_controls, '-o', '@OUTPUT@', '@INPUT@'])\n> endforeach\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D755CBD160\n\tfor ;\n\tTue, 9 Feb 2021 08:40:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A535E61623;\n\tTue, 9 Feb 2021 09:40:11 +0100 (CET)","from mail-lf1-x133.google.com (mail-lf1-x133.google.com\n\t[IPv6:2a00:1450:4864:20::133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 559BA60300\n\tfor ;\n\tTue, 9 Feb 2021 09:40:10 +0100 (CET)","by mail-lf1-x133.google.com with SMTP id h26so820220lfm.1\n\tfor ;\n\tTue, 09 Feb 2021 00:40:10 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tz5sm2425155lft.51.2021.02.09.00.40.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Feb 2021 00:40:09 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"Fd3QFBoQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=0BzEbqgK/UuhIg3fwjjBOo/PtsveRNex6y6RboQCYto=;\n\tb=Fd3QFBoQv5O/NOwCq/Wdo18eERU5BDs249rng1+/hejoEXGilFBGAItPf3gVwjEaHR\n\tJm7YzR7mFaCicCdNe6B9Hf5X8t0lqOCxkNcZL9bwLGDvWFLxhyUPWGsOjZ01OcVWlNVo\n\telrXKTtZowFn9FT4sgPvsjzu0+UFOdOUaGAbabANT4LBM9y7LCtZO7ZE4+WQSOW3wnIf\n\tLscGYlQDmcsBynrO0uDHC+I0fqkw6gCklHiNfHTK38PifcWEgwEL0XXwaHpTgXaGHang\n\tQj/ruTqZxoauyk3Rx5lBscsbzmb4dhKGOULDdck3lCFXddHiwL9VuaezgDg4jiXuAn8Z\n\th7Jw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=0BzEbqgK/UuhIg3fwjjBOo/PtsveRNex6y6RboQCYto=;\n\tb=KRgs3Si6J44Qj/JMpAtMrIcGae18Quc57KavI+XTpAqqG9LdllFJ/i0zdNDlLZ/OOp\n\tvDqJa2fAX3Ra1chGSjqPk2rSuG2NlfJy3NgeGvCk6TrjMx22by4dNr8U2Tmo/m/CTwZY\n\ti9HaO3YrUCvvJ0JfJDXmrpjK7Kq7WJFKdwsIsyP5YFoNwceBkUxQerc4i/ceuBaqpTgd\n\tBBomo7UQUKNeaSrShPJyD3aGcHuRaBWZ/hRHfflCNWFcDqDaE6nbQvMTUbMg0VQN+HUK\n\tVjym3v87BDV815vHQ6NWyxdLxSgyHTOSUzSbqm2+DpoYK7lD58i7vD/XGjTwyLbrHqas\n\thF2w==","X-Gm-Message-State":"AOAM530nGOWXvDKTlCTn0MSUdwo1eOfsZDhusLe0WjrrlHmyaQSQ84iH\n\t037WGWa03dkZ9lYrCRs2bymLQjW4bnA187A8","X-Google-Smtp-Source":"ABdhPJyDP1CsJlM0PLl6z/qZfDUlFHTwSfme+XEt0hAPsuxWdVx3m2YGcXiitD+KyvxOaGS4x0hbzw==","X-Received":"by 2002:ac2:508f:: with SMTP id\n\tf15mr5757112lfm.527.1612860009869; \n\tTue, 09 Feb 2021 00:40:09 -0800 (PST)","Date":"Tue, 9 Feb 2021 09:40:08 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20210208222044.30514-1-laurent.pinchart@ideasonboard.com>\n\t<20210208222044.30514-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210208222044.30514-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Drop unneeded\n\tdepend_files from meson custom targets","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15096,"web_url":"https://patchwork.libcamera.org/comment/15096/","msgid":"<10d6b6ef-4ae4-f0c2-f9e5-0aadd6cd2766@ideasonboard.com>","date":"2021-02-11T15:40:28","subject":"Re: [libcamera-devel] [PATCH 1/2] meson: Fix coding style when\n\tdeclaring arrays","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\n\nOn 08/02/2021 22:20, Laurent Pinchart wrote:\n> The meson.build files mix array declarations with and without a space\n> after the opening and before the closing square bracket. The vast\n> majority of cases don't use spaces, so standardize on that.\n> \n> While it it, fix indentation in a few places.\n> \n\nLooks good to me.\n\nI'm surprised this wasn't done in\n\n41adc3f8d39e meson: Fix coding style in meson.build files\n\nReviewed-by: Kieran Bingham \n\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/internal/meson.build | 4 ++--\n> src/android/meson.build | 4 ++--\n> src/gstreamer/meson.build | 2 +-\n> src/ipa/ipu3/meson.build | 6 +++---\n> src/ipa/raspberrypi/meson.build | 2 +-\n> src/ipa/rkisp1/meson.build | 2 +-\n> src/ipa/vimc/meson.build | 2 +-\n> src/libcamera/meson.build | 4 ++--\n> src/meson.build | 4 ++--\n> src/qcam/meson.build | 8 ++++----\n> src/v4l2/meson.build | 2 +-\n> test/camera/meson.build | 10 +++++-----\n> test/controls/meson.build | 8 ++++----\n> test/ipc/meson.build | 2 +-\n> test/process/meson.build | 2 +-\n> test/serialization/meson.build | 2 +-\n> test/stream/meson.build | 12 ++++++------\n> test/v4l2_subdevice/meson.build | 4 ++--\n> test/v4l2_videodevice/meson.build | 18 +++++++++---------\n> 19 files changed, 49 insertions(+), 49 deletions(-)\n> \n> diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\n> index e67a359fb865..a1071721967e 100644\n> --- a/include/libcamera/internal/meson.build\n> +++ b/include/libcamera/internal/meson.build\n> @@ -4,9 +4,9 @@ subdir('tracepoints')\n> \n> libcamera_tracepoint_header = custom_target(\n> 'tp_header',\n> - input: [ 'tracepoints.h.in', tracepoint_files ],\n> + input: ['tracepoints.h.in', tracepoint_files],\n> output: 'tracepoints.h',\n> - command: [ gen_tracepoints_header, '@OUTPUT@', '@INPUT@' ],\n> + command: [gen_tracepoints_header, '@OUTPUT@', '@INPUT@'],\n> )\n> \n> libcamera_internal_headers = files([\n> diff --git a/src/android/meson.build b/src/android/meson.build\n> index 95d0f420a5bc..f5567a1cd8eb 100644\n> --- a/src/android/meson.build\n> +++ b/src/android/meson.build\n> @@ -32,9 +32,9 @@ if android_enabled\n> libyuv_vars.append_link_args('-ljpeg')\n> libyuv = cmake.subproject('libyuv', options : libyuv_vars)\n> libyuv_dep = libyuv.dependency('yuv')\n> - endif\n> + endif\n> \n> - android_deps += [ libyuv_dep, ]\n> + android_deps += [libyuv_dep]\n> endif\n> \n> android_hal_sources = files([\n> diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\n> index c9f0c13d969d..9e93ffac28b6 100644\n> --- a/src/gstreamer/meson.build\n> +++ b/src/gstreamer/meson.build\n> @@ -29,7 +29,7 @@ if glib_dep.found() and gstvideo_dep.found() and gstallocator_dep.found()\n> # complain about the ones we are not using. Silence the -Wunused-function\n> # warning in that case.\n> if cc.get_id() == 'clang' and glib_dep.version().version_compare('<2.63.0')\n> - libcamera_gst_cpp_args += [ '-Wno-unused-function' ]\n> + libcamera_gst_cpp_args += ['-Wno-unused-function']\n> endif\n> \n> libcamera_gst = shared_library('gstlibcamera',\n> diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\n> index 444c82453eac..d31594fcb213 100644\n> --- a/src/ipa/ipu3/meson.build\n> +++ b/src/ipa/ipu3/meson.build\n> @@ -5,8 +5,8 @@ ipa_name = 'ipa_ipu3'\n> mod = shared_module(ipa_name,\n> 'ipu3.cpp',\n> name_prefix : '',\n> - include_directories : [ ipa_includes, libipa_includes ],\n> - dependencies : [ libatomic, libcamera_dep ],\n> + include_directories : [ipa_includes, libipa_includes],\n> + dependencies : [libatomic, libcamera_dep],\n> link_with : libipa,\n> install : true,\n> install_dir : ipa_install_dir)\n> @@ -15,7 +15,7 @@ if ipa_sign_module\n> custom_target(ipa_name + '.so.sign',\n> input : mod,\n> output : ipa_name + '.so.sign',\n> - command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],\n> + command : [ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@'],\n> install : false,\n> build_by_default : true)\n> endif\n> diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build\n> index 9445cd097df5..9e9ea80b93ad 100644\n> --- a/src/ipa/raspberrypi/meson.build\n> +++ b/src/ipa/raspberrypi/meson.build\n> @@ -54,7 +54,7 @@ if ipa_sign_module\n> custom_target(ipa_name + '.so.sign',\n> input : mod,\n> output : ipa_name + '.so.sign',\n> - command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],\n> + command : [ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@'],\n> install : false,\n> build_by_default : true)\n> endif\n> diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\n> index ed9a6b6b8ec8..95eb5393f76f 100644\n> --- a/src/ipa/rkisp1/meson.build\n> +++ b/src/ipa/rkisp1/meson.build\n> @@ -15,7 +15,7 @@ if ipa_sign_module\n> custom_target(ipa_name + '.so.sign',\n> input : mod,\n> output : ipa_name + '.so.sign',\n> - command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],\n> + command : [ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@'],\n> install : false,\n> build_by_default : true)\n> endif\n> diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build\n> index 8c9df854007a..b1544c289932 100644\n> --- a/src/ipa/vimc/meson.build\n> +++ b/src/ipa/vimc/meson.build\n> @@ -15,7 +15,7 @@ if ipa_sign_module\n> custom_target(ipa_name + '.so.sign',\n> input : mod,\n> output : ipa_name + '.so.sign',\n> - command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],\n> + command : [ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@'],\n> install : false,\n> build_by_default : true)\n> endif\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 5a4bf0d7ba4f..2b1850897aa4 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -111,9 +111,9 @@ libcamera_sources += version_cpp\n> \n> if ipa_sign_module\n> ipa_pub_key_cpp = custom_target('ipa_pub_key_cpp',\n> - input : [ ipa_priv_key, 'ipa_pub_key.cpp.in' ],\n> + input : [ipa_priv_key, 'ipa_pub_key.cpp.in'],\n> output : 'ipa_pub_key.cpp',\n> - command : [ gen_ipa_pub_key, '@INPUT@', '@OUTPUT@' ])\n> + command : [gen_ipa_pub_key, '@INPUT@', '@OUTPUT@'])\n> \n> libcamera_sources += ipa_pub_key_cpp\n> endif\n> diff --git a/src/meson.build b/src/meson.build\n> index 4b75f05878bc..0b26ca70f7de 100644\n> --- a/src/meson.build\n> +++ b/src/meson.build\n> @@ -3,8 +3,8 @@\n> openssl = find_program('openssl', required : true)\n> if openssl.found()\n> ipa_priv_key = custom_target('ipa-priv-key',\n> - output : [ 'ipa-priv-key.pem' ],\n> - command : [ gen_ipa_priv_key, '@OUTPUT@' ])\n> + output : ['ipa-priv-key.pem'],\n> + command : [gen_ipa_priv_key, '@OUTPUT@'])\n> config_h.set('HAVE_IPA_PUBKEY', 1)\n> ipa_sign_module = true\n> else\n> diff --git a/src/qcam/meson.build b/src/qcam/meson.build\n> index ebcd5ca010cf..8f3d50dd71c5 100644\n> --- a/src/qcam/meson.build\n> +++ b/src/qcam/meson.build\n> @@ -32,12 +32,12 @@ if qt5_dep.found()\n> qt5_dep,\n> ]\n> \n> - qt5_cpp_args = [ '-DQT_NO_KEYWORDS' ]\n> + qt5_cpp_args = ['-DQT_NO_KEYWORDS']\n> \n> tiff_dep = dependency('libtiff-4', required : false)\n> if tiff_dep.found()\n> - qt5_cpp_args += [ '-DHAVE_TIFF' ]\n> - qcam_deps += [ tiff_dep ]\n> + qt5_cpp_args += ['-DHAVE_TIFF']\n> + qcam_deps += [tiff_dep]\n> qcam_sources += files([\n> 'dng_writer.cpp',\n> ])\n> @@ -62,7 +62,7 @@ if qt5_dep.found()\n> if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> qt5_dep.version().version_compare('<5.13')) or\n> (cc.get_id() == 'clang' and cc.version().version_compare('>=10.0')))\n> - qt5_cpp_args += [ '-Wno-deprecated-copy' ]\n> + qt5_cpp_args += ['-Wno-deprecated-copy']\n> endif\n> \n> resources = qt5.preprocess(moc_headers: qcam_moc_headers,\n> diff --git a/src/v4l2/meson.build b/src/v4l2/meson.build\n> index dbe6a424b10e..c8b794247560 100644\n> --- a/src/v4l2/meson.build\n> +++ b/src/v4l2/meson.build\n> @@ -28,5 +28,5 @@ v4l2_compat = shared_library('v4l2-compat',\n> v4l2_compat_sources,\n> name_prefix : '',\n> install : true,\n> - dependencies : [ libcamera_dep, libdl ],\n> + dependencies : [libcamera_dep, libdl],\n> cpp_args : v4l2_compat_cpp_args)\n> diff --git a/test/camera/meson.build b/test/camera/meson.build\n> index 0395e7ddc7a4..9cb95affffab 100644\n> --- a/test/camera/meson.build\n> +++ b/test/camera/meson.build\n> @@ -3,11 +3,11 @@\n> # Tests are listed in order of complexity.\n> # They are not alphabetically sorted.\n> camera_tests = [\n> - [ 'configuration_default', 'configuration_default.cpp' ],\n> - [ 'configuration_set', 'configuration_set.cpp' ],\n> - [ 'buffer_import', 'buffer_import.cpp' ],\n> - [ 'statemachine', 'statemachine.cpp' ],\n> - [ 'capture', 'capture.cpp' ],\n> + ['configuration_default', 'configuration_default.cpp'],\n> + ['configuration_set', 'configuration_set.cpp'],\n> + ['buffer_import', 'buffer_import.cpp'],\n> + ['statemachine', 'statemachine.cpp'],\n> + ['capture', 'capture.cpp'],\n> ]\n> \n> foreach t : camera_tests\n> diff --git a/test/controls/meson.build b/test/controls/meson.build\n> index 545fb03b16c6..188c96da3336 100644\n> --- a/test/controls/meson.build\n> +++ b/test/controls/meson.build\n> @@ -1,10 +1,10 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> control_tests = [\n> - [ 'control_info', 'control_info.cpp' ],\n> - [ 'control_info_map', 'control_info_map.cpp' ],\n> - [ 'control_list', 'control_list.cpp' ],\n> - [ 'control_value', 'control_value.cpp' ],\n> + ['control_info', 'control_info.cpp'],\n> + ['control_info_map', 'control_info_map.cpp'],\n> + ['control_list', 'control_list.cpp'],\n> + ['control_value', 'control_value.cpp'],\n> ]\n> \n> foreach t : control_tests\n> diff --git a/test/ipc/meson.build b/test/ipc/meson.build\n> index 650df1d63444..9f413ff68efc 100644\n> --- a/test/ipc/meson.build\n> +++ b/test/ipc/meson.build\n> @@ -1,7 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> ipc_tests = [\n> - [ 'unixsocket', 'unixsocket.cpp' ],\n> + ['unixsocket', 'unixsocket.cpp'],\n> ]\n> \n> foreach t : ipc_tests\n> diff --git a/test/process/meson.build b/test/process/meson.build\n> index c215fa7e6c12..d2272d509db3 100644\n> --- a/test/process/meson.build\n> +++ b/test/process/meson.build\n> @@ -1,7 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> process_tests = [\n> - [ 'process_test', 'process_test.cpp' ],\n> + ['process_test', 'process_test.cpp'],\n> ]\n> \n> foreach t : process_tests\n> diff --git a/test/serialization/meson.build b/test/serialization/meson.build\n> index a9d9cbcb7d80..6fc54f6b6586 100644\n> --- a/test/serialization/meson.build\n> +++ b/test/serialization/meson.build\n> @@ -1,7 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> serialization_tests = [\n> - [ 'control_serialization', 'control_serialization.cpp' ],\n> + ['control_serialization', 'control_serialization.cpp'],\n> ]\n> \n> foreach t : serialization_tests\n> diff --git a/test/stream/meson.build b/test/stream/meson.build\n> index 2b9b29a9143b..5d3ef5881b44 100644\n> --- a/test/stream/meson.build\n> +++ b/test/stream/meson.build\n> @@ -1,13 +1,13 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> stream_tests = [\n> - [ 'stream_formats', 'stream_formats.cpp' ],\n> + ['stream_formats', 'stream_formats.cpp'],\n> ]\n> \n> foreach t : stream_tests\n> - exe = executable(t[0], t[1],\n> - dependencies : libcamera_dep,\n> - link_with : test_libraries,\n> - include_directories : test_includes_internal)\n> - test(t[0], exe, suite: 'stream')\n> + exe = executable(t[0], t[1],\n> + dependencies : libcamera_dep,\n> + link_with : test_libraries,\n> + include_directories : test_includes_internal)\n> + test(t[0], exe, suite: 'stream')\n> endforeach\n> diff --git a/test/v4l2_subdevice/meson.build b/test/v4l2_subdevice/meson.build\n> index 5f0882ca9772..40d39766af9b 100644\n> --- a/test/v4l2_subdevice/meson.build\n> +++ b/test/v4l2_subdevice/meson.build\n> @@ -1,8 +1,8 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> v4l2_subdevice_tests = [\n> - [ 'list_formats', 'list_formats.cpp'],\n> - [ 'test_formats', 'test_formats.cpp'],\n> + ['list_formats', 'list_formats.cpp'],\n> + ['test_formats', 'test_formats.cpp'],\n> ]\n> \n> foreach t : v4l2_subdevice_tests\n> diff --git a/test/v4l2_videodevice/meson.build b/test/v4l2_videodevice/meson.build\n> index b4bb30908027..e733518c0185 100644\n> --- a/test/v4l2_videodevice/meson.build\n> +++ b/test/v4l2_videodevice/meson.build\n> @@ -3,15 +3,15 @@\n> # Tests are listed in order of complexity.\n> # They are not alphabetically sorted.\n> v4l2_videodevice_tests = [\n> - [ 'double_open', 'double_open.cpp' ],\n> - [ 'controls', 'controls.cpp' ],\n> - [ 'formats', 'formats.cpp' ],\n> - [ 'request_buffers', 'request_buffers.cpp' ],\n> - [ 'buffer_cache', 'buffer_cache.cpp' ],\n> - [ 'stream_on_off', 'stream_on_off.cpp' ],\n> - [ 'capture_async', 'capture_async.cpp' ],\n> - [ 'buffer_sharing', 'buffer_sharing.cpp' ],\n> - [ 'v4l2_m2mdevice', 'v4l2_m2mdevice.cpp' ],\n> + ['double_open', 'double_open.cpp'],\n> + ['controls', 'controls.cpp'],\n> + ['formats', 'formats.cpp'],\n> + ['request_buffers', 'request_buffers.cpp'],\n> + ['buffer_cache', 'buffer_cache.cpp'],\n> + ['stream_on_off', 'stream_on_off.cpp'],\n> + ['capture_async', 'capture_async.cpp'],\n> + ['buffer_sharing', 'buffer_sharing.cpp'],\n> + ['v4l2_m2mdevice', 'v4l2_m2mdevice.cpp'],\n> ]\n> \n> foreach t : v4l2_videodevice_tests\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79B85BD162\n\tfor ;\n\tThu, 11 Feb 2021 15:40:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6C7463744;\n\tThu, 11 Feb 2021 16:40:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A6EC2601B5\n\tfor ;\n\tThu, 11 Feb 2021 16:40:31 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 160A941;\n\tThu, 11 Feb 2021 16:40:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Xdl1RlWR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613058031;\n\tbh=8twoPLU8T1VNRe27s2N1klLBQ8oZxJAgClOLu4ERVTg=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Xdl1RlWRRnPLCYhNUpf8G/JYDQdv5AzpTB0VOeAQGd4Rod72JO8EyG0Xp2XFQMLRE\n\tCh4sEz/jXqwmV9P0IEfu+k557Ph+FkjVrYf8ljRrxzJNU5gVmAM0cN1WW45qGLhofX\n\tUPTdEmPTgywe/uR4ehe5UNCuFcH14ytfT6jsBkoM=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210208222044.30514-1-laurent.pinchart@ideasonboard.com>\n\t<20210208222044.30514-2-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<10d6b6ef-4ae4-f0c2-f9e5-0aadd6cd2766@ideasonboard.com>","Date":"Thu, 11 Feb 2021 15:40:28 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210208222044.30514-2-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/2] meson: Fix coding style when\n\tdeclaring arrays","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15097,"web_url":"https://patchwork.libcamera.org/comment/15097/","msgid":"<4a959007-a244-6083-d21f-dd9c76b10ccf@ideasonboard.com>","date":"2021-02-11T15:46:18","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Drop unneeded\n\tdepend_files from meson custom targets","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 08/02/2021 22:20, Laurent Pinchart wrote:\n> The meson custom_target() function accepts a 'depend_files' argument to\n> list additional dependency files. Files already listed in the 'command'\n> argument are handled automatically, and don't need to be added manually.\n> Drop them.\n> \n\nSeems to make sense. This makes me remember the race conditions we've\nhad in the past, but I can't see that this makes a difference here, so I\nthink it's good as long at the dependency is met.\n\nReviewed-by: Kieran Bingham \n\n\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/meson.build | 1 -\n> src/libcamera/meson.build | 1 -\n> 2 files changed, 2 deletions(-)\n> \n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index 13e9eeb6d6ad..eb787d44746a 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -46,7 +46,6 @@ foreach header : control_source_files\n> control_headers += custom_target(header + '_h',\n> input : input_files,\n> output : header + '.h',\n> - depend_files : gen_controls,\n> command : [gen_controls, '-o', '@OUTPUT@', '@INPUT@'],\n> install : true,\n> install_dir : join_paths('include', include_dir))\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 2b1850897aa4..ebce19d90c1e 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -94,7 +94,6 @@ foreach source : control_source_files\n> control_sources += custom_target(source + '_cpp',\n> input : input_files,\n> output : source + '.cpp',\n> - depend_files : gen_controls,\n> command : [gen_controls, '-o', '@OUTPUT@', '@INPUT@'])\n> endforeach\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B03EBD160\n\tfor ;\n\tThu, 11 Feb 2021 15:46:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4B0463744;\n\tThu, 11 Feb 2021 16:46:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 57058601B5\n\tfor ;\n\tThu, 11 Feb 2021 16:46:22 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B9B4A41;\n\tThu, 11 Feb 2021 16:46:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vajxCUZJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613058381;\n\tbh=5A0LXmEF4+p4MkU8LBmatidp9z12CCpnb25MHi2VEUo=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=vajxCUZJdr2+ZUiLdKNm7dgdjxg7xTvGmmZMiXilZcsih0WaMeD0Es1uh3szJP63V\n\tTC0x/f2SbHvt3af1yMObKfpXmNCxDhZM9dX4K7wKl9/Ok1M3ypAkzU+zjin3heSyeu\n\til/kzeMHbVN2z/w4z6mdXqE6RIhoEl/Dj3uiJ/5Y=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210208222044.30514-1-laurent.pinchart@ideasonboard.com>\n\t<20210208222044.30514-3-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<4a959007-a244-6083-d21f-dd9c76b10ccf@ideasonboard.com>","Date":"Thu, 11 Feb 2021 15:46:18 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210208222044.30514-3-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Drop unneeded\n\tdepend_files from meson custom targets","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15098,"web_url":"https://patchwork.libcamera.org/comment/15098/","msgid":"","date":"2021-02-11T16:02:29","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Drop unneeded\n\tdepend_files from meson custom targets","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Feb 11, 2021 at 03:46:18PM +0000, Kieran Bingham wrote:\n> On 08/02/2021 22:20, Laurent Pinchart wrote:\n> > The meson custom_target() function accepts a 'depend_files' argument to\n> > list additional dependency files. Files already listed in the 'command'\n> > argument are handled automatically, and don't need to be added manually.\n> > Drop them.\n> \n> Seems to make sense. This makes me remember the race conditions we've\n> had in the past, but I can't see that this makes a difference here, so I\n> think it's good as long at the dependency is met.\n\nIf it helps you sleep better, I've checked both the meson implementation\nand the generated ninja files to make sure the dependency is correctly\nhandled through the command argument, and it seems to be the case.\n\n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > include/libcamera/meson.build | 1 -\n> > src/libcamera/meson.build | 1 -\n> > 2 files changed, 2 deletions(-)\n> > \n> > diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> > index 13e9eeb6d6ad..eb787d44746a 100644\n> > --- a/include/libcamera/meson.build\n> > +++ b/include/libcamera/meson.build\n> > @@ -46,7 +46,6 @@ foreach header : control_source_files\n> > control_headers += custom_target(header + '_h',\n> > input : input_files,\n> > output : header + '.h',\n> > - depend_files : gen_controls,\n> > command : [gen_controls, '-o', '@OUTPUT@', '@INPUT@'],\n> > install : true,\n> > install_dir : join_paths('include', include_dir))\n> > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > index 2b1850897aa4..ebce19d90c1e 100644\n> > --- a/src/libcamera/meson.build\n> > +++ b/src/libcamera/meson.build\n> > @@ -94,7 +94,6 @@ foreach source : control_source_files\n> > control_sources += custom_target(source + '_cpp',\n> > input : input_files,\n> > output : source + '.cpp',\n> > - depend_files : gen_controls,\n> > command : [gen_controls, '-o', '@OUTPUT@', '@INPUT@'])\n> > endforeach\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42FE6BD162\n\tfor ;\n\tThu, 11 Feb 2021 16:02:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9AA0963744;\n\tThu, 11 Feb 2021 17:02:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F79D601B5\n\tfor ;\n\tThu, 11 Feb 2021 17:02:54 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DD6A041;\n\tThu, 11 Feb 2021 17:02:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CjN71HKp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613059374;\n\tbh=Uo0FMzHkT1UqFYq1InDViSi511VVFnxWSC5FR1Bi0BA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CjN71HKpFO77A4gJcIv59Swa6T4TQOJl6j/nml6m6BQ5S3EfA2gNsvwpWkO+mp4/M\n\ttDap7XxPysEqKTvRxwrPYnVIuMU51Wx7Iy/UkzE8AlZbptjeHlf245swhG5nqbY3oh\n\th6fCWe5Azpo4X93TOzr7BHg2bVYXED5urh+deao4=","Date":"Thu, 11 Feb 2021 18:02:29 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210208222044.30514-1-laurent.pinchart@ideasonboard.com>\n\t<20210208222044.30514-3-laurent.pinchart@ideasonboard.com>\n\t<4a959007-a244-6083-d21f-dd9c76b10ccf@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<4a959007-a244-6083-d21f-dd9c76b10ccf@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Drop unneeded\n\tdepend_files from meson custom targets","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15099,"web_url":"https://patchwork.libcamera.org/comment/15099/","msgid":"<98ca5b2b-9353-ecea-1595-08f14de443d1@ideasonboard.com>","date":"2021-02-11T16:15:15","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Drop unneeded\n\tdepend_files from meson custom targets","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 11/02/2021 16:02, Laurent Pinchart wrote:\n> Hi Kieran,\n>> Seems to make sense. This makes me remember the race conditions we've\n>> had in the past, but I can't see that this makes a difference here, so I\n>> think it's good as long at the dependency is met.\n> \n> If it helps you sleep better, I've checked both the meson implementation\n> and the generated ninja files to make sure the dependency is correctly\n> handled through the command argument, and it seems to be the case.\n\nZZzzzzzz ;-D\n\n> \n>> Reviewed-by: Kieran Bingham \n>>\n>>> Signed-off-by: Laurent Pinchart ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2C28BD160\n\tfor ;\n\tThu, 11 Feb 2021 16:15:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E36063745;\n\tThu, 11 Feb 2021 17:15:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B1E5601B5\n\tfor ;\n\tThu, 11 Feb 2021 17:15:18 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A16FE41;\n\tThu, 11 Feb 2021 17:15:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"e2VM2qwu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613060117;\n\tbh=Ac4p2JTHz+69Tj6UKZKINUnPPCIjG7qBzPMuwEgV6BM=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=e2VM2qwu606n2KuAMEiV7df65hifzFYKIQnBC0c4Rk/jTrfI8inEMYeNokzYxV/hD\n\tokics5tAYMKEsHx/fa0n8+hpJo8DtkJR9d8oITUejYCpAaMFDvgMK6A4uXEM7xFNmO\n\tD/aHxRghnE9u21XcGsirk2CqN5J2fN5GshyZ2v+g=","To":"Laurent Pinchart ","References":"<20210208222044.30514-1-laurent.pinchart@ideasonboard.com>\n\t<20210208222044.30514-3-laurent.pinchart@ideasonboard.com>\n\t<4a959007-a244-6083-d21f-dd9c76b10ccf@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<98ca5b2b-9353-ecea-1595-08f14de443d1@ideasonboard.com>","Date":"Thu, 11 Feb 2021 16:15:15 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Drop unneeded\n\tdepend_files from meson custom targets","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]