[{"id":15071,"web_url":"https://patchwork.libcamera.org/comment/15071/","msgid":"","date":"2021-02-09T00:40:30","subject":"Re: [libcamera-devel] [PATCH v6 0/6] Raspberry Pi: Colour denoise","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Mon, Feb 08, 2021 at 03:07:32PM +0000, Naushir Patuck wrote:\n> Hi all,\n> \n> Here is the next revision of the colour denoise work.\n> \n> This version includes all of the small typos pointed out in the last round of reviews.\n> I've also added a \\todo for the following items:\n> 1) Disable ISP output 1 if we know colour denoise will not be running due to a resolution/format mismatch.\n> 2) Return out the correct metadata status for CDN if it is not running.\n\nThere's a typo in patch 2/6, and I think there's also a bug in 4/6 that\nwas likely cause by a rebase problem. I can fix these when applying if\nmy analysis is correct.\n\n> Naushir Patuck (6):\n> pipeline: raspberrypi: Refactor stream configuration routine\n> pipeline: raspberrypi: Set the ISP Output1 to 1/4 resolution if unused\n> uapi: raspberrypi: Update the bcm2835-isp header definition\n> ipa: raspberrypi: Rename SdnStatus to DenoiseStatus\n> ipa: raspberrypi: Add a DenoiseAlgorithm class to the Controller\n> ipa: raspberrypi: Handle control::NoiseReductionMode in the controller\n> \n> include/libcamera/ipa/raspberrypi.h | 1 +\n> include/linux/bcm2835-isp.h | 32 +++++-\n> .../controller/denoise_algorithm.hpp | 23 +++++\n> .../raspberrypi/controller/denoise_status.h | 24 +++++\n> src/ipa/raspberrypi/controller/rpi/sdn.cpp | 15 ++-\n> src/ipa/raspberrypi/controller/rpi/sdn.hpp | 5 +-\n> src/ipa/raspberrypi/controller/sdn_status.h | 23 -----\n> src/ipa/raspberrypi/raspberrypi.cpp | 65 ++++++++++++-\n> .../pipeline/raspberrypi/raspberrypi.cpp | 97 +++++++++++--------\n> 9 files changed, 210 insertions(+), 75 deletions(-)\n> create mode 100644 src/ipa/raspberrypi/controller/denoise_algorithm.hpp\n> create mode 100644 src/ipa/raspberrypi/controller/denoise_status.h\n> delete mode 100644 src/ipa/raspberrypi/controller/sdn_status.h","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 989CFBD162\n\tfor ;\n\tTue, 9 Feb 2021 00:40:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D3536160B;\n\tTue, 9 Feb 2021 01:40:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9C496148F\n\tfor ;\n\tTue, 9 Feb 2021 01:40:54 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 407AD583;\n\tTue, 9 Feb 2021 01:40:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UKSZTu0t\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612831254;\n\tbh=e4IoR30tdcOjNx0D0fr+5QBOWPGPDbc7/U7P9qOwBHs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UKSZTu0tnCpfA41tKc86/3I50dR9NWy2ZGwUgnNNQAsnODqcjlx6lrOEeO2H4dOBS\n\t4Kpm2mBOeI+TPtzTWCmLPpnFdfLJPHurn5DRm3WsdGtGYk6/VWBjAShw0Rsnm4Xux6\n\t99byMKb7y4j/U6xoofb7pJ+YV4/hPz/xoMGvJFyw=","Date":"Tue, 9 Feb 2021 02:40:30 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20210208150738.2293520-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210208150738.2293520-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v6 0/6] Raspberry Pi: Colour denoise","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15078,"web_url":"https://patchwork.libcamera.org/comment/15078/","msgid":"","date":"2021-02-09T07:32:39","subject":"Re: [libcamera-devel] [PATCH v6 0/6] Raspberry Pi: Colour denoise","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nOn Tue, 9 Feb 2021 at 00:40, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Naush,\n>\n> On Mon, Feb 08, 2021 at 03:07:32PM +0000, Naushir Patuck wrote:\n> > Hi all,\n> >\n> > Here is the next revision of the colour denoise work.\n> >\n> > This version includes all of the small typos pointed out in the last\n> round of reviews.\n> > I've also added a \\todo for the following items:\n> > 1) Disable ISP output 1 if we know colour denoise will not be running\n> due to a resolution/format mismatch.\n> > 2) Return out the correct metadata status for CDN if it is not running.\n>\n> There's a typo in patch 2/6, and I think there's also a bug in 4/6 that\n> was likely cause by a rebase problem. I can fix these when applying if\n> my analysis is correct.\n>\n\nYes, if it's not too much trouble, please go ahead and fix all the issues\nyou raised before merging.\n\nThanks again!\nNaush\n\n\n\n>\n> > Naushir Patuck (6):\n> > pipeline: raspberrypi: Refactor stream configuration routine\n> > pipeline: raspberrypi: Set the ISP Output1 to 1/4 resolution if unused\n> > uapi: raspberrypi: Update the bcm2835-isp header definition\n> > ipa: raspberrypi: Rename SdnStatus to DenoiseStatus\n> > ipa: raspberrypi: Add a DenoiseAlgorithm class to the Controller\n> > ipa: raspberrypi: Handle control::NoiseReductionMode in the controller\n> >\n> > include/libcamera/ipa/raspberrypi.h | 1 +\n> > include/linux/bcm2835-isp.h | 32 +++++-\n> > .../controller/denoise_algorithm.hpp | 23 +++++\n> > .../raspberrypi/controller/denoise_status.h | 24 +++++\n> > src/ipa/raspberrypi/controller/rpi/sdn.cpp | 15 ++-\n> > src/ipa/raspberrypi/controller/rpi/sdn.hpp | 5 +-\n> > src/ipa/raspberrypi/controller/sdn_status.h | 23 -----\n> > src/ipa/raspberrypi/raspberrypi.cpp | 65 ++++++++++++-\n> > .../pipeline/raspberrypi/raspberrypi.cpp | 97 +++++++++++--------\n> > 9 files changed, 210 insertions(+), 75 deletions(-)\n> > create mode 100644 src/ipa/raspberrypi/controller/denoise_algorithm.hpp\n> > create mode 100644 src/ipa/raspberrypi/controller/denoise_status.h\n> > delete mode 100644 src/ipa/raspberrypi/controller/sdn_status.h\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56E4CBD162\n\tfor ;\n\tTue, 9 Feb 2021 07:32:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC6816161B;\n\tTue, 9 Feb 2021 08:32:58 +0100 (CET)","from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com\n\t[IPv6:2a00:1450:4864:20::22c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AE2B613F3\n\tfor ;\n\tTue, 9 Feb 2021 08:32:57 +0100 (CET)","by mail-lj1-x22c.google.com with SMTP id e18so21005640lja.12\n\tfor ;\n\tMon, 08 Feb 2021 23:32:57 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"CXFMult2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=ZVoGGmjv+uXU47tGyYq6cn00D9zMVWRIT+uR3JtL7G8=;\n\tb=CXFMult2ZmxGNixGqn1zvKxyy/EqbGIiZ3U43EM/E4OCSDScsUaNXzxqXe3sNk27V2\n\tgn7HC7RCt5E72D/ExX4heUPts4hY/MC/Ij8W0D2waRA6A4Zt6cBujd9svaosabFnU1qp\n\tlkqbygEE8j6G0I4qkrBIy5GMomWGq4M+SMUzXc+uk6qWhprD7VJE06S4DYWYnUySX/YM\n\twshXSQXjfu7EC9/WZ6TNP16fY86cYd9B6UJ92AwXIg5v2r/ko2FQ+enqF56YwbC0LrP0\n\tUCvSdnrqB0T7hNNjREeuXLa0Xw7e4uNZ/TwiwNTskl+roI1KHF6ER0hYx4WIVLYDmaay\n\tt86A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=ZVoGGmjv+uXU47tGyYq6cn00D9zMVWRIT+uR3JtL7G8=;\n\tb=XzpxgKtPhVMeEuqVQbZ3puexr983GoJDlu0wimy3cTMACx5N1DEYcxiXNetdXT71TO\n\tjRloiAAo0UQ7IY+cs+VXzFd/+iLLdz9y2Sh78GftVI8IHOc/v2eB7hLYuVAZf8lyHi2b\n\tuK0zWC/VLYeqjKD4IRc3xNO5eKogrMgtM7ybV5MZzc2sZV9HIppd+/1YzFybiLySFsn2\n\tXTJYUq7WR0tF1NUEPMNaAWlfCuEMFbk8Gpmfih1P5qaAKdWkEnXuEaWcvz/IRqC5jql4\n\tzZNHgIV07hhY8aRFCwFwkNGOK/LrjQ4xqX8x8cwzqNFpmpcBkP+R2v+VZ7G7ghtpEWGV\n\tHr4w==","X-Gm-Message-State":"AOAM53054KM/fQtarrLReby24KfbqCOd7uNXmYUhpW7aKdEdSjfRjbuc\n\t6/CYBEN53riOuyBjb+ywyh+zOvlSZvNdordzL2H5AsnSMKgJ7Q==","X-Google-Smtp-Source":"ABdhPJyKHZZsmCXyEU0lXCrXk5ka3oUC9uejfy+99ODAwo2HLk3EjjsgDRI4UJV10jyEJbBcmbhcgBNf9i2J8MCj9Bo=","X-Received":"by 2002:a2e:a376:: with SMTP id\n\ti22mr6785325ljn.299.1612855976675; \n\tMon, 08 Feb 2021 23:32:56 -0800 (PST)","MIME-Version":"1.0","References":"<20210208150738.2293520-1-naush@raspberrypi.com>\n\t","In-Reply-To":"","From":"Naushir Patuck ","Date":"Tue, 9 Feb 2021 07:32:39 +0000","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v6 0/6] Raspberry Pi: Colour denoise","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============2355633794431894487==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15081,"web_url":"https://patchwork.libcamera.org/comment/15081/","msgid":"","date":"2021-02-09T13:31:22","subject":"Re: [libcamera-devel] [PATCH v6 0/6] Raspberry Pi: Colour denoise","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Tue, Feb 09, 2021 at 07:32:39AM +0000, Naushir Patuck wrote:\n> On Tue, 9 Feb 2021 at 00:40, Laurent Pinchart wrote:\n> > On Mon, Feb 08, 2021 at 03:07:32PM +0000, Naushir Patuck wrote:\n> > > Hi all,\n> > >\n> > > Here is the next revision of the colour denoise work.\n> > >\n> > > This version includes all of the small typos pointed out in the\n> > > last round of reviews.\n> > > I've also added a \\todo for the following items:\n> > > 1) Disable ISP output 1 if we know colour denoise will not be\n> > > running due to a resolution/format mismatch.\n> > > 2) Return out the correct metadata status for CDN if it is not running.\n> >\n> > There's a typo in patch 2/6, and I think there's also a bug in 4/6 that\n> > was likely cause by a rebase problem. I can fix these when applying if\n> > my analysis is correct.\n> \n> Yes, if it's not too much trouble, please go ahead and fix all the issues\n> you raised before merging.\n\nDone.\n\n> > > Naushir Patuck (6):\n> > > pipeline: raspberrypi: Refactor stream configuration routine\n> > > pipeline: raspberrypi: Set the ISP Output1 to 1/4 resolution if unused\n> > > uapi: raspberrypi: Update the bcm2835-isp header definition\n> > > ipa: raspberrypi: Rename SdnStatus to DenoiseStatus\n> > > ipa: raspberrypi: Add a DenoiseAlgorithm class to the Controller\n> > > ipa: raspberrypi: Handle control::NoiseReductionMode in the controller\n> > >\n> > > include/libcamera/ipa/raspberrypi.h | 1 +\n> > > include/linux/bcm2835-isp.h | 32 +++++-\n> > > .../controller/denoise_algorithm.hpp | 23 +++++\n> > > .../raspberrypi/controller/denoise_status.h | 24 +++++\n> > > src/ipa/raspberrypi/controller/rpi/sdn.cpp | 15 ++-\n> > > src/ipa/raspberrypi/controller/rpi/sdn.hpp | 5 +-\n> > > src/ipa/raspberrypi/controller/sdn_status.h | 23 -----\n> > > src/ipa/raspberrypi/raspberrypi.cpp | 65 ++++++++++++-\n> > > .../pipeline/raspberrypi/raspberrypi.cpp | 97 +++++++++++--------\n> > > 9 files changed, 210 insertions(+), 75 deletions(-)\n> > > create mode 100644 src/ipa/raspberrypi/controller/denoise_algorithm.hpp\n> > > create mode 100644 src/ipa/raspberrypi/controller/denoise_status.h\n> > > delete mode 100644 src/ipa/raspberrypi/controller/sdn_status.h","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E8AABD162\n\tfor ;\n\tTue, 9 Feb 2021 13:31:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 86F6461624;\n\tTue, 9 Feb 2021 14:31:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E1A060D16\n\tfor ;\n\tTue, 9 Feb 2021 14:31:46 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF3EB9AA;\n\tTue, 9 Feb 2021 14:31:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ENOzhvoL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612877506;\n\tbh=2pFeWbRExGLLE9iB1ANSuZY9f6lG45RCWLkITJtiZ8k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ENOzhvoLu7nGeKTO3b6uQQ33BS5jTCy86fzhSXESVTvXS7T9+hqLTSqi6a37j2CI/\n\tReyvjWKkUTRqVX+jYldnq4MoXPudRsXNGkplLfuA9Qi1nn8G/Nm9ttz4He4hbcE5jr\n\tPOsQL9oE5PAXSApA6NWpIqN7ckJ7Qft3OCLKWTf4=","Date":"Tue, 9 Feb 2021 15:31:22 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20210208150738.2293520-1-naush@raspberrypi.com>\n\t\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v6 0/6] Raspberry Pi: Colour denoise","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]