[{"id":15058,"web_url":"https://patchwork.libcamera.org/comment/15058/","msgid":"","date":"2021-02-08T16:17:35","subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: raspberrypi: Remove\n\tlibatomic from build dependencies","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Mon, Feb 08, 2021 at 09:40:36AM +0000, David Plowman wrote:\n> With all the atomic variables removed from the Raspberry Pi control\n> algorithms, libatomic is no longer required.\n> \n> Signed-off-by: David Plowman \n> ---\n> src/ipa/raspberrypi/meson.build | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build\n> index 9445cd09..4cdd0434 100644\n> --- a/src/ipa/raspberrypi/meson.build\n> +++ b/src/ipa/raspberrypi/meson.build\n> @@ -5,7 +5,6 @@ ipa_name = 'ipa_rpi'\n> rpi_ipa_deps = [\n> libcamera_dep,\n> dependency('boost'),\n> - libatomic,\n\nAs mentioned in the previous version, I'm a bit cautious about this\nchange, because I don't fully understand the need to link to libatomic\non some platforms. I believe it should be safe, so I'm willing to give\nit a try.\n\nKieran, I think the issue was initially reported by builroot, when\ncompiling on sparc. Do we have an easy way to test this ?\n\n> ]\n> \n> rpi_ipa_includes = [","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32651BD162\n\tfor ;\n\tMon, 8 Feb 2021 16:18:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B909E60D37;\n\tMon, 8 Feb 2021 17:18:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8AD8A60D2B\n\tfor ;\n\tMon, 8 Feb 2021 17:17:59 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF2E73D7;\n\tMon, 8 Feb 2021 17:17:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jKQ2LSbh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612801079;\n\tbh=HUASdp9Ta1JpxUDXeXaXf+G61mzYJKba0BNALqpp3JY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jKQ2LSbh/WltYze4R1dQjK3D2JFfnweGdYDngXjUQoUMj4Wkgya8GPNLzW0wMxBHs\n\tVyrz/TOPgnG2dUQaLX/aMEbJam0/lvzHiSmAuERtNe/Pt0huje7ikwVEQvpl1ZSHmA\n\tq46BvMZ9aMeksNdJOtuq3ULK5A3uukUO7axXmSM0=","Date":"Mon, 8 Feb 2021 18:17:35 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20210208094036.6846-1-david.plowman@raspberrypi.com>\n\t<20210208094036.6846-3-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210208094036.6846-3-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: raspberrypi: Remove\n\tlibatomic from build dependencies","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]