[{"id":15232,"web_url":"https://patchwork.libcamera.org/comment/15232/","msgid":"","date":"2021-02-19T07:15:55","subject":"Re: [libcamera-devel] [RFC PATCH 0/6] Support stream mapping in\n\tAndroid HAL adaptation layer","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"+Jacopo Mondi +Laurent Pinchart\n\nHello Jacopo and Laurent (sorry for pointing fingers), as you have\njoined with my previous proposal discussion, may I please ask you to\nreview this patch series?\nI don't at all intend to submit the patch series at one time.\nI would like to hear your opinion about this direction.\nSome of them might be reasonable to submit shortly as they generalize\nthe post processing code.\n\n\nThanks so much in advance,\n-Hiro\n\n\n\nOn Thu, Feb 4, 2021 at 7:05 PM Hirokazu Honda wrote:\n>\n> This patch series implements a stream mapping in Android HAL\n> adaptaion layer. The stream mapping here means to map camera\n> streams that can be produced by a native camera to camera streams\n> requested by Android HAL client w/o post processing. This is\n> helpful for the libcamera Android HAL implementation to produce\n> camera streams that a camera device doesn't support and output\n> multiple streams.\n>\n> Hirokazu Honda (6):\n> libcamera: camera: Add tryValidate() to CameraConfiguration\n> libcamera: ipu3: Implement tryValidate() in IPU3CameraConfiguration\n> android: camera_stream: Pass post processor in configure()\n> android: camera_device: Implement toString() in Camera3StreamConfig\n> android: camera_device: Introduce PostProcessorType\n> android: camera_device: Support stream mapping\n>\n> include/libcamera/camera.h | 1 +\n> src/android/camera_device.cpp | 266 ++++++++++++++++++++++++++-\n> src/android/camera_stream.cpp | 31 +---\n> src/android/camera_stream.h | 2 +-\n> src/libcamera/camera.cpp | 22 +++\n> src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n> src/libcamera/pipeline/ipu3/imgu.h | 2 +-\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 160 ++++++++++++++++\n> 8 files changed, 453 insertions(+), 33 deletions(-)\n>\n> --\n> 2.30.0.365.g02bc693789-goog","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2ED8BD1F1\n\tfor ;\n\tFri, 19 Feb 2021 07:16:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0642689B7;\n\tFri, 19 Feb 2021 08:16:07 +0100 (CET)","from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com\n\t[IPv6:2a00:1450:4864:20::62f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45B0A6835F\n\tfor ;\n\tFri, 19 Feb 2021 08:16:06 +0100 (CET)","by mail-ej1-x62f.google.com with SMTP id w1so10472968ejf.11\n\tfor ;\n\tThu, 18 Feb 2021 23:16:06 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"fQ81VMGV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=JAQzlgukivRcm8usNw0iTkP2q1oNySf9LCCRSV3gFZ0=;\n\tb=fQ81VMGVztFf3OmozHcyzsqE/zixSuRbABJMA92bSWgz7nNmzAwBP8VB21Kyn+QZvx\n\t0MA1+sREYO6CtyGeki82TgSj0Bc8FqdckhMmfBSgzggsbTkKsUq7IoHI9j8Rr7eMM/d7\n\tuGbH7tvCfEAlmJjfF4SYNkSWyRkf7FG3Sdc6A=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=JAQzlgukivRcm8usNw0iTkP2q1oNySf9LCCRSV3gFZ0=;\n\tb=i8aDZv0EsWMM+qj0m9xQERiprwSo29Uj1rCjW1XIOHrWjG0kJGrWkIdW34R56LZati\n\tZV9/lpmAU3/x15io8RD6VyTOP8eogdhd6e5DVDkFACbc0wkCtpqWI5kVgrcb2JOLyCX9\n\toRV9WomJ0Nj2hSkJ86FDd/ibFs+1CFAtjCKa2Frxdg064jSElw9g3bbtJcMZE2+ihZdm\n\tlJ/Nsjz67PUnT5lBg1Vqr7dMjS1aRPQFCgpKhFUIQ49v0TaCyOLk7xPxgnywtOODb3x7\n\teI0A1tnaqWlcaXinaDOgZMqExHyZHCCKwgDh1CtwuCEaDdJl5bIBohjeInHveuHHsFPD\n\t8DWA==","X-Gm-Message-State":"AOAM531imUcHco/S/j8qnnNMJMfqGnUzzNGl/j0YtLW45ergHgK0oeJ7\n\t9NZkeoh8ZUj9d3gT3r9CDMzp5MoQz+4DTB7XKwojq4A4zHM=","X-Google-Smtp-Source":"ABdhPJz0Nu9Ga8ZwXDE67+Hqf97tQG3wQWjOW9pBZKPr2qaztG/5S4ZJySyjx+cOGB4WdXN3EVxzvhjnYcuzgNocTIw=","X-Received":"by 2002:a17:906:34d3:: with SMTP id\n\th19mr7571902ejb.55.1613718965682; \n\tThu, 18 Feb 2021 23:16:05 -0800 (PST)","MIME-Version":"1.0","References":"<20210204100541.657503-1-hiroh@chromium.org>","In-Reply-To":"<20210204100541.657503-1-hiroh@chromium.org>","From":"Hirokazu Honda ","Date":"Fri, 19 Feb 2021 16:15:55 +0900","Message-ID":"","To":"libcamera devel ,\n\tJacopo Mondi , \n\tLaurent Pinchart ","Subject":"Re: [libcamera-devel] [RFC PATCH 0/6] Support stream mapping in\n\tAndroid HAL adaptation layer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Hanlin Chen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15341,"web_url":"https://patchwork.libcamera.org/comment/15341/","msgid":"","date":"2021-03-01T02:08:09","subject":"Re: [libcamera-devel] [RFC PATCH 0/6] Support stream mapping in\n\tAndroid HAL adaptation layer","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nOn Fri, Feb 19, 2021 at 04:15:55PM +0900, Hirokazu Honda wrote:\n> +Jacopo Mondi +Laurent Pinchart\n> \n> Hello Jacopo and Laurent (sorry for pointing fingers), as you have\n> joined with my previous proposal discussion, may I please ask you to\n> review this patch series?\n> I don't at all intend to submit the patch series at one time.\n> I would like to hear your opinion about this direction.\n> Some of them might be reasonable to submit shortly as they generalize\n> the post processing code.\n\nI've been working on this over the past few days. There's no big issue\non the camera HAL side, but the tryValidate() API still bothers me :-S\n\nI'm finalizing patches for reprocessing support, which will change the\nconfiguration API. I've tried to take into account the needs that your\ntryValidate() operation expresses, hopefully it will be provide support\nto implement post-processed streams in the HAL.\n\nI'm afraid I need to ask you for just a bit more patience, I'll post\npatches to the list in the next few days.\n\n> On Thu, Feb 4, 2021 at 7:05 PM Hirokazu Honda wrote:\n> >\n> > This patch series implements a stream mapping in Android HAL\n> > adaptaion layer. The stream mapping here means to map camera\n> > streams that can be produced by a native camera to camera streams\n> > requested by Android HAL client w/o post processing. This is\n> > helpful for the libcamera Android HAL implementation to produce\n> > camera streams that a camera device doesn't support and output\n> > multiple streams.\n> >\n> > Hirokazu Honda (6):\n> > libcamera: camera: Add tryValidate() to CameraConfiguration\n> > libcamera: ipu3: Implement tryValidate() in IPU3CameraConfiguration\n> > android: camera_stream: Pass post processor in configure()\n> > android: camera_device: Implement toString() in Camera3StreamConfig\n> > android: camera_device: Introduce PostProcessorType\n> > android: camera_device: Support stream mapping\n> >\n> > include/libcamera/camera.h | 1 +\n> > src/android/camera_device.cpp | 266 ++++++++++++++++++++++++++-\n> > src/android/camera_stream.cpp | 31 +---\n> > src/android/camera_stream.h | 2 +-\n> > src/libcamera/camera.cpp | 22 +++\n> > src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n> > src/libcamera/pipeline/ipu3/imgu.h | 2 +-\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 160 ++++++++++++++++\n> > 8 files changed, 453 insertions(+), 33 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E5C9BD808\n\tfor ;\n\tMon, 1 Mar 2021 02:08:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C7BC6602EC;\n\tMon, 1 Mar 2021 03:08:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BF5BB602EC\n\tfor ;\n\tMon, 1 Mar 2021 03:08:37 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 05A75332;\n\tMon, 1 Mar 2021 03:08:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nagXwuK4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614564517;\n\tbh=n4BY/9ZT0qimFEi9ZSvHDnNT64ZsibAeXusA1NBHahc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nagXwuK4HYjarmyxc6ThCoV9vqh2V0AQvdVATW00ddKC3EAvwlLpreLpegA6B6XL1\n\twx/mTe5f6hBcqvtBl6Wh+6sRKeV1JRjAVBPkZHAG+LVsaeaQy2joeP+h/0RzCH4ISs\n\tOg1kZSQzGmhtlSPxXaMg3LnM2C80M+MXkjDu72cU=","Date":"Mon, 1 Mar 2021 04:08:09 +0200","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210204100541.657503-1-hiroh@chromium.org>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [RFC PATCH 0/6] Support stream mapping in\n\tAndroid HAL adaptation layer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Hanlin Chen ,\n\tlibcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]