[{"id":14944,"web_url":"https://patchwork.libcamera.org/comment/14944/","msgid":"","date":"2021-02-04T03:01:06","subject":"Re: [libcamera-devel] [PATCH v4 2/2] android: Try build with a\n\tlocal libyuv first","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn Thu, Feb 04, 2021 at 01:27:31AM +0000, Hirokazu Honda wrote:\n> There is an environment where the wrap-based download is\n> prohibited by \"--wrap-mode nodownload\". The local libyuv\n> library needs to be built with in such a build environment.\n\nI'd say \"In such cases, libyuv needs to be provided by the build\nenvironments\".\n\n> For the environment, this changes the meson file to first\n> try building a local libyuv, and if it fails, download libyuv\n\ns/For the environment/To support this/\ns/building/using/\n\n> code and build with it as a fallback.\n> \n> Signed-off-by: Hirokazu Honda \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\nCould you please let me know if you're fine with the changes to the\ncommit message ? If so there's no need to resubmit, I'll apply the\npatches with the above changes.\n\n> ---\n> src/android/meson.build | 34 ++++++++++++++++++++--------------\n> 1 file changed, 20 insertions(+), 14 deletions(-)\n> \n> diff --git a/src/android/meson.build b/src/android/meson.build\n> index 7619517a..95d0f420 100644\n> --- a/src/android/meson.build\n> +++ b/src/android/meson.build\n> @@ -15,20 +15,26 @@ foreach dep : android_deps\n> endforeach\n> \n> if android_enabled\n> - cmake = import('cmake')\n> -\n> - libyuv_vars = cmake.subproject_options()\n> - libyuv_vars.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'})\n> - libyuv_vars.set_override_option('cpp_std', 'c++17')\n> - libyuv_vars.append_compile_args('cpp',\n> - '-Wno-sign-compare',\n> - '-Wno-unused-variable',\n> - '-Wno-unused-parameter')\n> - libyuv_vars.append_link_args('-ljpeg')\n> - libyuv = cmake.subproject('libyuv', options : libyuv_vars)\n> - libyuv_dep = libyuv.dependency('yuv')\n> -\n> - android_deps += [ libyuv_dep, ]\n> + libyuv_dep = dependency('libyuv', required : false)\n> +\n> + # Fallback to a subproject if libyuv isn't found, as it's typically not\n> + # provided by distributions.\n> + if not libyuv_dep.found()\n> + cmake = import('cmake')\n> +\n> + libyuv_vars = cmake.subproject_options()\n> + libyuv_vars.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'})\n> + libyuv_vars.set_override_option('cpp_std', 'c++17')\n> + libyuv_vars.append_compile_args('cpp',\n> + '-Wno-sign-compare',\n> + '-Wno-unused-variable',\n> + '-Wno-unused-parameter')\n> + libyuv_vars.append_link_args('-ljpeg')\n> + libyuv = cmake.subproject('libyuv', options : libyuv_vars)\n> + libyuv_dep = libyuv.dependency('yuv')\n> + endif\n> +\n> + android_deps += [ libyuv_dep, ]\n> endif\n> \n> android_hal_sources = files([","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 897BABD162\n\tfor ;\n\tThu, 4 Feb 2021 03:01:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18BDA613F2;\n\tThu, 4 Feb 2021 04:01:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A305613DA\n\tfor ;\n\tThu, 4 Feb 2021 04:01:29 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 987FC5A5;\n\tThu, 4 Feb 2021 04:01:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SttX/+Ua\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612407688;\n\tbh=eSMundzV8kfd1Ws0vkITbcR3rfqaSu4JZcrqzOowSnI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SttX/+UauiVYoDoIe/JDI1ZTtduHjlOeVL51vgxyYdddQxgowAhWp0mucxPpXuYbi\n\t31ZS6gR39+zXtFT3KiKKXlGtJAXKkvTGEPgtosY/MZTZXOUNK50VPkCeaXUlGRMFbj\n\tYTf2PUcsPOnMssQ+O7ntZvGkeR31uYpveRMfZLPI=","Date":"Thu, 4 Feb 2021 05:01:06 +0200","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210204012731.1942112-1-hiroh@chromium.org>\n\t<20210204012731.1942112-3-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210204012731.1942112-3-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v4 2/2] android: Try build with a\n\tlocal libyuv first","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14945,"web_url":"https://patchwork.libcamera.org/comment/14945/","msgid":"","date":"2021-02-04T03:03:04","subject":"Re: [libcamera-devel] [PATCH v4 2/2] android: Try build with a\n\tlocal libyuv first","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"On Thu, Feb 4, 2021 at 12:01 PM Laurent Pinchart\n wrote:\n>\n> Hi Hiro,\n>\n> Thank you for the patch.\n>\n> On Thu, Feb 04, 2021 at 01:27:31AM +0000, Hirokazu Honda wrote:\n> > There is an environment where the wrap-based download is\n> > prohibited by \"--wrap-mode nodownload\". The local libyuv\n> > library needs to be built with in such a build environment.\n>\n> I'd say \"In such cases, libyuv needs to be provided by the build\n> environments\".\n>\n> > For the environment, this changes the meson file to first\n> > try building a local libyuv, and if it fails, download libyuv\n>\n> s/For the environment/To support this/\n> s/building/using/\n>\n> > code and build with it as a fallback.\n> >\n> > Signed-off-by: Hirokazu Honda \n> > Reviewed-by: Jacopo Mondi \n>\n> Reviewed-by: Laurent Pinchart \n>\n> Could you please let me know if you're fine with the changes to the\n> commit message ? If so there's no need to resubmit, I'll apply the\n> patches with the above changes.\n>\n\nThe changes look ok.\nI appreciate if you submit with applying them.\n\nThanks.\n-Hiro\n\n> > ---\n> > src/android/meson.build | 34 ++++++++++++++++++++--------------\n> > 1 file changed, 20 insertions(+), 14 deletions(-)\n> >\n> > diff --git a/src/android/meson.build b/src/android/meson.build\n> > index 7619517a..95d0f420 100644\n> > --- a/src/android/meson.build\n> > +++ b/src/android/meson.build\n> > @@ -15,20 +15,26 @@ foreach dep : android_deps\n> > endforeach\n> >\n> > if android_enabled\n> > - cmake = import('cmake')\n> > -\n> > - libyuv_vars = cmake.subproject_options()\n> > - libyuv_vars.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'})\n> > - libyuv_vars.set_override_option('cpp_std', 'c++17')\n> > - libyuv_vars.append_compile_args('cpp',\n> > - '-Wno-sign-compare',\n> > - '-Wno-unused-variable',\n> > - '-Wno-unused-parameter')\n> > - libyuv_vars.append_link_args('-ljpeg')\n> > - libyuv = cmake.subproject('libyuv', options : libyuv_vars)\n> > - libyuv_dep = libyuv.dependency('yuv')\n> > -\n> > - android_deps += [ libyuv_dep, ]\n> > + libyuv_dep = dependency('libyuv', required : false)\n> > +\n> > + # Fallback to a subproject if libyuv isn't found, as it's typically not\n> > + # provided by distributions.\n> > + if not libyuv_dep.found()\n> > + cmake = import('cmake')\n> > +\n> > + libyuv_vars = cmake.subproject_options()\n> > + libyuv_vars.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'})\n> > + libyuv_vars.set_override_option('cpp_std', 'c++17')\n> > + libyuv_vars.append_compile_args('cpp',\n> > + '-Wno-sign-compare',\n> > + '-Wno-unused-variable',\n> > + '-Wno-unused-parameter')\n> > + libyuv_vars.append_link_args('-ljpeg')\n> > + libyuv = cmake.subproject('libyuv', options : libyuv_vars)\n> > + libyuv_dep = libyuv.dependency('yuv')\n> > + endif\n> > +\n> > + android_deps += [ libyuv_dep, ]\n> > endif\n> >\n> > android_hal_sources = files([\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08078BD160\n\tfor ;\n\tThu, 4 Feb 2021 03:03:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A11B613F2;\n\tThu, 4 Feb 2021 04:03:15 +0100 (CET)","from mail-ej1-x629.google.com (mail-ej1-x629.google.com\n\t[IPv6:2a00:1450:4864:20::629])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C726613DA\n\tfor ;\n\tThu, 4 Feb 2021 04:03:14 +0100 (CET)","by mail-ej1-x629.google.com with SMTP id y9so2529728ejp.10\n\tfor ;\n\tWed, 03 Feb 2021 19:03:14 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"dugEMYj0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Xx76KJEDVbONRRzmr500HcjQoJEJMNSOHad5xHklFnE=;\n\tb=dugEMYj07Xq8IoUpLVI+oTXOLFQeEMaWHBTA8/d1kfj8V8Q0Rizx8WLN7ufBi4V0ut\n\tx9LQAAdyw2w1yJVE8nzQ5U/nh06CwLm25RP0NokemFsB//P7QaG6n6MVNU3D1ijSFagE\n\tySkYiYwDLHPBedEEQHc2jjSOIZWK17MYTNkqQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Xx76KJEDVbONRRzmr500HcjQoJEJMNSOHad5xHklFnE=;\n\tb=akc4gZE8bhBRo+hG/SXRk7ZDKPXbApaGdNIpy9NI7T00EE9NLwWWAZ3noQe/FSiIK4\n\tt3v7VOVqceoeJIFs6enm5wNaBFVKC2qsFlpwKbHSzKV6grtWlMTO4XuWY7Ns9D0YWl3U\n\t/FvlSwTKyev4jYGdeywn/cxZ9djjAZjYoHCLQLLffCezRPynFuRmHigV0k0/b+WYV6WG\n\tOnk5cPicL+JjHyxy4AhLbS51AgYwRnDv4Zwpll1tMNqXSyJ9QcR2+WT6+86y2BtU7IPy\n\tqyxgeqc+wmGBBPNHzVq5zscwDAAyr3C+fm+s6Xz3u7NLvtEBJnnXZog2oM4zOyB20/ab\n\t1+rg==","X-Gm-Message-State":"AOAM530LFzepuIpjLo7hu8i+gXHd2yRk4skvBX34w76jfcpERFU0pwJJ\n\tkGtKZOera0v4zU8JU+PaUcQTo57PXqqAT5b18deV8WGvhxszCA==","X-Google-Smtp-Source":"ABdhPJyA9tYohcftWys8Bf7IUSS6zvyhz2C9sGhBceQ7SgfQUwoOrm8iLj7znXkVERMDf3RlFCNcCAYLfiOBgexBGmM=","X-Received":"by 2002:a17:906:fa18:: with SMTP id\n\tlo24mr5957434ejb.221.1612407793988; \n\tWed, 03 Feb 2021 19:03:13 -0800 (PST)","MIME-Version":"1.0","References":"<20210204012731.1942112-1-hiroh@chromium.org>\n\t<20210204012731.1942112-3-hiroh@chromium.org>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Thu, 4 Feb 2021 12:03:04 +0900","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v4 2/2] android: Try build with a\n\tlocal libyuv first","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14946,"web_url":"https://patchwork.libcamera.org/comment/14946/","msgid":"","date":"2021-02-04T03:31:44","subject":"Re: [libcamera-devel] [PATCH v4 2/2] android: Try build with a\n\tlocal libyuv first","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nOn Thu, Feb 04, 2021 at 12:03:04PM +0900, Hirokazu Honda wrote:\n> On Thu, Feb 4, 2021 at 12:01 PM Laurent Pinchart wrote:\n> > On Thu, Feb 04, 2021 at 01:27:31AM +0000, Hirokazu Honda wrote:\n> > > There is an environment where the wrap-based download is\n> > > prohibited by \"--wrap-mode nodownload\". The local libyuv\n> > > library needs to be built with in such a build environment.\n> >\n> > I'd say \"In such cases, libyuv needs to be provided by the build\n> > environments\".\n> >\n> > > For the environment, this changes the meson file to first\n> > > try building a local libyuv, and if it fails, download libyuv\n> >\n> > s/For the environment/To support this/\n> > s/building/using/\n> >\n> > > code and build with it as a fallback.\n> > >\n> > > Signed-off-by: Hirokazu Honda \n> > > Reviewed-by: Jacopo Mondi \n> >\n> > Reviewed-by: Laurent Pinchart \n> >\n> > Could you please let me know if you're fine with the changes to the\n> > commit message ? If so there's no need to resubmit, I'll apply the\n> > patches with the above changes.\n> \n> The changes look ok.\n> I appreciate if you submit with applying them.\n\nPushed to the master branch :-) Thank you for your work.\n\n> > > ---\n> > > src/android/meson.build | 34 ++++++++++++++++++++--------------\n> > > 1 file changed, 20 insertions(+), 14 deletions(-)\n> > >\n> > > diff --git a/src/android/meson.build b/src/android/meson.build\n> > > index 7619517a..95d0f420 100644\n> > > --- a/src/android/meson.build\n> > > +++ b/src/android/meson.build\n> > > @@ -15,20 +15,26 @@ foreach dep : android_deps\n> > > endforeach\n> > >\n> > > if android_enabled\n> > > - cmake = import('cmake')\n> > > -\n> > > - libyuv_vars = cmake.subproject_options()\n> > > - libyuv_vars.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'})\n> > > - libyuv_vars.set_override_option('cpp_std', 'c++17')\n> > > - libyuv_vars.append_compile_args('cpp',\n> > > - '-Wno-sign-compare',\n> > > - '-Wno-unused-variable',\n> > > - '-Wno-unused-parameter')\n> > > - libyuv_vars.append_link_args('-ljpeg')\n> > > - libyuv = cmake.subproject('libyuv', options : libyuv_vars)\n> > > - libyuv_dep = libyuv.dependency('yuv')\n> > > -\n> > > - android_deps += [ libyuv_dep, ]\n> > > + libyuv_dep = dependency('libyuv', required : false)\n> > > +\n> > > + # Fallback to a subproject if libyuv isn't found, as it's typically not\n> > > + # provided by distributions.\n> > > + if not libyuv_dep.found()\n> > > + cmake = import('cmake')\n> > > +\n> > > + libyuv_vars = cmake.subproject_options()\n> > > + libyuv_vars.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'})\n> > > + libyuv_vars.set_override_option('cpp_std', 'c++17')\n> > > + libyuv_vars.append_compile_args('cpp',\n> > > + '-Wno-sign-compare',\n> > > + '-Wno-unused-variable',\n> > > + '-Wno-unused-parameter')\n> > > + libyuv_vars.append_link_args('-ljpeg')\n> > > + libyuv = cmake.subproject('libyuv', options : libyuv_vars)\n> > > + libyuv_dep = libyuv.dependency('yuv')\n> > > + endif\n> > > +\n> > > + android_deps += [ libyuv_dep, ]\n> > > endif\n> > >\n> > > android_hal_sources = files([","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83789BD160\n\tfor ;\n\tThu, 4 Feb 2021 03:32:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0DA7F613F6;\n\tThu, 4 Feb 2021 04:32:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 81020613DA\n\tfor ;\n\tThu, 4 Feb 2021 04:32:06 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E7EAB5A5;\n\tThu, 4 Feb 2021 04:32:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pHVgFQ4F\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612409526;\n\tbh=EAaGX0Rf/4twg1Bj7tq9d48QGgqFTt2kNT6Os1+ZYbM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pHVgFQ4FAW/b09tnmbVo6yC0earLUc1uLN1qkZ0ZafTM3ftcMyqnA7A8gJ98aPKn2\n\t+ZK802WT3vm7wqE/CqnjlGiWhKWdtxdaBKKUVuzJDn99C7oCQldJvUtEsxzVvJrju8\n\tO/gdgKSpJtMSu8oGyeuK7PJlkhrKQ7CWvpEzo2wE=","Date":"Thu, 4 Feb 2021 05:31:44 +0200","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210204012731.1942112-1-hiroh@chromium.org>\n\t<20210204012731.1942112-3-hiroh@chromium.org>\n\t\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v4 2/2] android: Try build with a\n\tlocal libyuv first","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]