[{"id":14936,"web_url":"https://patchwork.libcamera.org/comment/14936/","msgid":"","date":"2021-02-03T22:45:57","subject":"Re: [libcamera-devel] [PATCH v3 0/2] Add libyuv to subprojects and\n\tdownload_subprojects option","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nOn Wed, Feb 03, 2021 at 06:51:26AM +0000, Hirokazu Honda wrote:\n> The first patch adds libyuv to subprojects. It downloads the\n> libyuv directory to the subprojects directory and the code is\n> built with. When I tried building libcamera with the patch in\n> ChromiumOS built development, I noticed the wrap-based\n> download is prohibited. It is reasonable to avoid a network\n> issue. For such an environment, the meson option,\n> download_subprojects, is introduced in the second patch. If\n> it is false, the local library is used for the build.\n> Fortunately, ChromiumOS has the ebuild for libyuv library.\n\nVery good point.\n\nI've reviewed 2/2 and proposed an alternative implementation that\ndoesn't require a new project option. I would merge 1/2 already, but as\nit would break the ebuild, I'd prefer merging the whole series in one\ngo.\n\nIf the solution I've proposed works fine for you, you can submit a v4 of\nthe whole series or only of 2/2, and I'll merge both patches.\n\n> Hirokazu Honda (2):\n> subprojects: Add libyuv and built if -Dandroid=enabled\n> meson: Add download_subprojects option\n> \n> README.rst | 2 +-\n> meson.build | 2 +-\n> meson_options.txt | 5 +++++\n> src/android/meson.build | 21 +++++++++++++++++++++\n> subprojects/.gitignore | 1 +\n> subprojects/libyuv.wrap | 4 ++++\n> 6 files changed, 33 insertions(+), 2 deletions(-)\n> create mode 100644 subprojects/.gitignore\n> create mode 100644 subprojects/libyuv.wrap","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0458DBD161\n\tfor ;\n\tWed, 3 Feb 2021 22:46:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C5F1613DE;\n\tWed, 3 Feb 2021 23:46:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A27E2613D4\n\tfor ;\n\tWed, 3 Feb 2021 23:46:19 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 156B0240;\n\tWed, 3 Feb 2021 23:46:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y6zOo/ud\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612392379;\n\tbh=squMdB5OBtvb0Geo32I46k6KamCM9PxKITtDme5XAbc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Y6zOo/udJxHzM2ol1R04IcgYDWMqwzi82EeVLNTWWSnO1BMDuBpXsDVDlUyN+UQwZ\n\tymw8LF+zrtO3Yh31DmSrX89l4QGtHf8yAbTfltxpzTa3MuZq9MjdhwmQ130n6JR5LO\n\ttC85TSctb3vfTXe9w+CLW8Dj+QwsSiyVpFsgYxJs=","Date":"Thu, 4 Feb 2021 00:45:57 +0200","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210203065128.1738003-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210203065128.1738003-1-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v3 0/2] Add libyuv to subprojects and\n\tdownload_subprojects option","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]