[{"id":14875,"web_url":"https://patchwork.libcamera.org/comment/14875/","msgid":"<20210201103350.zw46gltnhjmqhhfa@uno.localdomain>","date":"2021-02-01T10:33:50","subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Add support for\n\tRGB565X format","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sun, Jan 31, 2021 at 08:43:50PM +0200, Laurent Pinchart wrote:\n> Hello,\n>\n> The V4L2 RGB565X format maps to DRM to the big-endian version of\n> DRM_FORMAT_RGB565. libcamera doesn't support big-endian DRM formats yet,\n> so patch 1/2 addresses this issue in the gen-formats.py script. Patch\n> 2/2 then adds support for the format.\n>\n> Laurent Pinchart (2):\n>   utils: gen-formats: Support big-endian DRM formats\n>   libcamera: formats: Add RGB565_BE format\n\nBoth patches look good!\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n  j\n\n>\n>  src/libcamera/formats.cpp          | 10 ++++++++++\n>  src/libcamera/formats.yaml         |  3 +++\n>  src/libcamera/v4l2_pixelformat.cpp |  1 +\n>  utils/gen-formats.py               |  5 ++++-\n>  4 files changed, 18 insertions(+), 1 deletion(-)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F834BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  1 Feb 2021 10:33:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5BB4683FC;\n\tMon,  1 Feb 2021 11:33:30 +0100 (CET)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 339C660307\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  1 Feb 2021 11:33:29 +0100 (CET)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 9E5EF20003;\n\tMon,  1 Feb 2021 10:33:28 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","Date":"Mon, 1 Feb 2021 11:33:50 +0100","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20210201103350.zw46gltnhjmqhhfa@uno.localdomain>","References":"<20210131184352.10635-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210131184352.10635-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Add support for\n\tRGB565X format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]