[{"id":14960,"web_url":"https://patchwork.libcamera.org/comment/14960/","msgid":"","date":"2021-02-04T11:32:49","subject":"Re: [libcamera-devel] [PATCH v5 0/6] Raspberry Pi: Colour denoise","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nGentle nudge for some feedback on this please?\n\nThanks,\nNaush\n\n\nOn Fri, 29 Jan 2021 at 15:11, Naushir Patuck wrote:\n\n> Hi,\n>\n> Version 5 of this patch series addresses all the review comments in v4:\n> - Switch DenoiseMode to an enum class.\n> - Avoid double lookup in the DenoiseMode conversion table.\n> - Add controls::draft::NoiseReductionMode to the available controls\n> handled by the IPA.\n>\n> Regards,\n> Naush\n>\n>\n> Naushir Patuck (6):\n> pipeline: raspberrypi: Refactor stream configuration routine\n> pipeline: raspberrypi: Set the ISP Output1 to 1/4 resolution if unused\n> uapi: raspberrypi: Update the bcm2835-isp header definition\n> ipa: raspberrypi: Rename SdnStatus to DenoiseStatus\n> ipa: raspberrypi: Add a DenoiseAlgorithm class to the Controller\n> ipa: raspberrypi: Handle control::NoiseReductionMode in the controller\n>\n> include/libcamera/ipa/raspberrypi.h | 1 +\n> include/linux/bcm2835-isp.h | 32 ++++++-\n> .../controller/denoise_algorithm.hpp | 23 +++++\n> .../{sdn_status.h => denoise_status.h} | 7 +-\n> src/ipa/raspberrypi/controller/rpi/sdn.cpp | 17 ++--\n> src/ipa/raspberrypi/controller/rpi/sdn.hpp | 5 +-\n> src/ipa/raspberrypi/raspberrypi.cpp | 59 +++++++++++--\n> .../pipeline/raspberrypi/raspberrypi.cpp | 86 ++++++++++---------\n> 8 files changed, 174 insertions(+), 56 deletions(-)\n> create mode 100644 src/ipa/raspberrypi/controller/denoise_algorithm.hpp\n> rename src/ipa/raspberrypi/controller/{sdn_status.h => denoise_status.h}\n> (62%)\n>\n> --\n> 2.25.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C738EBD160\n\tfor ;\n\tThu, 4 Feb 2021 11:33:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 33FE36141D;\n\tThu, 4 Feb 2021 12:33:08 +0100 (CET)","from mail-lj1-x234.google.com (mail-lj1-x234.google.com\n\t[IPv6:2a00:1450:4864:20::234])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A153360305\n\tfor ;\n\tThu, 4 Feb 2021 12:33:06 +0100 (CET)","by mail-lj1-x234.google.com with SMTP id l12so2998206ljc.3\n\tfor ;\n\tThu, 04 Feb 2021 03:33:06 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"U6BTlrto\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=CA2T3yKeGcf/s8zLe3bSXoeXw+xkTOin8gVvBrNMjXY=;\n\tb=U6BTlrtoFejNcei1TZLJSKq+dIiJ7kuRWk204oiQipRlr3sJFEMIvokRuxAjs1oUuX\n\tLRM5QJys5wozGt1ZaBg/pHZEblAVp0hCZ3ASmJuTW9cMAwXVNBquBt06KbtKXU+3cty8\n\tkdOal2zLng2iZnjhm1oabTXyh+TdnLcvLma01GbUzbvpgC+yEIj9Rf1HqC3Ax8z6C8W8\n\ta23ft9xGe0MzOJoh3c5j8PBcZklYIaKxSU56cxeY8DteECcczz/8ZFaz7v0DexIMra2Q\n\tuATsidDQWWkiKDFz/YGC00obKdZzJm9SE13U/mtqPuYSD4QVICZ/HIWo4Jn2WDs8feop\n\tO98w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=CA2T3yKeGcf/s8zLe3bSXoeXw+xkTOin8gVvBrNMjXY=;\n\tb=ihSqRl7RwhoBlr8v7qXukdd5AWEFX5btbIDMrcaNiO+mwcwHFgS/3GBqRkROWE56Wt\n\twR2uzwk+X5Zabo8C7qXkYItZU0acKkqj2QqhVLw/+4Vk7dpyqBPP1hcM/1P6C25xpdR2\n\tRIlNt6IFG4GpB/AB4rdpVy4C/e6hnWhnpEXE6xUAAmgR8vUgsRodglkYl+oe8HujQIUe\n\tXW6B9yCu/vRM8gHNFhCbeNIB4e9Vv7Ad+jvXA06xEChjw89zLJdOQx3q4Z/kqMfL0KxZ\n\tmB5SVNibRa1yytUE0Q3kquC8hR5KjzqN6hn8vkPRBR/N02aBB0LwXS3KVX/Em6yFfH3D\n\tKJWw==","X-Gm-Message-State":"AOAM531z9EpdT42CvgdN5UR9BAhodfVgMdPw8VXN54c7i+BM2ZcG6kkq\n\t/QGT0UrKJlA2StAdF2vAkz69qMEpn9AxM/HdTFVvqNHFvP2Nkg==","X-Google-Smtp-Source":"ABdhPJzUu1JU6fK0vpFDCZhv+qm2zapmRpAQ4rXTCouU2L+uO1CchHHGKJsznIIuu+cqyRV3/P4/WLFSAoJET+0nirc=","X-Received":"by 2002:a05:651c:2108:: with SMTP id\n\ta8mr4469761ljq.329.1612438385881; \n\tThu, 04 Feb 2021 03:33:05 -0800 (PST)","MIME-Version":"1.0","References":"<20210129151154.1051163-1-naush@raspberrypi.com>","In-Reply-To":"<20210129151154.1051163-1-naush@raspberrypi.com>","From":"Naushir Patuck ","Date":"Thu, 4 Feb 2021 11:32:49 +0000","Message-ID":"","To":"libcamera devel ","Subject":"Re: [libcamera-devel] [PATCH v5 0/6] Raspberry Pi: Colour denoise","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============1233573921008695725==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14997,"web_url":"https://patchwork.libcamera.org/comment/14997/","msgid":"","date":"2021-02-04T21:49:12","subject":"Re: [libcamera-devel] [PATCH v5 0/6] Raspberry Pi: Colour denoise","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Fri, Jan 29, 2021 at 03:11:48PM +0000, Naushir Patuck wrote:\n> Hi,\n> \n> Version 5 of this patch series addresses all the review comments in v4:\n> - Switch DenoiseMode to an enum class.\n> - Avoid double lookup in the DenoiseMode conversion table.\n> - Add controls::draft::NoiseReductionMode to the available controls handled by the IPA.\n\nI've reviewed the whole series and only have minor comments. I've\noffered to fix the small issues when applying (if you agree with the\ncomments of course) in the first few patches, but as there are a few\nadditional questions later, it may be easier if you could send a v6.\nOther patches to the RPi IPA have also been merged in the meantime,\ngenerating a few minor conflicts, and I'd prefer if you could resolve\nthem and test the result.\n\n> Naushir Patuck (6):\n> pipeline: raspberrypi: Refactor stream configuration routine\n> pipeline: raspberrypi: Set the ISP Output1 to 1/4 resolution if unused\n> uapi: raspberrypi: Update the bcm2835-isp header definition\n> ipa: raspberrypi: Rename SdnStatus to DenoiseStatus\n> ipa: raspberrypi: Add a DenoiseAlgorithm class to the Controller\n> ipa: raspberrypi: Handle control::NoiseReductionMode in the controller\n> \n> include/libcamera/ipa/raspberrypi.h | 1 +\n> include/linux/bcm2835-isp.h | 32 ++++++-\n> .../controller/denoise_algorithm.hpp | 23 +++++\n> .../{sdn_status.h => denoise_status.h} | 7 +-\n> src/ipa/raspberrypi/controller/rpi/sdn.cpp | 17 ++--\n> src/ipa/raspberrypi/controller/rpi/sdn.hpp | 5 +-\n> src/ipa/raspberrypi/raspberrypi.cpp | 59 +++++++++++--\n> .../pipeline/raspberrypi/raspberrypi.cpp | 86 ++++++++++---------\n> 8 files changed, 174 insertions(+), 56 deletions(-)\n> create mode 100644 src/ipa/raspberrypi/controller/denoise_algorithm.hpp\n> rename src/ipa/raspberrypi/controller/{sdn_status.h => denoise_status.h} (62%)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 357E8BD160\n\tfor ;\n\tThu, 4 Feb 2021 21:49:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9869361473;\n\tThu, 4 Feb 2021 22:49:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB6C961430\n\tfor ;\n\tThu, 4 Feb 2021 22:49:34 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6CAB745D;\n\tThu, 4 Feb 2021 22:49:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tnlUFEKI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612475374;\n\tbh=BxBhwUnAnml5VJbviTU+knak+lyKL3JEtcRNndgq6fs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tnlUFEKIYakedMcX/5DIsndc6yzGIihfN0e3MKZ6i7uy/0oFM4WBbqcROfS1EdwH2\n\t+Njg9ZQX8TOC4DtNAyxVXGqqFjq/oc6OrQxGvja2pU2O5cthacOgSD9xuX/JqvcoV8\n\tbH5D1uYKLFIiDS8kNKkmDxqawpOUFSD6dUkHquw0=","Date":"Thu, 4 Feb 2021 23:49:12 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20210129151154.1051163-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210129151154.1051163-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v5 0/6] Raspberry Pi: Colour denoise","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15030,"web_url":"https://patchwork.libcamera.org/comment/15030/","msgid":"","date":"2021-02-05T13:56:45","subject":"Re: [libcamera-devel] [PATCH v5 0/6] Raspberry Pi: Colour denoise","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nOn Thu, 4 Feb 2021 at 21:49, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Naush,\n>\n> On Fri, Jan 29, 2021 at 03:11:48PM +0000, Naushir Patuck wrote:\n> > Hi,\n> >\n> > Version 5 of this patch series addresses all the review comments in v4:\n> > - Switch DenoiseMode to an enum class.\n> > - Avoid double lookup in the DenoiseMode conversion table.\n> > - Add controls::draft::NoiseReductionMode to the available controls\n> handled by the IPA.\n>\n> I've reviewed the whole series and only have minor comments. I've\n> offered to fix the small issues when applying (if you agree with the\n> comments of course) in the first few patches, but as there are a few\n> additional questions later, it may be easier if you could send a v6.\n> Other patches to the RPi IPA have also been merged in the meantime,\n> generating a few minor conflicts, and I'd prefer if you could resolve\n> them and test the result.\n>\n\nThanks for all the reviews. I have incorporated all the suggested changes,\nand done a rebase. I will post a new version 6 of the series after a bit\nmore testing.\n\nRegards,\nNaush\n\n\n\n>\n> > Naushir Patuck (6):\n> > pipeline: raspberrypi: Refactor stream configuration routine\n> > pipeline: raspberrypi: Set the ISP Output1 to 1/4 resolution if unused\n> > uapi: raspberrypi: Update the bcm2835-isp header definition\n> > ipa: raspberrypi: Rename SdnStatus to DenoiseStatus\n> > ipa: raspberrypi: Add a DenoiseAlgorithm class to the Controller\n> > ipa: raspberrypi: Handle control::NoiseReductionMode in the controller\n> >\n> > include/libcamera/ipa/raspberrypi.h | 1 +\n> > include/linux/bcm2835-isp.h | 32 ++++++-\n> > .../controller/denoise_algorithm.hpp | 23 +++++\n> > .../{sdn_status.h => denoise_status.h} | 7 +-\n> > src/ipa/raspberrypi/controller/rpi/sdn.cpp | 17 ++--\n> > src/ipa/raspberrypi/controller/rpi/sdn.hpp | 5 +-\n> > src/ipa/raspberrypi/raspberrypi.cpp | 59 +++++++++++--\n> > .../pipeline/raspberrypi/raspberrypi.cpp | 86 ++++++++++---------\n> > 8 files changed, 174 insertions(+), 56 deletions(-)\n> > create mode 100644 src/ipa/raspberrypi/controller/denoise_algorithm.hpp\n> > rename src/ipa/raspberrypi/controller/{sdn_status.h =>\n> denoise_status.h} (62%)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3E819BD160\n\tfor ;\n\tFri, 5 Feb 2021 13:57:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AFE6F614BC;\n\tFri, 5 Feb 2021 14:57:02 +0100 (CET)","from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com\n\t[IPv6:2a00:1450:4864:20::12c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 06517614B0\n\tfor ;\n\tFri, 5 Feb 2021 14:57:02 +0100 (CET)","by mail-lf1-x12c.google.com with SMTP id f1so10019712lfu.3\n\tfor ;\n\tFri, 05 Feb 2021 05:57:01 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"o8n3UffO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=0D1GRyus5mJgO6GaveDnEcqVkUTQKsTfWGJqyGN2Yi4=;\n\tb=o8n3UffOqULyhRm1gYsT9jhj0ZKPzFkmTM5swr5G9GAK10yW2LePMQwQlUVOW1m4Wv\n\tn5gjaWT/c+SZtmrOI8do4VYAOzYHFJQUTRn6QuIOnlKhQiPI3Fa4LO7X7YOUFWE8mucB\n\txFDnl9l+VRFJ5aYh5W5U8J+bi18phayrX/gdaI0711i7qdHFFWnoY4izvF+LzJLLJemi\n\ts8op+I9w8Obfv18uzb3iHr1T0qGd9o/EFdNitwS66l52aRBZgQ5akle4XI94LpGiqVQ2\n\tlcGCXZqZgqvYzS/NI/uroad/a8TU1qnt1igE+41GzuVxfePwUeATiYkKPPRMb24+STXE\n\tmzjQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=0D1GRyus5mJgO6GaveDnEcqVkUTQKsTfWGJqyGN2Yi4=;\n\tb=X7yaFWTWO4ifd18Xkg2EzH6vfc9GLj0E8eSDnjkWEf5gBg/pB5hryokpYH7Pst8IzX\n\tvMhksF4vpaNDtZ1ANSzNX3zzD32a5SK3mAZA0mSu1+AZr4NdkGkK6VlPlikY6LG8KF/g\n\t01g6qWOzMDYFvuml8ny7ffUhPE+FAAcbsp1aDu6tR4DYgjyUutan1EMf+nMUDbWD5dys\n\tuKV1T8gXdNlLxgdcbC8IPjuozMAjRr3qbl5V+9t6lFQt+/Jp8TprIEQEtRiN+yDiCTFv\n\tkAiCIkqzL/lJq1GyhOcqyn2l/kQ7AQ0vLrm5vYZ/n/AFoNWHFP5zsn3lgwn+IkJ7PzxC\n\t98GA==","X-Gm-Message-State":"AOAM531iLLLdNQNwEVANcKquL8m+Vyqp4ZNzhCZPhWQ7TZDhutzYOcUE\n\tGXgMCYHLZZk6t3i69EDJAWXzdj1DfDQ/neet3dncBw==","X-Google-Smtp-Source":"ABdhPJw62y4IfcjRbu7j5turUdWFaUAr3Xr4U66YYszL/EBffHm2jyH+xk2DOShyNXqGn2yQEHN4tc4l4bX1gFA4HQw=","X-Received":"by 2002:ac2:5f5b:: with SMTP id 27mr2580948lfz.375.1612533421501;\n\tFri, 05 Feb 2021 05:57:01 -0800 (PST)","MIME-Version":"1.0","References":"<20210129151154.1051163-1-naush@raspberrypi.com>\n\t","In-Reply-To":"","From":"Naushir Patuck ","Date":"Fri, 5 Feb 2021 13:56:45 +0000","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v5 0/6] Raspberry Pi: Colour denoise","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============8129293817554864191==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]