[{"id":1509,"web_url":"https://patchwork.libcamera.org/comment/1509/","msgid":"<20190426160553.GE16573@bigcity.dyn.berto.se>","date":"2019-04-26T16:05:53","subject":"Re: [libcamera-devel] [PATCH 0/8] Fix clang compilation warnings\n\tand errors","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-04-26 18:01:47 +0300, Laurent Pinchart wrote:\n> Hello,\n> \n> This patch series fixes miscellaneous issues flagged by compiling\n> libcamera with clang. There isn't much to be said, I believe all issues\n> to be valid, please see individual patches for the fixes.\n\nNice finding these errors, for the whole series\n\nReviewed-by: Niklas Söderlund \n\n> \n> Laurent Pinchart (8):\n> libcamera: Correct struct forward declarations\n> libcamera: event_dispatcher_poll: Fix bitwise test\n> libcamera: log: Add a LogInvalid entry to LogSeverity\n> libcamera: Mark overridden functions with override\n> libcamera: v4l2_device: Buffer is not a struct\n> test: v4l2_subdevice: Remove std::move() that prevents copy elision\n> cam: options: Don't initialise variable-length arrays\n> cam: options: Fix string concatenation\n> \n> include/libcamera/camera.h | 3 ++-\n> src/cam/options.cpp | 9 ++++++---\n> src/libcamera/event_dispatcher_poll.cpp | 2 +-\n> src/libcamera/include/camera_sensor.h | 3 ++-\n> src/libcamera/include/log.h | 3 ++-\n> src/libcamera/include/pipeline_handler.h | 1 -\n> src/libcamera/log.cpp | 14 +++++++-------\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> src/libcamera/pipeline/uvcvideo.cpp | 2 +-\n> src/libcamera/pipeline/vimc.cpp | 2 +-\n> src/libcamera/v4l2_device.cpp | 2 +-\n> test/v4l2_subdevice/v4l2_subdevice_test.cpp | 2 +-\n> 12 files changed, 25 insertions(+), 20 deletions(-)\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B287760E9A\n\tfor ;\n\tFri, 26 Apr 2019 18:05:55 +0200 (CEST)","by mail-lf1-x141.google.com with SMTP id i68so2734235lfi.10\n\tfor ;\n\tFri, 26 Apr 2019 09:05:55 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tz16sm6681608lfi.9.2019.04.26.09.05.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 26 Apr 2019 09:05:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=/5iELmLx7CndS9+s8BRr5iKKTAglcAr+v/XvJhtSFMg=;\n\tb=kugv5+fenWuEosV9wq+h/9HyHjqbuRyU1/G+LBQfZ/2ggb8fieNG5JVT9hQJhVuxHp\n\tE11bvcb1hAR3Jx79s4MIcY0XCPV8W/hj0dmP3yoAlW6iFOh+dT6gaJ4DJxOy1TApykyx\n\tg9H0UoigqNLyX/hkk8htPmRUv3Rt6BoNza0P4AT3Fq7DRXF26tyFfutz/ksozWFVkTnc\n\tkRP0Y12nyGO49uHgdEOY7xaNn2+HEEqgOn0w3vrFdr2wNZkHPdy+Yq7Oi+U8jM8Tn9bb\n\tgcNpuV1dk3O+JG5XGVSMDs4J9WlKEAAWEXHuhywBVwjvjWH8MGffH5KB/pHSQkdiYMjF\n\t/65g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=/5iELmLx7CndS9+s8BRr5iKKTAglcAr+v/XvJhtSFMg=;\n\tb=t98y501C7F4lj4LQ9hAzKZbfz0DjyVToumBSO46pBL3lhlqz8o7acRpHbGXnUMLP+4\n\ttSNecGAPda/K8yEqmu3GnKiehlW3Rjdb6hUOhuxXZjHojM6/UCLUphqyO94RoTFdEK8f\n\tAzEojBwnfsaeFCQ/rH8XZa0EkbZL/6fepfQWbCjb2gAPKuxuAOozAousl4kRCuzZEc8w\n\tnrU58Euyrw+P2zeWqB2o+uAyUs5mPbJeBUAOwNPFjSvYwJ6To4qO7kjUfC2H85oXIUsn\n\tsPfBGw4RlTP70W5HpWrn1ARvNKUo4Y+ujmnOG7wzVGf0IAcO2bEYSB2j0cWRCQc2VCiL\n\tI9lA==","X-Gm-Message-State":"APjAAAX7M5X6zcJhHDkC/8ty/aTs8LdHXMZJmDreCd8Ec3yCnPOMu3nj\n\tjLmvH6uhMOzBkq8xEc1FeOBB5A==","X-Google-Smtp-Source":"APXvYqwX/Z7LpebM5W3qO03h4dmrXWL82H1f6U52aZZg3VIUCKeFGWdZjj6boHP43LF3ocL7d5Q33g==","X-Received":"by 2002:a19:2814:: with SMTP id\n\to20mr24683394lfo.117.1556294754809; \n\tFri, 26 Apr 2019 09:05:54 -0700 (PDT)","Date":"Fri, 26 Apr 2019 18:05:53 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190426160553.GE16573@bigcity.dyn.berto.se>","References":"<20190426150155.18652-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190426150155.18652-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH 0/8] Fix clang compilation warnings\n\tand errors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 26 Apr 2019 16:05:56 -0000"}}]