[{"id":14864,"web_url":"https://patchwork.libcamera.org/comment/14864/","msgid":"","date":"2021-01-30T09:17:48","subject":"Re: [libcamera-devel] [PATCH v4 0/5] Raspberry Pi: FrameDurations\n\tcontrol refinements","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nOn Fri, 29 Jan 2021 at 11:16, Naushir Patuck wrote:\n\n> Hi,\n>\n> Here is the next revision of the patch series. The only difference\n> between this\n> and v3 is a change to the comment text as suggested by Laurent in patch\n> 2/5.\n>\n>\nWith the recent merge of DelayedCtrls, patch 5/5 in this series is now\nredundant. All other patches still remain unchanged and can be merged\nwithout patch 5/5 for this work.\n\nAs discussed with Niklas, I will work to port the changes from patch 5/5\ninto DelayedCtrls at some point in the near future.\n\nRegards,\nNaush\n\n\n> Jacopo Mondi (1):\n> libcamera: camera_sensor: Make VBLANK mandatory\n>\n> Naushir Patuck (4):\n> libcamera: camera_sensor: Add frame length limits to CameraSensorInfo\n> ipa: raspberrypi: Limit the calculated vblank based on the sensor mode\n> ipa: raspberrypi: Pass the maximum allowable shutter speed into the\n> AGC\n> pipeline: raspberrypi: Add notion of priority write to StaggeredCtrl\n>\n> Documentation/sensor_driver_requirements.rst | 6 +-\n> include/libcamera/internal/camera_sensor.h | 3 +\n> src/ipa/raspberrypi/cam_helper.cpp | 16 ++---\n> src/ipa/raspberrypi/cam_helper.hpp | 5 +-\n> src/ipa/raspberrypi/cam_helper_imx219.cpp | 6 +-\n> src/ipa/raspberrypi/cam_helper_imx477.cpp | 4 +-\n> src/ipa/raspberrypi/cam_helper_ov5647.cpp | 4 +-\n> .../raspberrypi/controller/agc_algorithm.hpp | 1 +\n> src/ipa/raspberrypi/controller/camera_mode.h | 2 +\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 48 +++++++++-----\n> src/ipa/raspberrypi/controller/rpi/agc.hpp | 3 +\n> src/ipa/raspberrypi/raspberrypi.cpp | 66 ++++++++++++++-----\n> src/libcamera/camera_sensor.cpp | 44 +++++++++++--\n> .../pipeline/raspberrypi/raspberrypi.cpp | 12 +++-\n> .../pipeline/raspberrypi/staggered_ctrl.cpp | 41 ++++++++----\n> .../pipeline/raspberrypi/staggered_ctrl.h | 17 ++++-\n> test/ipa/ipa_wrappers_test.cpp | 2 +\n> 17 files changed, 199 insertions(+), 81 deletions(-)\n>\n> --\n> 2.25.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 502F8C33BB\n\tfor ;\n\tSat, 30 Jan 2021 09:18:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA447683CE;\n\tSat, 30 Jan 2021 10:18:06 +0100 (CET)","from mail-lj1-x235.google.com (mail-lj1-x235.google.com\n\t[IPv6:2a00:1450:4864:20::235])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F89860309\n\tfor ;\n\tSat, 30 Jan 2021 10:18:05 +0100 (CET)","by mail-lj1-x235.google.com with SMTP id c18so13307392ljd.9\n\tfor ;\n\tSat, 30 Jan 2021 01:18:05 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"G3Bk6/il\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=4D65A0ko2weprfvnSaRPqY2/DUFT1rr0q+bh8qWCE/w=;\n\tb=G3Bk6/ilhegj/Y+F+qkxJJUw/a6Olj8dLytkz3CsIAJyMiX1S3OEHnP39AxURKBKRL\n\t924COpg2H4J8PBAgw0W1YJf5e94fvZrICaPdZSsa2PQXfkanxwl3ymnfPCd+Ha3QrqAb\n\t48yn/TDv65DD4deGrJV3tqZmVcw6LZZ7FErqlUXx+CRx8+dco2+1ttSLbmADH00KKW5m\n\tHe3jsCCVqcir1Dh86jo9vVDf3BP2g17iV8ZoxBgb8Suva8+6HDxXmUeKF86yvG2Q24Oh\n\t+0PIzMOF2qvA5U1hWjpudOm3dIFwN+qY+Vey2uGcHysttXGyOLiqNTElhzDLOca54fKa\n\tuHrw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=4D65A0ko2weprfvnSaRPqY2/DUFT1rr0q+bh8qWCE/w=;\n\tb=Z7VuALH3HojfpkdUM0H1pOoLnWiYEhiFLbwTnyT0bg/8yzbg5/E9Zxpss4YjUOYKkF\n\tqTjSsLJf8VBBJH4aTPqIMNhxpmCIWCH9/SPN7xrqqhcToPPdz3QuuL/1tHjTOTp+whT0\n\tCNBlSkijqRLM4AIu37xE27YXpAmiDLGKD6uUe27zRirD9Kpm61Mzuu1zMSMKDjCO7voq\n\thPt3NXKeI3ltObEwpkHXy9RD+GzDgCJAnG2OFA2e8ePafLw+eOZK5e0eckUbZVVuYwpl\n\tdPrGmuv3jPkvCUwPAnfJF6VvM308wcUOt3v5hVudRgqo+EnFMglZw6tpr5a8EBE5c3F8\n\tH3mQ==","X-Gm-Message-State":"AOAM530LBTNZHI+NadLM293TpS8rui2ubxAUtb4CpMubWsbzyMvXttkt\n\tmD4VnuhG9z7pMdDazQTZ6cy4zC1DXVbOxKI9LbeXgg6U40oAZA==","X-Google-Smtp-Source":"ABdhPJz8dgyPz5pJxb1EUne+nh0m/2dqqu3p/rZGzWwaVLWwcSqY4RlGEL8AMlDfvtXP9OS/iFOMqilPhjjTge8oi7U=","X-Received":"by 2002:a2e:8116:: with SMTP id d22mr4460712ljg.48.1611998284622;\n\tSat, 30 Jan 2021 01:18:04 -0800 (PST)","MIME-Version":"1.0","References":"<20210129111616.1047483-1-naush@raspberrypi.com>","In-Reply-To":"<20210129111616.1047483-1-naush@raspberrypi.com>","From":"Naushir Patuck ","Date":"Sat, 30 Jan 2021 09:17:48 +0000","Message-ID":"","To":"libcamera devel ","Subject":"Re: [libcamera-devel] [PATCH v4 0/5] Raspberry Pi: FrameDurations\n\tcontrol refinements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============1770143448686533356==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14961,"web_url":"https://patchwork.libcamera.org/comment/14961/","msgid":"","date":"2021-02-04T11:33:19","subject":"Re: [libcamera-devel] [PATCH v4 0/5] Raspberry Pi: FrameDurations\n\tcontrol refinements","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nAnother gentle nudge :)\n\nThanks,\nNaush\n\nOn Sat, 30 Jan 2021 at 09:17, Naushir Patuck wrote:\n\n> Hi all,\n>\n> On Fri, 29 Jan 2021 at 11:16, Naushir Patuck \n> wrote:\n>\n>> Hi,\n>>\n>> Here is the next revision of the patch series. The only difference\n>> between this\n>> and v3 is a change to the comment text as suggested by Laurent in patch\n>> 2/5.\n>>\n>>\n> With the recent merge of DelayedCtrls, patch 5/5 in this series is now\n> redundant. All other patches still remain unchanged and can be merged\n> without patch 5/5 for this work.\n>\n> As discussed with Niklas, I will work to port the changes from patch 5/5\n> into DelayedCtrls at some point in the near future.\n>\n> Regards,\n> Naush\n>\n>\n>> Jacopo Mondi (1):\n>> libcamera: camera_sensor: Make VBLANK mandatory\n>>\n>> Naushir Patuck (4):\n>> libcamera: camera_sensor: Add frame length limits to CameraSensorInfo\n>> ipa: raspberrypi: Limit the calculated vblank based on the sensor mode\n>> ipa: raspberrypi: Pass the maximum allowable shutter speed into the\n>> AGC\n>> pipeline: raspberrypi: Add notion of priority write to StaggeredCtrl\n>>\n>> Documentation/sensor_driver_requirements.rst | 6 +-\n>> include/libcamera/internal/camera_sensor.h | 3 +\n>> src/ipa/raspberrypi/cam_helper.cpp | 16 ++---\n>> src/ipa/raspberrypi/cam_helper.hpp | 5 +-\n>> src/ipa/raspberrypi/cam_helper_imx219.cpp | 6 +-\n>> src/ipa/raspberrypi/cam_helper_imx477.cpp | 4 +-\n>> src/ipa/raspberrypi/cam_helper_ov5647.cpp | 4 +-\n>> .../raspberrypi/controller/agc_algorithm.hpp | 1 +\n>> src/ipa/raspberrypi/controller/camera_mode.h | 2 +\n>> src/ipa/raspberrypi/controller/rpi/agc.cpp | 48 +++++++++-----\n>> src/ipa/raspberrypi/controller/rpi/agc.hpp | 3 +\n>> src/ipa/raspberrypi/raspberrypi.cpp | 66 ++++++++++++++-----\n>> src/libcamera/camera_sensor.cpp | 44 +++++++++++--\n>> .../pipeline/raspberrypi/raspberrypi.cpp | 12 +++-\n>> .../pipeline/raspberrypi/staggered_ctrl.cpp | 41 ++++++++----\n>> .../pipeline/raspberrypi/staggered_ctrl.h | 17 ++++-\n>> test/ipa/ipa_wrappers_test.cpp | 2 +\n>> 17 files changed, 199 insertions(+), 81 deletions(-)\n>>\n>> --\n>> 2.25.1\n>>\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DF5DCBD160\n\tfor ;\n\tThu, 4 Feb 2021 11:33:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE8C261403;\n\tThu, 4 Feb 2021 12:33:37 +0100 (CET)","from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com\n\t[IPv6:2a00:1450:4864:20::22d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACB2661403\n\tfor ;\n\tThu, 4 Feb 2021 12:33:35 +0100 (CET)","by mail-lj1-x22d.google.com with SMTP id m22so2992142ljj.4\n\tfor ;\n\tThu, 04 Feb 2021 03:33:35 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"QT0yM4bp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=yGHINrQ4IpUSRYjxWPnntDTBMlhSADbt7+/syiSNhIE=;\n\tb=QT0yM4bpIbwMpFwrD+huOWsPAzpG6Lge9Rl2IC0zk7CEUT4DESCqb+TrsmYhxPic54\n\tuEPFJamtWJN/ti/orRDv4IAtyrFR3Ab99LXKoCDELHuzF2S18CBvxp/YVsXDfrMPGKUo\n\tDUUwgzeCj+wSm1WIslPd3I657Q+5HkW5/TogR1VMLH7xtzkvthA6X5voD6aaYEgwsJls\n\tEzW+AEjq5Oy/9pRQeie5XdEJJpI8TaDWYnQdyTaKHh3EyuTS4lVd0Wi5XX3pkc1FLwXM\n\tYUE8smjNHP2Ap61sCe04pVLAPaDCY7Ybx6RHrNdiCGhVhsNYSXSxpJC8xncfJLa6lPY7\n\tWpAA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=yGHINrQ4IpUSRYjxWPnntDTBMlhSADbt7+/syiSNhIE=;\n\tb=Vzy8bITwU2sJQl03V394C0mSXGbxGmklSMmxC7yy1KjIKC8khIo69c/AtDvwtTM6fW\n\txAMR2jyJCpZ1u/P8GF+3HRj//CtCpVjcnlkPIQo35UZfQNM0Vif9RW7IfT41Lxbfdcr8\n\td2KncKOUFgZ5BRB4OOHrSEoWLOxipa1ZH0NyH1kNyQnKG7CQCjYuwN4RV05QQqzlOL8w\n\tSJ3BbYNK9y3KXUkVBAiMcMFZ9V9WTAG095lkzeRmNan/hdNLgVOvcU/ODBeESmptqwU+\n\td4tDsKeoB0tVXJz56/4ARbIep/kazjwQ/BH5/T4q8FWz55dwd2AnZP8HDrSAPe65tjWY\n\t61wA==","X-Gm-Message-State":"AOAM532bxP5F9ma/Y+UDStgcyzFoWvTPCMdSvLLhomAfA+vp5F3EZPSn\n\teJdrm0wH+P9BCfbKFC4ZPqWxd8nQyssC2ZBPJ1YfUvLXfrJuRafN","X-Google-Smtp-Source":"ABdhPJysprGM1YSq/tISEkvEIju+qhznhhrLslZbrdPi8ftu/RJocc9Vqero6ZBj1gIW4TAL7iBRLe7cFfRK74PX9gg=","X-Received":"by 2002:a2e:910b:: with SMTP id\n\tm11mr4466598ljg.499.1612438415003; \n\tThu, 04 Feb 2021 03:33:35 -0800 (PST)","MIME-Version":"1.0","References":"<20210129111616.1047483-1-naush@raspberrypi.com>\n\t","In-Reply-To":"","From":"Naushir Patuck ","Date":"Thu, 4 Feb 2021 11:33:19 +0000","Message-ID":"","To":"libcamera devel ","Subject":"Re: [libcamera-devel] [PATCH v4 0/5] Raspberry Pi: FrameDurations\n\tcontrol refinements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============5840686178255910511==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]