{"id":11023,"url":"https://patchwork.libcamera.org/api/covers/11023/?format=json","web_url":"https://patchwork.libcamera.org/cover/11023/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210126184854.46156-1-sebastian.fricke@posteo.net>","date":"2021-01-26T18:48:49","name":"[libcamera-devel,v3,0/5] Improve BayerFormat class","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/?format=json","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"mbox":"https://patchwork.libcamera.org/cover/11023/mbox/","series":[{"id":1613,"url":"https://patchwork.libcamera.org/api/series/1613/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1613","date":"2021-01-26T18:48:49","name":"Improve BayerFormat class","version":3,"mbox":"https://patchwork.libcamera.org/series/1613/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/11023/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C75DFC0F2B\n\tfor ;\n\tTue, 26 Jan 2021 18:48:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2EBCF68321;\n\tTue, 26 Jan 2021 19:48:59 +0100 (CET)","from mout02.posteo.de (mout02.posteo.de [185.67.36.66])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C40668318\n\tfor ;\n\tTue, 26 Jan 2021 19:48:57 +0100 (CET)","from submission (posteo.de [89.146.220.130]) \n\tby mout02.posteo.de (Postfix) with ESMTPS id E3B522400FB\n\tfor ;\n\tTue, 26 Jan 2021 19:48:56 +0100 (CET)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4DQG3W3yPBz6tmJ;\n\tTue, 26 Jan 2021 19:48:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"pDFPXqZc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1611686936; bh=X+D+Duwb6oTXKM5UfQxTBriBDNsob5F0YcdhglFov0w=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=pDFPXqZcWqttl8NZLNITL2k+xDMmPIf85zHDnnSxvDGOv9pwZv8rrgH3zkwb6BES/\n\tW81kNTG5mA7VLXpxS0o9wh5Acyag2eNylcQf9/QYO4+NS/XNOwFd59x/74B6aBVlOH\n\tJm157gBhLQRc8KvFexKIRcXL3ylocwpWOMMQV4r4HO41CYFDVW12WqqPycnIzz/5ou\n\tyFagnsnE+ea6B6JTWscDpoudbKCWgjrEDaSIlW8NlNzC+ZK98Ns7izqzd5vD/3X9Kg\n\ts9KnNWH9yHlYQdPzXE4fmsOPdNM1Uf4mbAMztxKRgv2mruROYoef1gGPN92PZ7YOm8\n\tbWzx7dlyVWnXA==","From":"Sebastian Fricke ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 26 Jan 2021 19:48:49 +0100","Message-Id":"<20210126184854.46156-1-sebastian.fricke@posteo.net>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 0/5] Improve BayerFormat class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Improve BayerFormat class\n\nThis patch series adds unit-tests, the `fromV4L2PixelFormat` static\nmember function and the ==/!= operators to the BayerFormat class.\n\n---\n\nChanges since version 2:\n* Improve the error messages of the unit tests by reducing them to a\n single-line if possible.\n* Change the test that makes sure that an invalid BayerFormat doesn't\n yield a V4L2PixelFormat to use an empty BayerFormat instead of an\n imaginary one.\n* Add the transpose transformation to the transform method.\n* Add an extra test that makes sure that a transpose on a format causes\n red and blue pixels that are on the antidiagonal to switch their position.\n* Change the transpose tests to not compare BayerFormat string\n representations.\n* Combine the modifications in the Raspberry Pi pipeline with the first\n patch that adds the `fromV4L2PixelFormat` static member function.\n* Add documentation for the `!=` operator.\n* Split the removal of the deprecated constructor and mapping table from\n the addition of the `fromV4L2PixelFormat` function.\n* Fix indentation issues.\n\nChanges since version 1:\n* Convert the `fromV4L2PixelFormat` to a static member function, as it doesn't\n contain any self use.\n* Adjust the current user of the old constructor (raspberryPi pipeline) to use\n the new function.\n* Add the ==/!= operators to improve tests and to add helpful helper functions.\n* Change the logic of `fromV4L2PixelFormat` by replace the search of a matching\n bayer format to a v4l2 pixel format with a search for a matching v4l2 pixel\n format to a bayer format.\n* Remove the v4l2ToBayer mapping table as it lost it's last user\n* Remove 'TEST \\d:' & 'TEST \\d: FAIL:' pattern from comments and messages\n within the unit tests.\n* Convert variable names from snake_case to camelCase.\n* Add an additional to test to confirm that we cannot get a V4L2PixelFormat\n from a BayerFormat not found in the mapping table.\n* Add tests for the == & != operators\n* Change the test within the Transform unit tests from a comparision of string\n formats to a direct compare of the BayerFormat objects.\n* Unify the test error messages by enclosing the expected and actual string\n representations in ''\n* Fix checkstyle errors.\n* Add explaination for why the transpose functionality was ignored\n within the unit test.\n\n---\n\nSebastian Fricke (5):\n libcamera: Add the fromV4L2PixelFormat function\n libcamera: Remove unnecessary constructor\n libcamera: Overload ==/!= operators for BayerFormats\n libcamera: Add the transpose transformation\n test: Add unit tests for the BayerFormat class\n\n include/libcamera/internal/bayer_format.h | 8 +-\n src/libcamera/bayer_format.cpp | 89 ++++----\n .../pipeline/raspberrypi/raspberrypi.cpp | 4 +-\n test/bayer_format.cpp | 210 ++++++++++++++++++\n test/meson.build | 1 +\n 5 files changed, 260 insertions(+), 52 deletions(-)\n create mode 100644 test/bayer_format.cpp"}