{"id":10989,"url":"https://patchwork.libcamera.org/api/covers/10989/?format=json","web_url":"https://patchwork.libcamera.org/cover/10989/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210125184858.16339-1-david.plowman@raspberrypi.com>","date":"2021-01-25T18:48:53","name":"[libcamera-devel,v2,0/5] Remove Raspberry Pi logging","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/10989/mbox/","series":[{"id":1606,"url":"https://patchwork.libcamera.org/api/series/1606/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1606","date":"2021-01-25T18:48:53","name":"Remove Raspberry Pi logging","version":2,"mbox":"https://patchwork.libcamera.org/series/1606/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/10989/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ACF55BD808\n\tfor ;\n\tMon, 25 Jan 2021 18:49:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3655E682DB;\n\tMon, 25 Jan 2021 19:49:05 +0100 (CET)","from mail-ed1-x530.google.com (mail-ed1-x530.google.com\n\t[IPv6:2a00:1450:4864:20::530])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 125D6682CB\n\tfor ;\n\tMon, 25 Jan 2021 19:49:04 +0100 (CET)","by mail-ed1-x530.google.com with SMTP id d22so16776593edy.1\n\tfor ;\n\tMon, 25 Jan 2021 10:49:04 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\ty59sm11601836ede.59.2021.01.25.10.49.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 25 Jan 2021 10:49:02 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"RFEp9UIl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=JFGgB7Od4L5vHb1fn8AXLP04JwbNT1CBENlztafjzjo=;\n\tb=RFEp9UIl6vuyS6jrzEZy4+NboDYltw30XZkAXC3iu+GBxkewnxgg+Ibhn2kdxK+arS\n\t9gp9Ie4YLEU7lfsqLNGNFrD2h/K2gUwm5GJfrv30dkRFF8bykiS51P73s8yMAZfp2bn1\n\tD2MA2tNpSQ/H6yXoLcrcdxCS6lnoaXmO7Mg3QEVsup6+AnAa53J2gb1Z701wOz0TqCcy\n\tBT8fi6MWgHE9TJZsNEqTyHa+C1AR58BoGYZyb6yLwOa5vjzKBmax1VuS73fG7FtBPf5y\n\twzigP8M9JkZ7FOBNZ7kAwqHDq7ZeJGf5sflfl5sba6mQRqrr12BFVbF7NWakdiv9fzf4\n\tQxoQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=JFGgB7Od4L5vHb1fn8AXLP04JwbNT1CBENlztafjzjo=;\n\tb=rn2PiLUaSag+jWcHdP0LMo80C/FtZp0sHNJftR58c+UbsKEUu2THX3A62ZvAgU3yfE\n\tFaYQ1qhpsbI79R5t5BwR3vrgJUc8lD0tv3dIEt2Ml+slxc3s/22pnxvl7hqY3IZ3pm+w\n\t0y9jsF4M4Lk3KLIoblnk4A/ak6XDipsIFHJzAg33cmatCCsj60uuOcX49oA3sVWPSdlu\n\tgeBz6j7VnenD7CyWOufi5pSL5yNQNzEpwYSyXalxRhuOxj7waBravqBdxUXQo4RuBybN\n\tHVb6CrNgUuhvNf4oDBJ93Ll9egXnGdi2BzFjGMGM62+0oeYNuqHDwsS1eR/ovOUBLw2z\n\tv5AQ==","X-Gm-Message-State":"AOAM530N3mNr5T0607mOZtCJsiIb6ElYJvAZ6SZ94kky9HQDFfkkgZds\n\tGNkBWYAqBaDGGa5kE+a2GFFPmoo+5AYqsRyj","X-Google-Smtp-Source":"ABdhPJwAnMxjcN+iw90znzvHGQVipErOX+sJEl/sL5RtM6T0uAIzTZX9Rd2r0rgoA6wGcDgfie86Cw==","X-Received":"by 2002:a50:eacd:: with SMTP id\n\tu13mr1627243edp.382.1611600543442; \n\tMon, 25 Jan 2021 10:49:03 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 25 Jan 2021 18:48:53 +0000","Message-Id":"<20210125184858.16339-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 0/5] Remove Raspberry Pi logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi again everyone\n\nVersion 2 of this set again makes no functional changes beyond debug\nlogging. There are the following differences compared to v1:\n\n* I've removed some debug messages that were unnecessary (either just\n tracing statements or duplicates).\n\n* A number of messages repeated the algorithm name which is\n unnecessary with libcamera logging.\n\n* One or two that were actually warnings without using LOG(RPiXxx,\n Warning) have been amended.\n\n* A bit more whitespace tidying.\n\nI've actually folded the changes into the original commits, I think\nit's easy enough to follow like this.\n\nMost of Laurent's other suggestions I'd be fine with if we wanted to\npursue them (except the one about sharing frame counts between\nalgorithms - I'm actually really paranoid about that!).\n\nThanks!\nDavid\n\nDavid Plowman (5):\n ipa: raspberrypi: controller: Replace Raspberry Pi debug with\n libcamera debug\n ipa: raspberrypi: alsc: Replace Raspberry Pi debug with libcamera\n debug\n ipa: raspberrypi: awb: Replace Raspberry Pi debug with libcamera debug\n ipa: raspberrypi: Replace Raspberry Pi debug with libcamera debug\n ipa: raspberrypi: Remove legacy Rasberry Pi logging\n\n src/ipa/raspberrypi/controller/algorithm.hpp | 1 -\n src/ipa/raspberrypi/controller/controller.cpp | 19 ++--\n src/ipa/raspberrypi/controller/logging.hpp | 30 ------\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 66 +++++++------\n src/ipa/raspberrypi/controller/rpi/awb.cpp | 97 ++++++++++---------\n .../controller/rpi/black_level.cpp | 11 ++-\n src/ipa/raspberrypi/controller/rpi/ccm.cpp | 26 +++--\n .../raspberrypi/controller/rpi/contrast.cpp | 20 +++-\n src/ipa/raspberrypi/controller/rpi/dpc.cpp | 8 +-\n src/ipa/raspberrypi/controller/rpi/geq.cpp | 20 ++--\n src/ipa/raspberrypi/controller/rpi/lux.cpp | 11 ++-\n src/ipa/raspberrypi/controller/rpi/noise.cpp | 14 ++-\n src/ipa/raspberrypi/controller/rpi/sdn.cpp | 21 ++--\n .../raspberrypi/controller/rpi/sharpen.cpp | 11 ++-\n 14 files changed, 192 insertions(+), 163 deletions(-)\n delete mode 100644 src/ipa/raspberrypi/controller/logging.hpp"}