[{"id":14690,"web_url":"https://patchwork.libcamera.org/comment/14690/","msgid":"<694bba46-c5e8-b0e5-71dd-dcace1613ee5@ideasonboard.com>","date":"2021-01-22T11:31:58","subject":"Re: [libcamera-devel] [PATCH 0/5] Remove Raspberry Pi logging","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David,\n\nOn 22/01/2021 10:22, David Plowman wrote:\n> Hi everyone\n> \n> This patch set removes the old Raspberry Pi logging from all our\n> control algorithms and replaces it with libcamera logging. There is\n> literally nothing in this patch set except for the necessary macro\n> replacements and a few whitespace adjustments to keep the style\n> checker happy.\n> \n> This is actually quite an important change because, now that we're\n> about to publish libcamera versions of our legacy applications, it\n> makes it much easier to get debug information from our customers.\n\nAha, great, indeed it will tie into the existing logging infrastructure\nnicely.\n\n\n> Perhaps the biggest question is whether to squish all the patches\n> together? I've not done this yet as it's easier to squish than to\n> un-squish, though I did roll up all the \"minor\" algorithms into a\n> single commit. But I'll happily do that if it's tidier!\n\nI don't think that matters too much here. Indeed we could squash 1-4, or\nsplit 4/5 further - but I don't think any of that effort is required here.\n\nIt's interesting that you can now enabled/disable specific algorithm\ndebug explictily. I wonder if sometime later we might want to be able to\n'group' multiple debug categories to enable all IPA debug without\nenabling V4L2 debug for instance, or perhaps to have a way to 'disable'\nsome categories.\n\nBut that's speculation on future features - for this whole series\n\nReviewed-by: Kieran Bingham \n\n\n\n> \n> Thanks and best regards\n> David\n> \n> David Plowman (5):\n> ipa: raspberrypi: controller: Replace Raspberry Pi debug with\n> libcamera debug\n> ipa: raspberrypi: alsc: Replace Raspberry Pi debug with libcamera\n> debug\n> ipa: raspberrypi: awb: Replace Raspberry Pi debug with libcamera debug\n> ipa: raspberrypi: Replace Raspberry Pi debug with libcamera debug\n> ipa: raspberrypi: Remove legacy Rasberry Pi logging\n> \n> src/ipa/raspberrypi/controller/algorithm.hpp | 1 -\n> src/ipa/raspberrypi/controller/controller.cpp | 29 +++---\n> src/ipa/raspberrypi/controller/logging.hpp | 30 ------\n> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 59 ++++++------\n> src/ipa/raspberrypi/controller/rpi/awb.cpp | 92 ++++++++++---------\n> .../controller/rpi/black_level.cpp | 8 +-\n> src/ipa/raspberrypi/controller/rpi/ccm.cpp | 24 +++--\n> .../raspberrypi/controller/rpi/contrast.cpp | 15 ++-\n> src/ipa/raspberrypi/controller/rpi/dpc.cpp | 8 +-\n> src/ipa/raspberrypi/controller/rpi/geq.cpp | 18 ++--\n> src/ipa/raspberrypi/controller/rpi/lux.cpp | 12 ++-\n> src/ipa/raspberrypi/controller/rpi/noise.cpp | 14 ++-\n> src/ipa/raspberrypi/controller/rpi/sdn.cpp | 21 +++--\n> .../raspberrypi/controller/rpi/sharpen.cpp | 8 +-\n> 14 files changed, 179 insertions(+), 160 deletions(-)\n> delete mode 100644 src/ipa/raspberrypi/controller/logging.hpp\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ADEF3BD808\n\tfor ;\n\tFri, 22 Jan 2021 11:32:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E9456823E;\n\tFri, 22 Jan 2021 12:32:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAAAF681D8\n\tfor ;\n\tFri, 22 Jan 2021 12:32:01 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A73A4FB;\n\tFri, 22 Jan 2021 12:32:01 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"u9G/yR0z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611315121;\n\tbh=CHU8So9J0QwKkAyq0Wl+JzZ5+jJLm29pDgntolztpIk=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=u9G/yR0zUyg/B5qRvObz/P5kcfItf5XE4RXaOmkFbMKlEGRxDzEvtUF/5AGSmyVR5\n\taTAnGUQ5cK6XeghbquYFbVjaEHc2BP3Nxawobrmn723irONKwmpNAYmhR1JR1Pjxc6\n\tuxhKZDnF4bfV+tK13kTCQ1/bZYMgDvClFCpPpa+Y=","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210122102211.12768-1-david.plowman@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<694bba46-c5e8-b0e5-71dd-dcace1613ee5@ideasonboard.com>","Date":"Fri, 22 Jan 2021 11:31:58 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210122102211.12768-1-david.plowman@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 0/5] Remove Raspberry Pi logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14718,"web_url":"https://patchwork.libcamera.org/comment/14718/","msgid":"","date":"2021-01-22T15:37:48","subject":"Re: [libcamera-devel] [PATCH 0/5] Remove Raspberry Pi logging","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for your patch.\n\nOn Fri, 22 Jan 2021 at 10:22, David Plowman \nwrote:\n\n> Hi everyone\n>\n> This patch set removes the old Raspberry Pi logging from all our\n> control algorithms and replaces it with libcamera logging. There is\n> literally nothing in this patch set except for the necessary macro\n> replacements and a few whitespace adjustments to keep the style\n> checker happy.\n>\n> This is actually quite an important change because, now that we're\n> about to publish libcamera versions of our legacy applications, it\n> makes it much easier to get debug information from our customers.\n>\n> Perhaps the biggest question is whether to squish all the patches\n> together? I've not done this yet as it's easier to squish than to\n> un-squish, though I did roll up all the \"minor\" algorithms into a\n> single commit. But I'll happily do that if it's tidier!\n>\n> Thanks and best regards\n> David\n>\n\nVery useful! For the entire series:\n\nReviewed-by: Naushir Patuck \n\n\n\n>\n> David Plowman (5):\n> ipa: raspberrypi: controller: Replace Raspberry Pi debug with\n> libcamera debug\n> ipa: raspberrypi: alsc: Replace Raspberry Pi debug with libcamera\n> debug\n> ipa: raspberrypi: awb: Replace Raspberry Pi debug with libcamera debug\n> ipa: raspberrypi: Replace Raspberry Pi debug with libcamera debug\n> ipa: raspberrypi: Remove legacy Rasberry Pi logging\n>\n> src/ipa/raspberrypi/controller/algorithm.hpp | 1 -\n> src/ipa/raspberrypi/controller/controller.cpp | 29 +++---\n> src/ipa/raspberrypi/controller/logging.hpp | 30 ------\n> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 59 ++++++------\n> src/ipa/raspberrypi/controller/rpi/awb.cpp | 92 ++++++++++---------\n> .../controller/rpi/black_level.cpp | 8 +-\n> src/ipa/raspberrypi/controller/rpi/ccm.cpp | 24 +++--\n> .../raspberrypi/controller/rpi/contrast.cpp | 15 ++-\n> src/ipa/raspberrypi/controller/rpi/dpc.cpp | 8 +-\n> src/ipa/raspberrypi/controller/rpi/geq.cpp | 18 ++--\n> src/ipa/raspberrypi/controller/rpi/lux.cpp | 12 ++-\n> src/ipa/raspberrypi/controller/rpi/noise.cpp | 14 ++-\n> src/ipa/raspberrypi/controller/rpi/sdn.cpp | 21 +++--\n> .../raspberrypi/controller/rpi/sharpen.cpp | 8 +-\n> 14 files changed, 179 insertions(+), 160 deletions(-)\n> delete mode 100644 src/ipa/raspberrypi/controller/logging.hpp\n>\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61207C0F2B\n\tfor ;\n\tFri, 22 Jan 2021 15:38:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C9E4868297;\n\tFri, 22 Jan 2021 16:38:07 +0100 (CET)","from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com\n\t[IPv6:2a00:1450:4864:20::12d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E779B6828D\n\tfor ;\n\tFri, 22 Jan 2021 16:38:05 +0100 (CET)","by mail-lf1-x12d.google.com with SMTP id p21so3003384lfu.11\n\tfor ;\n\tFri, 22 Jan 2021 07:38:05 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"qHDOM4hV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=vOEX7IzVn9DqHT0dvbkrABd6PNsyjGwNS67GUL6hcLc=;\n\tb=qHDOM4hVX3S5JXDc8S8dLBIIwerBZEQ1DwT7iNlJvIqn96R+Z9NuAlwqCZn8IIroie\n\tdAQesjbHq5u5vszCWdUFLFciI+5TjmBYilo+GDwPfPLrvekLlp7jSPABauXqsSLzSSyI\n\tV81CIoV3D7DExWbJHGPEtQOzlbXXZSu175+Wv0La6FrkGFP5fQsyOO/K1AGEUzFwLVQr\n\tgotCq0oZu/sJotblWKqg14VjOxybpA/Ts1+J5TC4qGUAGu2eIQBOs1h+Ju1REYCXw2ZM\n\tB7XUo0OalApNWl3fRkH20sSwaF8tjPjIyGTyALPPNBw1V+9TkLwMs0xgkAih4B1ZNpTG\n\te/XQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=vOEX7IzVn9DqHT0dvbkrABd6PNsyjGwNS67GUL6hcLc=;\n\tb=QP/Nvr9tieFGwtbv+msMsUjahAqTB37qlRMp3vGok6x7tBf4pkaOMIHCCQMqh5eUnU\n\tCIoxQ62OF2xCAZ9ykR2M12Qgs84QWU4NByJV2ddnteYA2nqTyeBfv2JGBNczzhyjsozc\n\ti4WaFHxtFyiMUR+hAZeTwELKYQUWQHy3iSxPq8I2zufOKPXRK1U5c0YDde/e4MAySxxV\n\t9uGVoRKOEHp19ngpVmI3/KaMaWN/Dhcg1zzEaeG5ybHcLqfab+PSU+QGnNs3x1Cf0yMD\n\tUctK37yOsLM8Xk4atmemsqZzDQliptQvHu+Njqy070UqqJloJH1SzNQpbhLw/tiCfYMp\n\t2I/A==","X-Gm-Message-State":"AOAM530Q7YNI7j/QNuzf146m0RXQw/uRCQr0a+/jWV+u/d1QxNH5KjuS\n\toDMrYctCbGYHFtUuZT7G5XAAP54ovOkYx8pQC1T21Q==","X-Google-Smtp-Source":"ABdhPJyT0xYeg2urZtHMRXkF31gxIj8t2XGv6XJdKMOAa404GgTANDqJcvqgeZP1rA6lUejWG5fYi/+W2oDgIn8Jikw=","X-Received":"by 2002:a19:ee09:: with SMTP id g9mr1141596lfb.272.1611329885264;\n\tFri, 22 Jan 2021 07:38:05 -0800 (PST)","MIME-Version":"1.0","References":"<20210122102211.12768-1-david.plowman@raspberrypi.com>","In-Reply-To":"<20210122102211.12768-1-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Fri, 22 Jan 2021 15:37:48 +0000","Message-ID":"","To":"David Plowman ","Subject":"Re: [libcamera-devel] [PATCH 0/5] Remove Raspberry Pi logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============8355481727297806810==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14732,"web_url":"https://patchwork.libcamera.org/comment/14732/","msgid":"","date":"2021-01-23T11:15:51","subject":"Re: [libcamera-devel] [PATCH 0/5] Remove Raspberry Pi logging","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David and Kieran,\n\nOn Fri, Jan 22, 2021 at 11:31:58AM +0000, Kieran Bingham wrote:\n> On 22/01/2021 10:22, David Plowman wrote:\n> > This patch set removes the old Raspberry Pi logging from all our\n> > control algorithms and replaces it with libcamera logging. There is\n> > literally nothing in this patch set except for the necessary macro\n> > replacements and a few whitespace adjustments to keep the style\n> > checker happy.\n> > \n> > This is actually quite an important change because, now that we're\n> > about to publish libcamera versions of our legacy applications, it\n> > makes it much easier to get debug information from our customers.\n> \n> Aha, great, indeed it will tie into the existing logging infrastructure\n> nicely.\n> \n> > Perhaps the biggest question is whether to squish all the patches\n> > together? I've not done this yet as it's easier to squish than to\n> > un-squish, though I did roll up all the \"minor\" algorithms into a\n> > single commit. But I'll happily do that if it's tidier!\n> \n> I don't think that matters too much here. Indeed we could squash 1-4, or\n> split 4/5 further - but I don't think any of that effort is required here.\n\nAgreed, we can keep it as-is. It's certainly easier to review with 5\npatches than with a single one.\n\n> It's interesting that you can now enabled/disable specific algorithm\n> debug explictily. I wonder if sometime later we might want to be able to\n> 'group' multiple debug categories to enable all IPA debug without\n> enabling V4L2 debug for instance, or perhaps to have a way to 'disable'\n> some categories.\n\nWe can use a wildcard * at the end of a category name, so the feature is\nalready here.\n\n> But that's speculation on future features - for this whole series\n> \n> Reviewed-by: Kieran Bingham \n> \n> > Thanks and best regards\n> > David\n> > \n> > David Plowman (5):\n> > ipa: raspberrypi: controller: Replace Raspberry Pi debug with\n> > libcamera debug\n> > ipa: raspberrypi: alsc: Replace Raspberry Pi debug with libcamera\n> > debug\n> > ipa: raspberrypi: awb: Replace Raspberry Pi debug with libcamera debug\n> > ipa: raspberrypi: Replace Raspberry Pi debug with libcamera debug\n> > ipa: raspberrypi: Remove legacy Rasberry Pi logging\n> > \n> > src/ipa/raspberrypi/controller/algorithm.hpp | 1 -\n> > src/ipa/raspberrypi/controller/controller.cpp | 29 +++---\n> > src/ipa/raspberrypi/controller/logging.hpp | 30 ------\n> > src/ipa/raspberrypi/controller/rpi/alsc.cpp | 59 ++++++------\n> > src/ipa/raspberrypi/controller/rpi/awb.cpp | 92 ++++++++++---------\n> > .../controller/rpi/black_level.cpp | 8 +-\n> > src/ipa/raspberrypi/controller/rpi/ccm.cpp | 24 +++--\n> > .../raspberrypi/controller/rpi/contrast.cpp | 15 ++-\n> > src/ipa/raspberrypi/controller/rpi/dpc.cpp | 8 +-\n> > src/ipa/raspberrypi/controller/rpi/geq.cpp | 18 ++--\n> > src/ipa/raspberrypi/controller/rpi/lux.cpp | 12 ++-\n> > src/ipa/raspberrypi/controller/rpi/noise.cpp | 14 ++-\n> > src/ipa/raspberrypi/controller/rpi/sdn.cpp | 21 +++--\n> > .../raspberrypi/controller/rpi/sharpen.cpp | 8 +-\n> > 14 files changed, 179 insertions(+), 160 deletions(-)\n> > delete mode 100644 src/ipa/raspberrypi/controller/logging.hpp","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66390BD808\n\tfor ;\n\tSat, 23 Jan 2021 11:16:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 30351682A0;\n\tSat, 23 Jan 2021 12:16:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D54868297\n\tfor ;\n\tSat, 23 Jan 2021 12:16:11 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DA778DA;\n\tSat, 23 Jan 2021 12:16:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Olty4LkW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611400571;\n\tbh=GorGAicA0G2f3ylkYoVAMsuH9eZmdNPHQhHcnqMP/o0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Olty4LkWgnMe+qaKgTsxIkas93KjeUoPBycAMmk/ytDmxw5AXKM4s1gBRljx+h6Nu\n\tudTxQIJwavnV6teiJ3IGsDJp75LSgq13/kP9wh+QNU813pEm7ZIOUmMU5GHhEZsWYT\n\tEHpqQHS77wbpz/V1n6PI3nT90hVMm0vRpANGw4CE=","Date":"Sat, 23 Jan 2021 13:15:51 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210122102211.12768-1-david.plowman@raspberrypi.com>\n\t<694bba46-c5e8-b0e5-71dd-dcace1613ee5@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<694bba46-c5e8-b0e5-71dd-dcace1613ee5@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 0/5] Remove Raspberry Pi logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14748,"web_url":"https://patchwork.libcamera.org/comment/14748/","msgid":"","date":"2021-01-25T10:58:37","subject":"Re: [libcamera-devel] [PATCH 0/5] Remove Raspberry Pi logging","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Laurent\n\nThanks for the review of all these patches.\n\nI guess I was just swapping out the macros, but I think your\nobservations are fair enough:\n\n* Debug that is just tracing can probably just be removed. It is\ninherited from the platform where this code originally came from, and\nback then it was all new and I probably liked the reassurance about\nwhat was happening, especially as we were just processing single\nimages.\n\n* Things like hierarchical categories sound nice, but I'm not sure\nit's that important for us. The most likely use case for us will be\nwhen some particular algorithm (e.g. AWB) is mis-behaviing and we want\nto see what that single algorithm is doing.\n\n* Yes, there seem to be some messages that are warnings but were not\ncategorised initially with RPI_WARN. Not sure why, but they probably\nshould be changed.\n\nAs regards making these changes, would you fold them into the existing\ncommits, or would you rather have them as additional changes (i.e.\nkeep the macro-swapping separate from anything else)? For myself, I\ndon't mind either way!\n\nLet me know what you think, and I can do a v2 set accordingly.\n\nThanks again\nDavid\n\nOn Sat, 23 Jan 2021 at 11:16, Laurent Pinchart\n wrote:\n>\n> Hi David and Kieran,\n>\n> On Fri, Jan 22, 2021 at 11:31:58AM +0000, Kieran Bingham wrote:\n> > On 22/01/2021 10:22, David Plowman wrote:\n> > > This patch set removes the old Raspberry Pi logging from all our\n> > > control algorithms and replaces it with libcamera logging. There is\n> > > literally nothing in this patch set except for the necessary macro\n> > > replacements and a few whitespace adjustments to keep the style\n> > > checker happy.\n> > >\n> > > This is actually quite an important change because, now that we're\n> > > about to publish libcamera versions of our legacy applications, it\n> > > makes it much easier to get debug information from our customers.\n> >\n> > Aha, great, indeed it will tie into the existing logging infrastructure\n> > nicely.\n> >\n> > > Perhaps the biggest question is whether to squish all the patches\n> > > together? I've not done this yet as it's easier to squish than to\n> > > un-squish, though I did roll up all the \"minor\" algorithms into a\n> > > single commit. But I'll happily do that if it's tidier!\n> >\n> > I don't think that matters too much here. Indeed we could squash 1-4, or\n> > split 4/5 further - but I don't think any of that effort is required here.\n>\n> Agreed, we can keep it as-is. It's certainly easier to review with 5\n> patches than with a single one.\n>\n> > It's interesting that you can now enabled/disable specific algorithm\n> > debug explictily. I wonder if sometime later we might want to be able to\n> > 'group' multiple debug categories to enable all IPA debug without\n> > enabling V4L2 debug for instance, or perhaps to have a way to 'disable'\n> > some categories.\n>\n> We can use a wildcard * at the end of a category name, so the feature is\n> already here.\n>\n> > But that's speculation on future features - for this whole series\n> >\n> > Reviewed-by: Kieran Bingham \n> >\n> > > Thanks and best regards\n> > > David\n> > >\n> > > David Plowman (5):\n> > > ipa: raspberrypi: controller: Replace Raspberry Pi debug with\n> > > libcamera debug\n> > > ipa: raspberrypi: alsc: Replace Raspberry Pi debug with libcamera\n> > > debug\n> > > ipa: raspberrypi: awb: Replace Raspberry Pi debug with libcamera debug\n> > > ipa: raspberrypi: Replace Raspberry Pi debug with libcamera debug\n> > > ipa: raspberrypi: Remove legacy Rasberry Pi logging\n> > >\n> > > src/ipa/raspberrypi/controller/algorithm.hpp | 1 -\n> > > src/ipa/raspberrypi/controller/controller.cpp | 29 +++---\n> > > src/ipa/raspberrypi/controller/logging.hpp | 30 ------\n> > > src/ipa/raspberrypi/controller/rpi/alsc.cpp | 59 ++++++------\n> > > src/ipa/raspberrypi/controller/rpi/awb.cpp | 92 ++++++++++---------\n> > > .../controller/rpi/black_level.cpp | 8 +-\n> > > src/ipa/raspberrypi/controller/rpi/ccm.cpp | 24 +++--\n> > > .../raspberrypi/controller/rpi/contrast.cpp | 15 ++-\n> > > src/ipa/raspberrypi/controller/rpi/dpc.cpp | 8 +-\n> > > src/ipa/raspberrypi/controller/rpi/geq.cpp | 18 ++--\n> > > src/ipa/raspberrypi/controller/rpi/lux.cpp | 12 ++-\n> > > src/ipa/raspberrypi/controller/rpi/noise.cpp | 14 ++-\n> > > src/ipa/raspberrypi/controller/rpi/sdn.cpp | 21 +++--\n> > > .../raspberrypi/controller/rpi/sharpen.cpp | 8 +-\n> > > 14 files changed, 179 insertions(+), 160 deletions(-)\n> > > delete mode 100644 src/ipa/raspberrypi/controller/logging.hpp\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1057BC0F2B\n\tfor ;\n\tMon, 25 Jan 2021 10:58:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 98653682BA;\n\tMon, 25 Jan 2021 11:58:50 +0100 (CET)","from mail-oi1-x235.google.com (mail-oi1-x235.google.com\n\t[IPv6:2607:f8b0:4864:20::235])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D06F6030B\n\tfor ;\n\tMon, 25 Jan 2021 11:58:49 +0100 (CET)","by mail-oi1-x235.google.com with SMTP id d18so4971988oic.3\n\tfor ;\n\tMon, 25 Jan 2021 02:58:49 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"PX9y2XTS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=0SFLnyaknldZutbNF6YMvtx+k+VC41NqFKg5HcbML4k=;\n\tb=PX9y2XTST26mEY+B3jie6+feaeHvfb85GexcNebGqRYBkKHKH8cIesa3j9i0sEIv19\n\tIQ+MfEkvXi/njCEiQziwbnxXWAaUtAnsxm2DDXjp8lDYLETQ+MuyaZT9fHHr3MuKF759\n\t5w3QPkQ0/4RU3BRCKpTMYjRgdJnHOHEfuzpybJ69ynPqFPFQ7b1iakXvQdsUFHhIbryn\n\tXM77f10p03Rc/d2tcQwtQG+7rLkHTOf1VKKggY+acpZPCSz+El0z3bTzuG3kS3TjqxFQ\n\tgvRo+V7uy4LbypXszabJ2L8KpEjCKigb8DDn8I08vUBybdIBUpyeEFRjE5hLw5uUnErM\n\tBn1Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=0SFLnyaknldZutbNF6YMvtx+k+VC41NqFKg5HcbML4k=;\n\tb=onQmid3IvgyCEOBjnYjROeaU+Sv7sX5u28R3CBnu64nl+R0/Hx7GW5TClm+507ILxa\n\tV2Mto+PlZhbq8hMBAuJ7PcanvJy361M6DPAuXAGiO3PXdocpit29ahs/Xf8HJulL/J9E\n\tdynxXlenRhsO1qZE2e+v3eiogAGJQHwH+bIcbcbJwCxP1BYvFn1P+XjPol+z1InjmZHU\n\tFYderXLweZwoYSTPTsqCCr2wgVrhvOJ7dKUdPywDlRjRWoRw+JjoMJchn1NeTiLWEvcy\n\tZ8rwD93u0LwCXuwpcefDqs33RyzfKwByAnISE1DW2EgTaVD5rpP49S/I+SAaFkBD+NSc\n\tDcTA==","X-Gm-Message-State":"AOAM5320adlmoZCnn0JB1BVqMss4XqZ3fKeVghyVzntTWFZTZxF2+YwE\n\tjk6ARas4X5ssTCftsEy38cyCDJ29hU0C80JzfbXrUw==","X-Google-Smtp-Source":"ABdhPJzdcbeyi0WAnEFBqTJQ9pnSClRibfMV/tM/6m6UCv2Rx0ijBURyuwCjGUVvybhxxgHwEcuPGPV0nKxrsLYC/K0=","X-Received":"by 2002:a05:6808:8cb:: with SMTP id\n\tk11mr128667oij.22.1611572327813; \n\tMon, 25 Jan 2021 02:58:47 -0800 (PST)","MIME-Version":"1.0","References":"<20210122102211.12768-1-david.plowman@raspberrypi.com>\n\t<694bba46-c5e8-b0e5-71dd-dcace1613ee5@ideasonboard.com>\n\t","In-Reply-To":"","From":"David Plowman ","Date":"Mon, 25 Jan 2021 10:58:37 +0000","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH 0/5] Remove Raspberry Pi logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14751,"web_url":"https://patchwork.libcamera.org/comment/14751/","msgid":"","date":"2021-01-25T11:08:03","subject":"Re: [libcamera-devel] [PATCH 0/5] Remove Raspberry Pi logging","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nOn Mon, Jan 25, 2021 at 10:58:37AM +0000, David Plowman wrote:\n> Hi Laurent\n> \n> Thanks for the review of all these patches.\n> \n> I guess I was just swapping out the macros, but I think your\n> observations are fair enough:\n> \n> * Debug that is just tracing can probably just be removed. It is\n> inherited from the platform where this code originally came from, and\n> back then it was all new and I probably liked the reassurance about\n> what was happening, especially as we were just processing single\n> images.\n> \n> * Things like hierarchical categories sound nice, but I'm not sure\n> it's that important for us. The most likely use case for us will be\n> when some particular algorithm (e.g. AWB) is mis-behaviing and we want\n> to see what that single algorithm is doing.\n> \n> * Yes, there seem to be some messages that are warnings but were not\n> categorised initially with RPI_WARN. Not sure why, but they probably\n> should be changed.\n> \n> As regards making these changes, would you fold them into the existing\n> commits, or would you rather have them as additional changes (i.e.\n> keep the macro-swapping separate from anything else)? For myself, I\n> don't mind either way!\n\nWhatever is easier for you :-) Having separate changes produces a bit of\na cleaner history, but I doubt anyone will need to read the history of\nthese changes.\n\n> Let me know what you think, and I can do a v2 set accordingly.\n> \n> On Sat, 23 Jan 2021 at 11:16, Laurent Pinchart wrote:\n> > On Fri, Jan 22, 2021 at 11:31:58AM +0000, Kieran Bingham wrote:\n> > > On 22/01/2021 10:22, David Plowman wrote:\n> > > > This patch set removes the old Raspberry Pi logging from all our\n> > > > control algorithms and replaces it with libcamera logging. There is\n> > > > literally nothing in this patch set except for the necessary macro\n> > > > replacements and a few whitespace adjustments to keep the style\n> > > > checker happy.\n> > > >\n> > > > This is actually quite an important change because, now that we're\n> > > > about to publish libcamera versions of our legacy applications, it\n> > > > makes it much easier to get debug information from our customers.\n> > >\n> > > Aha, great, indeed it will tie into the existing logging infrastructure\n> > > nicely.\n> > >\n> > > > Perhaps the biggest question is whether to squish all the patches\n> > > > together? I've not done this yet as it's easier to squish than to\n> > > > un-squish, though I did roll up all the \"minor\" algorithms into a\n> > > > single commit. But I'll happily do that if it's tidier!\n> > >\n> > > I don't think that matters too much here. Indeed we could squash 1-4, or\n> > > split 4/5 further - but I don't think any of that effort is required here.\n> >\n> > Agreed, we can keep it as-is. It's certainly easier to review with 5\n> > patches than with a single one.\n> >\n> > > It's interesting that you can now enabled/disable specific algorithm\n> > > debug explictily. I wonder if sometime later we might want to be able to\n> > > 'group' multiple debug categories to enable all IPA debug without\n> > > enabling V4L2 debug for instance, or perhaps to have a way to 'disable'\n> > > some categories.\n> >\n> > We can use a wildcard * at the end of a category name, so the feature is\n> > already here.\n> >\n> > > But that's speculation on future features - for this whole series\n> > >\n> > > Reviewed-by: Kieran Bingham \n> > >\n> > > > Thanks and best regards\n> > > > David\n> > > >\n> > > > David Plowman (5):\n> > > > ipa: raspberrypi: controller: Replace Raspberry Pi debug with\n> > > > libcamera debug\n> > > > ipa: raspberrypi: alsc: Replace Raspberry Pi debug with libcamera\n> > > > debug\n> > > > ipa: raspberrypi: awb: Replace Raspberry Pi debug with libcamera debug\n> > > > ipa: raspberrypi: Replace Raspberry Pi debug with libcamera debug\n> > > > ipa: raspberrypi: Remove legacy Rasberry Pi logging\n> > > >\n> > > > src/ipa/raspberrypi/controller/algorithm.hpp | 1 -\n> > > > src/ipa/raspberrypi/controller/controller.cpp | 29 +++---\n> > > > src/ipa/raspberrypi/controller/logging.hpp | 30 ------\n> > > > src/ipa/raspberrypi/controller/rpi/alsc.cpp | 59 ++++++------\n> > > > src/ipa/raspberrypi/controller/rpi/awb.cpp | 92 ++++++++++---------\n> > > > .../controller/rpi/black_level.cpp | 8 +-\n> > > > src/ipa/raspberrypi/controller/rpi/ccm.cpp | 24 +++--\n> > > > .../raspberrypi/controller/rpi/contrast.cpp | 15 ++-\n> > > > src/ipa/raspberrypi/controller/rpi/dpc.cpp | 8 +-\n> > > > src/ipa/raspberrypi/controller/rpi/geq.cpp | 18 ++--\n> > > > src/ipa/raspberrypi/controller/rpi/lux.cpp | 12 ++-\n> > > > src/ipa/raspberrypi/controller/rpi/noise.cpp | 14 ++-\n> > > > src/ipa/raspberrypi/controller/rpi/sdn.cpp | 21 +++--\n> > > > .../raspberrypi/controller/rpi/sharpen.cpp | 8 +-\n> > > > 14 files changed, 179 insertions(+), 160 deletions(-)\n> > > > delete mode 100644 src/ipa/raspberrypi/controller/logging.hpp","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5E32BD808\n\tfor ;\n\tMon, 25 Jan 2021 11:08:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5BBDC682BB;\n\tMon, 25 Jan 2021 12:08:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A5526030B\n\tfor ;\n\tMon, 25 Jan 2021 12:08:23 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 72625331;\n\tMon, 25 Jan 2021 12:08:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iuB50zdk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611572902;\n\tbh=dAigKepqgmYeypHlDasWtHLTBXQJTkPyNHs8TFCbi0Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=iuB50zdku/YBjl9IoXIWxKXVcoez3XzeIT8rhNyoDESmmhCffyiTKQNCVJI41hrqd\n\t2jte6Dj0kCowWZaF9DH0EqJn1MxafAgF2RZZG/HQSIkA0cu63ZrPDTur/OlrA99OgQ\n\tYWuhzzhUkFbA0bPIftj48LRcE+wKsAYs2tt1a7/k=","Date":"Mon, 25 Jan 2021 13:08:03 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20210122102211.12768-1-david.plowman@raspberrypi.com>\n\t<694bba46-c5e8-b0e5-71dd-dcace1613ee5@ideasonboard.com>\n\t\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 0/5] Remove Raspberry Pi logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]