{"id":10874,"url":"https://patchwork.libcamera.org/api/covers/10874/?format=json","web_url":"https://patchwork.libcamera.org/cover/10874/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210116114805.905397-1-niklas.soderlund@ragnatech.se>","date":"2021-01-16T11:47:57","name":"[libcamera-devel,v5,0/8] libcamera: Add helper for controls that take effect with a delay","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"mbox":"https://patchwork.libcamera.org/cover/10874/mbox/","series":[{"id":1579,"url":"https://patchwork.libcamera.org/api/series/1579/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1579","date":"2021-01-16T11:47:57","name":"libcamera: Add helper for controls that take effect with a delay","version":5,"mbox":"https://patchwork.libcamera.org/series/1579/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/10874/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0D89ABD808\n\tfor ;\n\tSat, 16 Jan 2021 11:48:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A01668107;\n\tSat, 16 Jan 2021 12:48:16 +0100 (CET)","from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F036760109\n\tfor ;\n\tSat, 16 Jan 2021 12:48:14 +0100 (CET)","from bismarck.berto.se (p4fca2458.dip0.t-ipconnect.de\n\t[79.202.36.88])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid b4e19002-57f0-11eb-a076-005056917f90;\n\tSat, 16 Jan 2021 12:48:13 +0100 (CET)"],"X-Halon-ID":"b4e19002-57f0-11eb-a076-005056917f90","Authorized-sender":"niklas.soderlund@fsdn.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 16 Jan 2021 12:47:57 +0100","Message-Id":"<20210116114805.905397-1-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.30.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 0/8] libcamera: Add helper for controls\n\tthat take effect with a delay","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThis series adds a new helper class to libcamera-core based on the\nStaggerdCtrl principle from the Raspberry Pi pipeline handler. The new\nhelper matches perfectly the RPi implementation and can therefore\nreplace the pipeline specific implementation. There are slight changes\nin the API of the two but noting preventing it to be a drop in\nreplacement.\n\nThe major new addition to the DelayedControls implementation is the\nability to queue controls ahead of time. This allows the concept of\npipeline depth we already have for buffers to be extended to controls.\n\nPatch 1/8 and 2/8 adds the new core helper and its unit test. Patch 3/8\nand 4/8 replaces StaggerdCtrl with DelayedControls in the Raspberry Pi\npipeline handler. Patch 5/8 adds an accessors to CameraSensor. And last\n6/8 - 8/8 make use of the new helper in the RkISP1 pipeline to\ncompletely remove another local helper (Timeline).\n\nThe RkISP1 IPA feels much snappier after this change but this is\nanecdotal and no real measurements have been done as the RkISP1 IPA at\nthis stage is neither advanced nor tuned.\n\nNiklas Söderlund (8):\n libcamera: delayed_controls: Add helper for controls that apply with a\n delay\n test: delayed_controls: Add test case for DelayedControls\n libcamera: raspberrypi: Switch to DelayedControls\n libcamera: raspberrypi: Remove StaggeredCtrl\n libcamera: camera_sensor: Expose the camera device\n libcamera: pipeline: rkisp1: Use delayed controls\n libcamera: pipeline: rkisp1: Use SOF event to warn about late\n parameters\n libcamera: pipeline: rkisp1: Remove Timeline\n\n include/libcamera/internal/camera_sensor.h | 2 +\n include/libcamera/internal/delayed_controls.h | 81 +++++\n include/libcamera/internal/meson.build | 1 +\n include/libcamera/ipa/raspberrypi.h | 2 +-\n src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n src/libcamera/camera_sensor.cpp | 7 +\n src/libcamera/delayed_controls.cpp | 247 +++++++++++++++\n src/libcamera/meson.build | 1 +\n .../pipeline/raspberrypi/meson.build | 1 -\n .../pipeline/raspberrypi/raspberrypi.cpp | 57 ++--\n .../pipeline/raspberrypi/staggered_ctrl.cpp | 174 ----------\n .../pipeline/raspberrypi/staggered_ctrl.h | 96 ------\n src/libcamera/pipeline/rkisp1/meson.build | 1 -\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 166 +++-------\n src/libcamera/pipeline/rkisp1/timeline.cpp | 227 -------------\n src/libcamera/pipeline/rkisp1/timeline.h | 71 -----\n test/delayed_contols.cpp | 297 ++++++++++++++++++\n test/meson.build | 1 +\n 18 files changed, 711 insertions(+), 723 deletions(-)\n create mode 100644 include/libcamera/internal/delayed_controls.h\n create mode 100644 src/libcamera/delayed_controls.cpp\n delete mode 100644 src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n delete mode 100644 src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\n delete mode 100644 src/libcamera/pipeline/rkisp1/timeline.cpp\n delete mode 100644 src/libcamera/pipeline/rkisp1/timeline.h\n create mode 100644 test/delayed_contols.cpp"}