[{"id":14524,"web_url":"https://patchwork.libcamera.org/comment/14524/","msgid":"","date":"2021-01-11T13:43:24","subject":"Re: [libcamera-devel] [PATCH v11 0/3] raspberrypi: FPS control","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nGentle ping to see if this can be finalised.\n\nMany thanks,\nNaush\n\n\nOn Wed, 6 Jan 2021 at 10:07, Naushir Patuck wrote:\n\n> Hi all,\n>\n> Here is the next iteration of the FPS control patchset. This version has\n> all the various nits fixed:\n>\n> - Clip -> Clamp in a comment.\n> - Member definitions on separate lines to match the rest of the file.\n> - Ensure we handle the case where minFrameDuration > maxFrameDuration\n> without breaking.\n> - Expanded wording in the commit message for 3/3.\n>\n> The documentation for frameDurations control has been updated as well.\n> I've included a line about resetting to default values, together with a\n> todo to rationalise this as well as for other controls. Also simplified\n> the text surrounding metadata return values.\n>\n> Many thanks,\n> Naush\n>\n> Naushir Patuck (3):\n> libcamera: controls: Add frame duration control\n> libcamera: raspberrypi: Add control of sensor vblanking\n> ipa: raspberrypi: config: Update shutter speeds for imx219/477 and\n> ov5647\n>\n> include/libcamera/ipa/raspberrypi.h | 1 +\n> src/ipa/raspberrypi/cam_helper.cpp | 35 +++++++++++-\n> src/ipa/raspberrypi/cam_helper.hpp | 15 ++++-\n> src/ipa/raspberrypi/cam_helper_imx219.cpp | 13 ++++-\n> src/ipa/raspberrypi/cam_helper_imx477.cpp | 11 +++-\n> src/ipa/raspberrypi/cam_helper_ov5647.cpp | 11 +++-\n> src/ipa/raspberrypi/data/imx219.json | 15 ++++-\n> src/ipa/raspberrypi/data/imx477.json | 15 ++++-\n> src/ipa/raspberrypi/data/ov5647.json | 15 ++++-\n> src/ipa/raspberrypi/raspberrypi.cpp | 56 ++++++++++++++++---\n> src/libcamera/control_ids.yaml | 38 +++++++++++++\n> .../pipeline/raspberrypi/raspberrypi.cpp | 3 +-\n> 12 files changed, 207 insertions(+), 21 deletions(-)\n>\n> --\n> 2.25.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0480FBD80C\n\tfor ;\n\tMon, 11 Jan 2021 13:43:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C02B680B5;\n\tMon, 11 Jan 2021 14:43:43 +0100 (CET)","from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A31336010E\n\tfor ;\n\tMon, 11 Jan 2021 14:43:41 +0100 (CET)","by mail-lj1-x22b.google.com with SMTP id w26so3442410ljo.4\n\tfor ;\n\tMon, 11 Jan 2021 05:43:41 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"QiCaq8ed\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=AeD1VgSkhHBLbNW0o/MAR8pV3qPDMr+qhy9eOcN9F1o=;\n\tb=QiCaq8edYVRfaZOV4TjGg/nexxhy7axYKXAoA5H9H7jOMBWqqQ2FaKhnIAztpWOrZ7\n\tvm2w0M0K9Tw+Iftvl+A8Dls0KJ2UG7kjGC0ZbKASEWc9M13lYRmb0IXoEIby1tn3rXmT\n\tamhcU7PbYQpf2xZJAKLW2sDL9TFVifmOMlV5W0dui4edtRmpVU3Qx4mkN6+F4ozb8FWV\n\tBidspGADdZw2QNp5vejfN/Doj3xA+syfNcrnGCWLJRQWr3ZXlmhFZlez5YqZAraZzksx\n\tGssoBRk06GKVqGvfIxghQSMWzyPSjJYCJ5YvBxHmycDyu2cyM0U1GHUFaN+/r/0BhlbH\n\ttpqw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=AeD1VgSkhHBLbNW0o/MAR8pV3qPDMr+qhy9eOcN9F1o=;\n\tb=TclgHxbXR0UI0irgmF7HRmOh+xiUnbhoXqcYC4yGc9B+U3jFK47eLNWJ/0HYM/Cnb9\n\tkMDIsGGIfaUVL+e6i7+DULxLx4j7RbO73Zg8AYVODuNCxW9JeZS+919I1gM+gVe/zBxr\n\tTs0KOw/8Ver6PfEkO1JowR9Ne6V+bxK3La3Z6ywJskwj+46mlURkyIZ6qLD3zSln2c85\n\tEuKvcKwU4DqrJfV53rLrHqgd+UB+W4ynY4JC6IWT/MtD4bUJCPE9D1BjKIrft5+fJgLI\n\twUirCCJ3h0mBZdxOdhwWu3SKZiJDTGfDrCTV1PEJVxrDR1z5vVqiMzgG8OOXGJrFuINr\n\tV7bg==","X-Gm-Message-State":"AOAM533zdul8kB51sR3RKOdK7ClyzJTVCI6tVM7wip2lMZuD+Yk/WanV\n\tcDfCucOykqqEtS0qd5Z8jei3JqkK0eg0x+g/F4k1oGrGhuM=","X-Google-Smtp-Source":"ABdhPJyYyBtM67At+fq1rm4nr5xP3zFpGyCxTLm1xj/bOHSYHuX7WbVVXjeJZIhcw5bgprVmmwEUI5YzFKvrJoMHuMA=","X-Received":"by 2002:a2e:9b13:: with SMTP id u19mr7054383lji.48.1610372620723;\n\tMon, 11 Jan 2021 05:43:40 -0800 (PST)","MIME-Version":"1.0","References":"<20210106100659.8363-1-naush@raspberrypi.com>","In-Reply-To":"<20210106100659.8363-1-naush@raspberrypi.com>","From":"Naushir Patuck ","Date":"Mon, 11 Jan 2021 13:43:24 +0000","Message-ID":"","To":"libcamera devel ","Subject":"Re: [libcamera-devel] [PATCH v11 0/3] raspberrypi: FPS control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============5695755607359371601==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14531,"web_url":"https://patchwork.libcamera.org/comment/14531/","msgid":"","date":"2021-01-11T23:17:12","subject":"Re: [libcamera-devel] [PATCH v11 0/3] raspberrypi: FPS control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Mon, Jan 11, 2021 at 01:43:24PM +0000, Naushir Patuck wrote:\n> Hi all,\n> \n> Gentle ping to see if this can be finalised.\n\nI've finished reviewing the series. There's just one sentence in the\ndocumentation that I'm not sure to understand. If we can clarify this by\ne-mail there's no need to post a v12, I can apply the correction to the\npatch when pushing.\n\n> On Wed, 6 Jan 2021 at 10:07, Naushir Patuck wrote:\n> \n> > Hi all,\n> >\n> > Here is the next iteration of the FPS control patchset. This version has\n> > all the various nits fixed:\n> >\n> > - Clip -> Clamp in a comment.\n> > - Member definitions on separate lines to match the rest of the file.\n> > - Ensure we handle the case where minFrameDuration > maxFrameDuration\n> > without breaking.\n> > - Expanded wording in the commit message for 3/3.\n> >\n> > The documentation for frameDurations control has been updated as well.\n> > I've included a line about resetting to default values, together with a\n> > todo to rationalise this as well as for other controls. Also simplified\n> > the text surrounding metadata return values.\n> >\n> > Many thanks,\n> > Naush\n> >\n> > Naushir Patuck (3):\n> > libcamera: controls: Add frame duration control\n> > libcamera: raspberrypi: Add control of sensor vblanking\n> > ipa: raspberrypi: config: Update shutter speeds for imx219/477 and\n> > ov5647\n> >\n> > include/libcamera/ipa/raspberrypi.h | 1 +\n> > src/ipa/raspberrypi/cam_helper.cpp | 35 +++++++++++-\n> > src/ipa/raspberrypi/cam_helper.hpp | 15 ++++-\n> > src/ipa/raspberrypi/cam_helper_imx219.cpp | 13 ++++-\n> > src/ipa/raspberrypi/cam_helper_imx477.cpp | 11 +++-\n> > src/ipa/raspberrypi/cam_helper_ov5647.cpp | 11 +++-\n> > src/ipa/raspberrypi/data/imx219.json | 15 ++++-\n> > src/ipa/raspberrypi/data/imx477.json | 15 ++++-\n> > src/ipa/raspberrypi/data/ov5647.json | 15 ++++-\n> > src/ipa/raspberrypi/raspberrypi.cpp | 56 ++++++++++++++++---\n> > src/libcamera/control_ids.yaml | 38 +++++++++++++\n> > .../pipeline/raspberrypi/raspberrypi.cpp | 3 +-\n> > 12 files changed, 207 insertions(+), 21 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B1557BD808\n\tfor ;\n\tMon, 11 Jan 2021 23:17:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 480B9680C3;\n\tTue, 12 Jan 2021 00:17:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D470A60523\n\tfor ;\n\tTue, 12 Jan 2021 00:17:26 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5B8323E;\n\tTue, 12 Jan 2021 00:17:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"h5qI40pM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1610407046;\n\tbh=BTKvL4iUYP9CIYyD9xpbK9RvM+WLIYvh9z5ToyAqL2I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=h5qI40pMLur8kfiq9YilHuCMOU7QqG0AaI5iHHVay5lTepYpWYxndKBStu1fswhQ2\n\ttzffuBCemdHEV1hQ26iCOR4HZcpb8DpM3/81m8A/HQywvnxcwExv9R7CPNPIkggzn3\n\tBU2JyCbcB1EdgDQ2GMsMJVarpp40CxAC778lUd2g=","Date":"Tue, 12 Jan 2021 01:17:12 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20210106100659.8363-1-naush@raspberrypi.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v11 0/3] raspberrypi: FPS control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]