[{"id":14436,"web_url":"https://patchwork.libcamera.org/comment/14436/","msgid":"","date":"2021-01-04T13:11:16","subject":"Re: [libcamera-devel] [PATCH v4 0/6] libcamera: camera_sensor: Make\n\tvalidation more strict","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Thu, Dec 31, 2020 at 12:05:57AM +0100, Jacopo Mondi wrote:\n> It is my understanding that this series could be pushed if the UVC pipeline\n> handler is instrumented to report properties that cannot be read from the\n> kernel interface.\n\nThat should be a matter of adding the two pixel array properties, based\non the largest resolution reported by the device. It should hopefully be\nfairly simple. Could you add such a patch to the series ?\n\n> Jacopo Mondi (6):\n> libcamera: Document sensor driver requirements\n> libcamera: camera_sensor: Validate driver support\n> libcamera: camera_sensor: Cache selection targets\n> libcamera: camera_sensor: Default 'location' to External\n> libcamera: camera_sensor: Do not default 'rotation'\n> android: camera_device: Do not default pixel array properties\n> \n> Documentation/index.rst | 1 +\n> Documentation/meson.build | 1 +\n> Documentation/sensor_driver_requirements.rst | 64 ++++++++\n> include/libcamera/internal/camera_sensor.h | 4 +\n> src/android/camera_device.cpp | 20 +--\n> src/libcamera/camera_sensor.cpp | 158 +++++++++++++------\n> 6 files changed, 186 insertions(+), 62 deletions(-)\n> create mode 100644 Documentation/sensor_driver_requirements.rst","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B1B8DC0F1C\n\tfor ;\n\tMon, 4 Jan 2021 13:11:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 439FE62007;\n\tMon, 4 Jan 2021 14:11:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F2CC60110\n\tfor ;\n\tMon, 4 Jan 2021 14:11:30 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8D6662E0;\n\tMon, 4 Jan 2021 14:11:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"syb+pfYj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1609765889;\n\tbh=6GP2rk9Sm7gWO8IVrpktCQ1fOwNIpZqRj8dr856wIOg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=syb+pfYjS6iYP604M9wA3q19FzjzgQC7H6n6C/amPVHhmotyDuMnx+hxipzlMBV2G\n\tHJf1FegRhHmN9+CzUWSuj7oqUZfzyXKchMLBiSoD1nBPSYMFCXGe7uqFyu02tRUel8\n\tD2qc1SpoPieKpOwID2ak7STXUlpzCgXoVRtXmfM8=","Date":"Mon, 4 Jan 2021 15:11:16 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20201230230603.123486-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201230230603.123486-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v4 0/6] libcamera: camera_sensor: Make\n\tvalidation more strict","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]