{"id":10756,"url":"https://patchwork.libcamera.org/api/covers/10756/?format=json","web_url":"https://patchwork.libcamera.org/cover/10756/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201228165203.53771-1-jacopo@jmondi.org>","date":"2020-12-28T16:51:59","name":"[libcamera-devel,v3,0/4] libcamera: Introduce sensor database","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/cover/10756/mbox/","series":[{"id":1557,"url":"https://patchwork.libcamera.org/api/series/1557/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1557","date":"2020-12-28T16:51:59","name":"libcamera: Introduce sensor database","version":3,"mbox":"https://patchwork.libcamera.org/series/1557/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/10756/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C1F5C0F1B\n\tfor ;\n\tMon, 28 Dec 2020 16:51:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B1239615B4;\n\tMon, 28 Dec 2020 17:51:53 +0100 (CET)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16CC760111\n\tfor ;\n\tMon, 28 Dec 2020 17:51:53 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id BA8061C000A\n\tfor ;\n\tMon, 28 Dec 2020 16:51:52 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 28 Dec 2020 17:51:59 +0100","Message-Id":"<20201228165203.53771-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 0/4] libcamera: Introduce sensor\n\tdatabase","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello, this v3 redesigns the sensor database to:\n\n- use a custom structure to report properties in place of a ControlList\n - This allows dropping the controversial list-initialization contructor\n for the ControlList class\n\n- make SensorDatabase a static class to only interface with the sensor\n database which is now not exposed anymore to the rest of the library\n\n- use a plain C-style array for the sensor database\n Here, I struggled quite a lot to make everything a constexpr, not even being\n 100% sure it -really- makes a difference compared to static const declaration\n (the documentation I found gave me conflicting suggestions, or maybe I didn't\n fully get it :)\n\n So, I had a map as the database underlying structure. Making a map a constexpr\n would have required sub-classing it, and exposing only constexpr methods,\n which I considered not worth it. So I used an array of std::pair.\n Constructing pairs has its own peculiarities, and I managed to get it work\n with clang on my laptop, but failed to have it compile on cros (which uses\n clang, but an older version). I assumed this was an indication I was looking\n for troubles, as supporting all compilers in the build compilers matrix would\n have been complex, so I fell back to plain C-style array, which are easier but\n indeed less C++-ish than using an STL container. Also, we lose a bit of\n efficiency in lookups, but I don't expect this to happen in critical paths, and\n I don't expect to have thousands of sensors to support.\n\nSeries based on the two series I have in review (CFA and exposure times\ncalculations).\n\nThanks\n j\n\nJacopo Mondi (4):\n libcamera: Introduce camera sensor database\n libcamera: camera_sensor: Register static properties\n android: camera_device: Report sensor physical size\n android: camera_device: Align style of active area size\n\n include/libcamera/internal/camera_sensor.h | 1 +\n include/libcamera/internal/meson.build | 1 +\n include/libcamera/internal/sensor_database.h | 28 +++++\n src/android/camera_device.cpp | 49 +++++----\n src/libcamera/camera_sensor.cpp | 21 +++-\n src/libcamera/meson.build | 1 +\n src/libcamera/sensor_database.cpp | 102 +++++++++++++++++++\n 7 files changed, 180 insertions(+), 23 deletions(-)\n create mode 100644 include/libcamera/internal/sensor_database.h\n create mode 100644 src/libcamera/sensor_database.cpp\n\n--\n2.29.2"}