{"id":1065,"url":"https://patchwork.libcamera.org/api/covers/1065/?format=json","web_url":"https://patchwork.libcamera.org/cover/1065/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190418164638.400-1-jacopo@jmondi.org>","date":"2019-04-18T16:46:32","name":"[libcamera-devel,v6,0/6] libcamera: ipu3: Multiple streams support","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/cover/1065/mbox/","series":[{"id":259,"url":"https://patchwork.libcamera.org/api/series/259/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=259","date":"2019-04-18T16:46:32","name":"libcamera: ipu3: Multiple streams support","version":6,"mbox":"https://patchwork.libcamera.org/series/259/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/1065/comments/","headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2527D600F9\n\tfor ;\n\tThu, 18 Apr 2019 18:45:52 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 9A35D1C000B;\n\tThu, 18 Apr 2019 16:45:51 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 18 Apr 2019 18:46:32 +0200","Message-Id":"<20190418164638.400-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 0/6] libcamera: ipu3: Multiple streams\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 18 Apr 2019 16:45:52 -0000"},"content":"And here we are at version 6.\n\nSince v5 (this morning) a few things happened\n- framework changes that were part of v5 of this series got merged\n- RkISP1 support got merged\n\nThis series rebase v5 on top of latest master to introduce support for multiple\nstreams on IPU3 platform.\n\nQuoting the v5 cover letter, as the changelog between v4->v6 stays the same:\n\nI have included comments on v4 received from Laurent and Niklas and now the\npatches look much better, thanks you both for the comments.\n\nThe most relevant change is related to the long reply I gave to Niklas on v4's\n\"libcamera: ipu3: Queue requests for multiple streams\"\n\nThere I detailed how it was necessary to queue buffers to the 'output' node\nto have images processed by the ImgU and how I badly worked it around. We\nconcluded a kernel fix was needed to use dummy buffers in case no buffer has\nbeen made available from userspace. Well, I re-tested now, and it seems the\ndriver usese dummy buffers already, if the output node is \"enabled\" (aka the\nmedia link between it and the ImgU subdevice is active). With this current\nimplementation the 'output' node is active (as it was in v4, I cannot tell what\nchanged) and the driver uses dummy buffer, as I've verified enabling the\nipu3-imgu module debug output. For this reason the patch is greatly simplified\nand just simply queue buffers for the nodes part of the request.\n\nI have tested several stream combinations:\n- only viewfinder\n- only still capture\n- viewfinder + still capture\n- viewfinder + (viewfinder + still capture) every 10 frames (see patch 14/14)\n\nusing the cam application from the most recent master branch.\n\nPatches available at jmondi/imgu-multi-v6\n\nHopefully, we should be close to have this merged soon.\n\nThanks\n j\n\nJacopo Mondi (6):\n libcamera: ipu3: Create camera with 2 streams\n libcamera: ipu3: Add multiple stream memory management\n libcamera: ipu3: Queue requests for multiple streams\n libcamera: ipu3: Connect viewfinder's BufferReady signal\n libcamera: ipu3: Use roles in stream configuration\n [HACK] still capture every 10 frames\n\n src/cam/main.cpp | 46 +++-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 360 ++++++++++++++++++++-------\n 2 files changed, 308 insertions(+), 98 deletions(-)\n\n--\n2.21.0"}