[{"id":13964,"web_url":"https://patchwork.libcamera.org/comment/13964/","msgid":"","date":"2020-11-30T09:59:21","subject":"Re: [libcamera-devel] [PATCH v2 0/2] Digital gain control","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi everyone\n\nI was wondering if I could give this one its customary Monday morning nudge?\n\nI notice that there was still some question last week over whether\nmetadata (that's not allowed as a control) should be able to signal\nits maximum/minimum values. It doesn't really feel like an issue to me\n- I just report what the pipeline did, I'm not really seeing a need to\nreport what the pipeline *might* have done! Other than that, it seems\nwe were largely agreed...?\n\nThanks again!\nDavid\n\nOn Thu, 26 Nov 2020 at 14:50, David Plowman\n wrote:\n>\n> Hi everyone\n>\n> Here (after much talking ourselves in circles!) is a second version of\n> the digital gain control. I've taken Jacopo's text for the control\n> description, and added a second patch that makes use of the control in\n> the Raspberry Pi IPAs to add the digital gain to the metadata.\n>\n> This second patch doesn't really tell you very much. In our libcamera\n> version of raspistill (still image capture app) there will be a line\n> like this:\n>\n> iso *= metadata.get(controls::DigitalGain);\n>\n> and that's about it!\n>\n> Best regards\n> David\n>\n> David Plowman (2):\n> libcamera: controls: Add DigitalGain control\n> src: ipa: raspberrypi: Add digital gain to libcamera metadata\n>\n> src/ipa/raspberrypi/raspberrypi.cpp | 4 +++-\n> src/libcamera/control_ids.yaml | 17 +++++++++++++++++\n> 2 files changed, 20 insertions(+), 1 deletion(-)\n>\n> --\n> 2.20.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E44FBE176\n\tfor ;\n\tMon, 30 Nov 2020 09:59:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1A58363497;\n\tMon, 30 Nov 2020 10:59:36 +0100 (CET)","from mail-oo1-xc41.google.com (mail-oo1-xc41.google.com\n\t[IPv6:2607:f8b0:4864:20::c41])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 678CA6346B\n\tfor ;\n\tMon, 30 Nov 2020 10:59:34 +0100 (CET)","by mail-oo1-xc41.google.com with SMTP id w9so2468246ooh.13\n\tfor ;\n\tMon, 30 Nov 2020 01:59:34 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"mwg/Pde7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=//+VLXvLf9B6DOW3zWDSE7VNyfFkxqx1QhEfxHCFpyQ=;\n\tb=mwg/Pde7xJVNcRxu3gJ4y1JsXS5iO8tZbqDj3PtlNNZ+wwOlBMrR0ToM7ABvi3L3iE\n\t5bnocHYTWtefAL+t9nCJNokQWoJorevO+GOXTpVjbMfuPbhehqaNklUr0qIvxVwYTR0+\n\tlQvoHk+iIf08tQJ1vlnXXdbs43fg9l/zJ7tsY8iNTKM5NQY5c4twPUzK+LONe6Ef9pKB\n\tpWHWTLW8aIJa6YCT5YcP7XETrhmF/g6Hoo2yo7fmgG2fqcTjtXMUCsSUTxYOOA/PkF8J\n\tJnKO3Y0Ejxgd+AdOE/eDWx7nsKXoCZtckFJa+mqYp6DdiOpo/smzjKsDnlgRv9+kfxvH\n\tUqsA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=//+VLXvLf9B6DOW3zWDSE7VNyfFkxqx1QhEfxHCFpyQ=;\n\tb=IcJJpljQqDH6Ubm23FlWB7QUcEZZkOEs2Iq8sf1fqRx4e3I7p0Xn2/t1aoTqNvwurl\n\t1JYAcXdkzihP6tVtd/v+RxtmCEF0frwUzLZS4lSHTenGf4VnWFzkDt0ZigUAPLgLpmPg\n\tE4bJJJ33bZMp2Jp2zj5s9D49vsXbM0sT4qnW+x2vWMEmShr+S86UxsCzVAUH8w+l4/LG\n\ttfzisRh4q8w7jVEmhDptXMFoBbyRT8AR4vAxDH5rJUsgJMkWCM6YvnLwdXllF+SeEY9W\n\t8j14lXMlp74t+7OsxpaUXWaz3SoCFpyWgScpidbkLZiXUNV/7JXMq/10ebMb3ZjCekS2\n\tbXFw==","X-Gm-Message-State":"AOAM530jwM7hpb2CJMj8ZPZWbe8qxG6HJOwCdMnjp9dPLr4SxhTAuDWk\n\tM/xspSxXLvMwgF8A9Y2i8A6F9n22nDlt8TJzPVgcWUeUwzqCeA==","X-Google-Smtp-Source":"ABdhPJwnp+Wwi47hMWvw78VpO+vaqk/OeupbVv1q3NO6FXPUW+6s1/4s1xg2CMTR1NIN9ryISBoORBFQUZb0+WXv9Ds=","X-Received":"by 2002:a4a:e0ce:: with SMTP id\n\te14mr14381447oot.72.1606730372910; \n\tMon, 30 Nov 2020 01:59:32 -0800 (PST)","MIME-Version":"1.0","References":"<20201126145005.8838-1-david.plowman@raspberrypi.com>","In-Reply-To":"<20201126145005.8838-1-david.plowman@raspberrypi.com>","From":"David Plowman ","Date":"Mon, 30 Nov 2020 09:59:21 +0000","Message-ID":"","To":"libcamera devel ","Subject":"Re: [libcamera-devel] [PATCH v2 0/2] Digital gain control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13965,"web_url":"https://patchwork.libcamera.org/comment/13965/","msgid":"<20201130103012.lx4ldjepwj52yc6i@uno.localdomain>","date":"2020-11-30T10:30:12","subject":"Re: [libcamera-devel] [PATCH v2 0/2] Digital gain control","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi David,\n\nOn Mon, Nov 30, 2020 at 09:59:21AM +0000, David Plowman wrote:\n> Hi everyone\n>\n> I was wondering if I could give this one its customary Monday morning nudge?\n>\n> I notice that there was still some question last week over whether\n> metadata (that's not allowed as a control) should be able to signal\n> its maximum/minimum values. It doesn't really feel like an issue to me\n> - I just report what the pipeline did, I'm not really seeing a need to\n> report what the pipeline *might* have done! Other than that, it seems\n> we were largely agreed...?\n\nMy question on the metadata min-max was mostly to plan ahead if we\never need to expose the metadata limits from the Camera API, something\nwe currently don't have.\n\nNot something to block this patch on.\n\nI see the patch itself has my tags only. I would wait for an explicit\nack from Laurent then merge it.\n\nThanks\n j\n\n>\n> Thanks again!\n> David\n>\n> On Thu, 26 Nov 2020 at 14:50, David Plowman\n> wrote:\n> >\n> > Hi everyone\n> >\n> > Here (after much talking ourselves in circles!) is a second version of\n> > the digital gain control. I've taken Jacopo's text for the control\n> > description, and added a second patch that makes use of the control in\n> > the Raspberry Pi IPAs to add the digital gain to the metadata.\n> >\n> > This second patch doesn't really tell you very much. In our libcamera\n> > version of raspistill (still image capture app) there will be a line\n> > like this:\n> >\n> > iso *= metadata.get(controls::DigitalGain);\n> >\n> > and that's about it!\n> >\n> > Best regards\n> > David\n> >\n> > David Plowman (2):\n> > libcamera: controls: Add DigitalGain control\n> > src: ipa: raspberrypi: Add digital gain to libcamera metadata\n> >\n> > src/ipa/raspberrypi/raspberrypi.cpp | 4 +++-\n> > src/libcamera/control_ids.yaml | 17 +++++++++++++++++\n> > 2 files changed, 20 insertions(+), 1 deletion(-)\n> >\n> > --\n> > 2.20.1\n> >\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F671BE177\n\tfor ;\n\tMon, 30 Nov 2020 10:30:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A1A2B63497;\n\tMon, 30 Nov 2020 11:30:07 +0100 (CET)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 497DB6346B\n\tfor ;\n\tMon, 30 Nov 2020 11:30:06 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 885861C000E;\n\tMon, 30 Nov 2020 10:30:05 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Mon, 30 Nov 2020 11:30:12 +0100","From":"Jacopo Mondi ","To":"David Plowman ,\n\tLaurent Pinchart ","Message-ID":"<20201130103012.lx4ldjepwj52yc6i@uno.localdomain>","References":"<20201126145005.8838-1-david.plowman@raspberrypi.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 0/2] Digital gain control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14096,"web_url":"https://patchwork.libcamera.org/comment/14096/","msgid":"","date":"2020-12-07T08:58:09","subject":"Re: [libcamera-devel] [PATCH v2 0/2] Digital gain control","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi everyone\n\nI think you can guess what I might be about to say.... :)\n\nSo this is just my little weekly nudge to see where we are with this.\nWe were having some discussions about the pipeline model as a whole,\nas I recall, though I don't think we were wanting to block these\npatches. But please let me know what you think!\n\nThanks and sorry for being a nuisance...\nDavid\n\nOn Mon, 30 Nov 2020 at 10:30, Jacopo Mondi wrote:\n>\n> Hi David,\n>\n> On Mon, Nov 30, 2020 at 09:59:21AM +0000, David Plowman wrote:\n> > Hi everyone\n> >\n> > I was wondering if I could give this one its customary Monday morning nudge?\n> >\n> > I notice that there was still some question last week over whether\n> > metadata (that's not allowed as a control) should be able to signal\n> > its maximum/minimum values. It doesn't really feel like an issue to me\n> > - I just report what the pipeline did, I'm not really seeing a need to\n> > report what the pipeline *might* have done! Other than that, it seems\n> > we were largely agreed...?\n>\n> My question on the metadata min-max was mostly to plan ahead if we\n> ever need to expose the metadata limits from the Camera API, something\n> we currently don't have.\n>\n> Not something to block this patch on.\n>\n> I see the patch itself has my tags only. I would wait for an explicit\n> ack from Laurent then merge it.\n>\n> Thanks\n> j\n>\n> >\n> > Thanks again!\n> > David\n> >\n> > On Thu, 26 Nov 2020 at 14:50, David Plowman\n> > wrote:\n> > >\n> > > Hi everyone\n> > >\n> > > Here (after much talking ourselves in circles!) is a second version of\n> > > the digital gain control. I've taken Jacopo's text for the control\n> > > description, and added a second patch that makes use of the control in\n> > > the Raspberry Pi IPAs to add the digital gain to the metadata.\n> > >\n> > > This second patch doesn't really tell you very much. In our libcamera\n> > > version of raspistill (still image capture app) there will be a line\n> > > like this:\n> > >\n> > > iso *= metadata.get(controls::DigitalGain);\n> > >\n> > > and that's about it!\n> > >\n> > > Best regards\n> > > David\n> > >\n> > > David Plowman (2):\n> > > libcamera: controls: Add DigitalGain control\n> > > src: ipa: raspberrypi: Add digital gain to libcamera metadata\n> > >\n> > > src/ipa/raspberrypi/raspberrypi.cpp | 4 +++-\n> > > src/libcamera/control_ids.yaml | 17 +++++++++++++++++\n> > > 2 files changed, 20 insertions(+), 1 deletion(-)\n> > >\n> > > --\n> > > 2.20.1\n> > >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D216BDB1F\n\tfor ;\n\tMon, 7 Dec 2020 10:48:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E22E67E14;\n\tMon, 7 Dec 2020 11:48:17 +0100 (CET)","from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com\n\t[IPv6:2607:f8b0:4864:20::b34])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E67567E12\n\tfor ;\n\tMon, 7 Dec 2020 11:48:15 +0100 (CET)","by mail-yb1-xb34.google.com with SMTP id k78so3630355ybf.12\n\tfor ;\n\tMon, 07 Dec 2020 02:48:15 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"JlxZeZxa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=D4PRm5CStxoU1uYKVRDtMOjpN4udYk5IA3r7R3PElX0=;\n\tb=JlxZeZxaEl3stgXv/QHv2v7cpmMX+1oLwFIP6VQN3Sf5nLTji7uFPyDUrif16hDiNg\n\t3uOvhcCVVhgdas6BBanoxJ2v7pKXFpZy7F8Zpfp4BKnE4A0OQVSfdZkET9IxBwuJSN+9\n\tC5wecN84ECGWy81nKpPSHgiQlO20aPwPsPWZOEqns7W1kdzcXpj6RZUir5QSRPXbbH3t\n\ttd6zshJ/nVfB9jj9Mq3Q4BSxBwXEXhi1SZ6RWEYXvC3XCIiJB5yzXOn4T6fcbp3drAdu\n\t5vDBEyKvwZPbTXxg8IoETFW17En3+pw+w2LLZ7Di8w0gg5ACuUea/PDJpux7uCQtiFhj\n\tY+kQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=D4PRm5CStxoU1uYKVRDtMOjpN4udYk5IA3r7R3PElX0=;\n\tb=E1XjxplUW6j77LxqnQyo1typ355qGyL0yC+WfOUnReEd9wPisGWVnMbNGAS/2nw7Hl\n\takOWQxymzBtrWj4dO+A32Jd14B9elnoEYaIb4iIHOh2q/rOO/3YVIrABSpltErkkbfmp\n\tuceIb3rw+2hE3sa7AiQ2GsQiKtn2zRN7pk5XYydwDsFuGZiNdp3i+w8PGYi5b0LCTgYF\n\t5eewbs7f8HxmwFc5Dz+6kGVvNq9+qNj6XNKPKcXOmGkuZj+1KMqejgLRx8sw9zl5uiq6\n\tmM2azi8mrOop+uS7NHWjlQN3CwE7ne0pdCPvTk9SO9l9ntPqg9wJNbcO4rijn0lZps84\n\tqqxQ==","X-Gm-Message-State":"AOAM5312rFqsa15npA/UFcxO/DRGr2bvvTTaf4jIZuq3iQakabkwkO8T\n\ttk6J88ngzauDz9JsJkA6yG45i4kxA38ANQYlm4FGecNNv/I23g==","X-Google-Smtp-Source":"ABdhPJwzqN/h7CbvD0zDOt/oq7cGbCjUfXfJnBlv9gzx6c3S+2ajzV0PXp32FpfMgHe2+zuTH52vApaqqGKwucn+Qf4=","X-Received":"by 2002:a05:6830:18ee:: with SMTP id\n\td14mr11756571otf.317.1607331500206; \n\tMon, 07 Dec 2020 00:58:20 -0800 (PST)","MIME-Version":"1.0","References":"<20201126145005.8838-1-david.plowman@raspberrypi.com>\n\t\n\t<20201130103012.lx4ldjepwj52yc6i@uno.localdomain>","In-Reply-To":"<20201130103012.lx4ldjepwj52yc6i@uno.localdomain>","From":"David Plowman ","Date":"Mon, 7 Dec 2020 08:58:09 +0000","Message-ID":"","To":"Jacopo Mondi ","Subject":"Re: [libcamera-devel] [PATCH v2 0/2] Digital gain control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14242,"web_url":"https://patchwork.libcamera.org/comment/14242/","msgid":"","date":"2020-12-14T10:34:48","subject":"Re: [libcamera-devel] [PATCH v2 0/2] Digital gain control","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi everyone\n\nThanks for all the reviews and merging that happened towards the end\nof last week. I think we're getting really close now! So I wondered if\nI might be able to give this little patch a final nudge over the\nline...?\n\nThanks and best regards\nDavid\n\nOn Mon, 7 Dec 2020 at 08:58, David Plowman\n wrote:\n>\n> Hi everyone\n>\n> I think you can guess what I might be about to say.... :)\n>\n> So this is just my little weekly nudge to see where we are with this.\n> We were having some discussions about the pipeline model as a whole,\n> as I recall, though I don't think we were wanting to block these\n> patches. But please let me know what you think!\n>\n> Thanks and sorry for being a nuisance...\n> David\n>\n> On Mon, 30 Nov 2020 at 10:30, Jacopo Mondi wrote:\n> >\n> > Hi David,\n> >\n> > On Mon, Nov 30, 2020 at 09:59:21AM +0000, David Plowman wrote:\n> > > Hi everyone\n> > >\n> > > I was wondering if I could give this one its customary Monday morning nudge?\n> > >\n> > > I notice that there was still some question last week over whether\n> > > metadata (that's not allowed as a control) should be able to signal\n> > > its maximum/minimum values. It doesn't really feel like an issue to me\n> > > - I just report what the pipeline did, I'm not really seeing a need to\n> > > report what the pipeline *might* have done! Other than that, it seems\n> > > we were largely agreed...?\n> >\n> > My question on the metadata min-max was mostly to plan ahead if we\n> > ever need to expose the metadata limits from the Camera API, something\n> > we currently don't have.\n> >\n> > Not something to block this patch on.\n> >\n> > I see the patch itself has my tags only. I would wait for an explicit\n> > ack from Laurent then merge it.\n> >\n> > Thanks\n> > j\n> >\n> > >\n> > > Thanks again!\n> > > David\n> > >\n> > > On Thu, 26 Nov 2020 at 14:50, David Plowman\n> > > wrote:\n> > > >\n> > > > Hi everyone\n> > > >\n> > > > Here (after much talking ourselves in circles!) is a second version of\n> > > > the digital gain control. I've taken Jacopo's text for the control\n> > > > description, and added a second patch that makes use of the control in\n> > > > the Raspberry Pi IPAs to add the digital gain to the metadata.\n> > > >\n> > > > This second patch doesn't really tell you very much. In our libcamera\n> > > > version of raspistill (still image capture app) there will be a line\n> > > > like this:\n> > > >\n> > > > iso *= metadata.get(controls::DigitalGain);\n> > > >\n> > > > and that's about it!\n> > > >\n> > > > Best regards\n> > > > David\n> > > >\n> > > > David Plowman (2):\n> > > > libcamera: controls: Add DigitalGain control\n> > > > src: ipa: raspberrypi: Add digital gain to libcamera metadata\n> > > >\n> > > > src/ipa/raspberrypi/raspberrypi.cpp | 4 +++-\n> > > > src/libcamera/control_ids.yaml | 17 +++++++++++++++++\n> > > > 2 files changed, 20 insertions(+), 1 deletion(-)\n> > > >\n> > > > --\n> > > > 2.20.1\n> > > >\n> > > _______________________________________________\n> > > libcamera-devel mailing list\n> > > libcamera-devel@lists.libcamera.org\n> > > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78CA4C0F1A\n\tfor ;\n\tMon, 14 Dec 2020 10:35:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 051A06158D;\n\tMon, 14 Dec 2020 11:35:03 +0100 (CET)","from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com\n\t[IPv6:2607:f8b0:4864:20::22a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C2F160327\n\tfor ;\n\tMon, 14 Dec 2020 11:35:01 +0100 (CET)","by mail-oi1-x22a.google.com with SMTP id q205so5947059oig.13\n\tfor ;\n\tMon, 14 Dec 2020 02:35:01 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"M2nhKmbS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=5qTK7FEZxj6hAXuecN211G3VK/8jtZlBl2yk9OSR6Nc=;\n\tb=M2nhKmbSihUM/Uqn/BQ6cIjJpGAPFMV5WskOCNnFDWCDg6K3QrhutWu1mpG758vyve\n\tUtWFnOmZ8fiW8jR1K/+WlTXbtb6sOeUchdynyS2TUpPHacbh4j7FZFIzXXemBbldC+Y1\n\trBKuK1fKJSpwdfMoq7tl1twJTRzWyMPl4QEOUanlaJ/mkTT9mV6eLKimMg7aZdZAqNc7\n\t8HwasuxEk81oGPvoDiWcE8QrrbzLF0X1Gz1Kxa+FjLKqNt0yTUeG1mstdVgU2IWhxMBJ\n\tvzGUOMN15XZlIb1vvGlG5u76JcAz+KF9LNdmN5bWj9nFdQx/5GpFigr4+E4uwQeEBWw6\n\tKRbw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=5qTK7FEZxj6hAXuecN211G3VK/8jtZlBl2yk9OSR6Nc=;\n\tb=NCJSYoLknGuesvvAuXcrbDvbQbfnpDIcpvlqEYPArHcUYj8o9MgEyQj833wK1aIlLQ\n\tEzR/c5YtNPcLj8eKb0+ay7xDk5/ONg6qa3FhUvP9T5kYM4NW7wU6H+fnOgckZ9Cvg+Qt\n\t+Hui4KjiRNwRykjQt6X4v+LIcfIQ9ia66SNN0x70wLesYW17Ww9S93wIfPUySn523oSB\n\tISFp+XleBTejkAS4rVsCoOCaCm/MANzHk5K427Atk4f9TALOcVURhd8CTMMEia9UXTXO\n\tM9kOcj6HeQv+FfQMRosHENaGxy2xmYpIVx+aSoBq7gvdw+QNv7hjWbuP5XPDkx4uelvj\n\tmM/Q==","X-Gm-Message-State":"AOAM531Thk2vEGHZMC7y63jTKtFV9eAh4F6iSDc83jmsOj8c6gijIq/x\n\tEQ0EpJ4hm/lPVfpdRIvtWGZInpgagghqC19tiFEelNCrgj5eVw==","X-Google-Smtp-Source":"ABdhPJxvwZv4PGrib5GMutF3P4el33UCZqP5ckwwI/pYgC5cY4R97xWbnq0m5RMWz76cP96VqDGMrs5v2/S8rTFVfcQ=","X-Received":"by 2002:aca:4dc3:: with SMTP id\n\ta186mr17123503oib.107.1607942100111; \n\tMon, 14 Dec 2020 02:35:00 -0800 (PST)","MIME-Version":"1.0","References":"<20201126145005.8838-1-david.plowman@raspberrypi.com>\n\t\n\t<20201130103012.lx4ldjepwj52yc6i@uno.localdomain>\n\t","In-Reply-To":"","From":"David Plowman ","Date":"Mon, 14 Dec 2020 10:34:48 +0000","Message-ID":"","To":"Jacopo Mondi ","Subject":"Re: [libcamera-devel] [PATCH v2 0/2] Digital gain control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14249,"web_url":"https://patchwork.libcamera.org/comment/14249/","msgid":"","date":"2020-12-15T04:58:42","subject":"Re: [libcamera-devel] [PATCH v2 0/2] Digital gain control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nOn Mon, Dec 14, 2020 at 10:34:48AM +0000, David Plowman wrote:\n> Hi everyone\n> \n> Thanks for all the reviews and merging that happened towards the end\n> of last week. I think we're getting really close now! So I wondered if\n> I might be able to give this little patch a final nudge over the\n> line...?\n\nAbsolutely. Now that the other patches have gone in, it's on top of my\nreview todo list, with Naush's frame rate series. Feel free to let me\nknow which one I should handle first, otherwise I'll start with this\none.\n\n> On Mon, 7 Dec 2020 at 08:58, David Plowman wrote:\n> >\n> > Hi everyone\n> >\n> > I think you can guess what I might be about to say.... :)\n> >\n> > So this is just my little weekly nudge to see where we are with this.\n> > We were having some discussions about the pipeline model as a whole,\n> > as I recall, though I don't think we were wanting to block these\n> > patches. But please let me know what you think!\n> >\n> > Thanks and sorry for being a nuisance...\n> > David\n> >\n> > On Mon, 30 Nov 2020 at 10:30, Jacopo Mondi wrote:\n> > > On Mon, Nov 30, 2020 at 09:59:21AM +0000, David Plowman wrote:\n> > > > Hi everyone\n> > > >\n> > > > I was wondering if I could give this one its customary Monday morning nudge?\n> > > >\n> > > > I notice that there was still some question last week over whether\n> > > > metadata (that's not allowed as a control) should be able to signal\n> > > > its maximum/minimum values. It doesn't really feel like an issue to me\n> > > > - I just report what the pipeline did, I'm not really seeing a need to\n> > > > report what the pipeline *might* have done! Other than that, it seems\n> > > > we were largely agreed...?\n> > >\n> > > My question on the metadata min-max was mostly to plan ahead if we\n> > > ever need to expose the metadata limits from the Camera API, something\n> > > we currently don't have.\n> > >\n> > > Not something to block this patch on.\n> > >\n> > > I see the patch itself has my tags only. I would wait for an explicit\n> > > ack from Laurent then merge it.\n> > >\n> > > > On Thu, 26 Nov 2020 at 14:50, David Plowman wrote:\n> > > > >\n> > > > > Hi everyone\n> > > > >\n> > > > > Here (after much talking ourselves in circles!) is a second version of\n> > > > > the digital gain control. I've taken Jacopo's text for the control\n> > > > > description, and added a second patch that makes use of the control in\n> > > > > the Raspberry Pi IPAs to add the digital gain to the metadata.\n> > > > >\n> > > > > This second patch doesn't really tell you very much. In our libcamera\n> > > > > version of raspistill (still image capture app) there will be a line\n> > > > > like this:\n> > > > >\n> > > > > iso *= metadata.get(controls::DigitalGain);\n> > > > >\n> > > > > and that's about it!\n> > > > >\n> > > > > Best regards\n> > > > > David\n> > > > >\n> > > > > David Plowman (2):\n> > > > > libcamera: controls: Add DigitalGain control\n> > > > > src: ipa: raspberrypi: Add digital gain to libcamera metadata\n> > > > >\n> > > > > src/ipa/raspberrypi/raspberrypi.cpp | 4 +++-\n> > > > > src/libcamera/control_ids.yaml | 17 +++++++++++++++++\n> > > > > 2 files changed, 20 insertions(+), 1 deletion(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4105BD80A\n\tfor ;\n\tTue, 15 Dec 2020 04:58:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E7726158C;\n\tTue, 15 Dec 2020 05:58:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B9F76052C\n\tfor ;\n\tTue, 15 Dec 2020 05:58:49 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 72C8E96;\n\tTue, 15 Dec 2020 05:58:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QNqLToIQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608008328;\n\tbh=ZC3VGy/Iuky0iZ0qsf93CH00ze1aYDMXPN5VOnXCz4Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QNqLToIQCk2IGdD+TbVRAAiEUtPAGwkwTnRfv3rXABGt5T4v9gNQmu8QLwjBny9j6\n\tPqfOsGYXtnqjIPWkOg6ufTu8PNT7zTL5KkuuWnDOO51M1Fvl51xZSkw7dAovVy18wL\n\tnMRQfz0PFEs52V59ACb7g3dbSUpkS7lHw4Lq751U=","Date":"Tue, 15 Dec 2020 06:58:42 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20201126145005.8838-1-david.plowman@raspberrypi.com>\n\t\n\t<20201130103012.lx4ldjepwj52yc6i@uno.localdomain>\n\t\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 0/2] Digital gain control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14250,"web_url":"https://patchwork.libcamera.org/comment/14250/","msgid":"","date":"2020-12-15T08:37:43","subject":"Re: [libcamera-devel] [PATCH v2 0/2] Digital gain control","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Laurent\n\nOn Tue, 15 Dec 2020 at 04:58, Laurent Pinchart\n wrote:\n>\n> Hi David,\n>\n> On Mon, Dec 14, 2020 at 10:34:48AM +0000, David Plowman wrote:\n> > Hi everyone\n> >\n> > Thanks for all the reviews and merging that happened towards the end\n> > of last week. I think we're getting really close now! So I wondered if\n> > I might be able to give this little patch a final nudge over the\n> > line...?\n>\n> Absolutely. Now that the other patches have gone in, it's on top of my\n> review todo list, with Naush's frame rate series. Feel free to let me\n> know which one I should handle first, otherwise I'll start with this\n> one.\n\nGreat, thank you very much. These are the final two that I think we\nfeel we need before letting users try our applications. I don't think\nI have any preference on the order, the digital gain one first is\nfine!\n\nThanks and best regards\nDavid\n\n>\n> > On Mon, 7 Dec 2020 at 08:58, David Plowman wrote:\n> > >\n> > > Hi everyone\n> > >\n> > > I think you can guess what I might be about to say.... :)\n> > >\n> > > So this is just my little weekly nudge to see where we are with this.\n> > > We were having some discussions about the pipeline model as a whole,\n> > > as I recall, though I don't think we were wanting to block these\n> > > patches. But please let me know what you think!\n> > >\n> > > Thanks and sorry for being a nuisance...\n> > > David\n> > >\n> > > On Mon, 30 Nov 2020 at 10:30, Jacopo Mondi wrote:\n> > > > On Mon, Nov 30, 2020 at 09:59:21AM +0000, David Plowman wrote:\n> > > > > Hi everyone\n> > > > >\n> > > > > I was wondering if I could give this one its customary Monday morning nudge?\n> > > > >\n> > > > > I notice that there was still some question last week over whether\n> > > > > metadata (that's not allowed as a control) should be able to signal\n> > > > > its maximum/minimum values. It doesn't really feel like an issue to me\n> > > > > - I just report what the pipeline did, I'm not really seeing a need to\n> > > > > report what the pipeline *might* have done! Other than that, it seems\n> > > > > we were largely agreed...?\n> > > >\n> > > > My question on the metadata min-max was mostly to plan ahead if we\n> > > > ever need to expose the metadata limits from the Camera API, something\n> > > > we currently don't have.\n> > > >\n> > > > Not something to block this patch on.\n> > > >\n> > > > I see the patch itself has my tags only. I would wait for an explicit\n> > > > ack from Laurent then merge it.\n> > > >\n> > > > > On Thu, 26 Nov 2020 at 14:50, David Plowman wrote:\n> > > > > >\n> > > > > > Hi everyone\n> > > > > >\n> > > > > > Here (after much talking ourselves in circles!) is a second version of\n> > > > > > the digital gain control. I've taken Jacopo's text for the control\n> > > > > > description, and added a second patch that makes use of the control in\n> > > > > > the Raspberry Pi IPAs to add the digital gain to the metadata.\n> > > > > >\n> > > > > > This second patch doesn't really tell you very much. In our libcamera\n> > > > > > version of raspistill (still image capture app) there will be a line\n> > > > > > like this:\n> > > > > >\n> > > > > > iso *= metadata.get(controls::DigitalGain);\n> > > > > >\n> > > > > > and that's about it!\n> > > > > >\n> > > > > > Best regards\n> > > > > > David\n> > > > > >\n> > > > > > David Plowman (2):\n> > > > > > libcamera: controls: Add DigitalGain control\n> > > > > > src: ipa: raspberrypi: Add digital gain to libcamera metadata\n> > > > > >\n> > > > > > src/ipa/raspberrypi/raspberrypi.cpp | 4 +++-\n> > > > > > src/libcamera/control_ids.yaml | 17 +++++++++++++++++\n> > > > > > 2 files changed, 20 insertions(+), 1 deletion(-)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7098BC0F1A\n\tfor ;\n\tTue, 15 Dec 2020 08:37:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 013A461589;\n\tTue, 15 Dec 2020 09:37:57 +0100 (CET)","from mail-oo1-xc43.google.com (mail-oo1-xc43.google.com\n\t[IPv6:2607:f8b0:4864:20::c43])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFDD3600FD\n\tfor ;\n\tTue, 15 Dec 2020 09:37:54 +0100 (CET)","by mail-oo1-xc43.google.com with SMTP id x23so1439172oop.1\n\tfor ;\n\tTue, 15 Dec 2020 00:37:54 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"I7jiRwwU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=6OJV2DxVxTR4iVXZp4EqmaqRNuDrsacbLvZPLpSQccU=;\n\tb=I7jiRwwUstQX2td9/AS3Bh5CS8o3+9oTQL34FX9mCvqvnBFMWqY8NGZa9szyOWKuW1\n\tOpBn5YG5JBwmhsHSN8nFcTKVLjnP36KbA2/NR/6ra4d0XGgYybofUvQHem5GW+agKIM+\n\tgPKuCIWpTzUmnhi4fZytKOhiIIXVNqSTECn7sGwrqN1VNmiDnLmApKdtHcf8Ekc5Q2f5\n\twvltqWx7h3pkYLIFtrjBySjblwalZcwy1C9ud6apmzUhyGdwfCDY1PwdpTjKhPbFbrnv\n\tw4DF42L/JPKh9VzlnRaupQvtZpAk+uGOXGwtkx0gmQEx7Daf6AWxT6nl6+oeFQH61fBi\n\ts2eA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=6OJV2DxVxTR4iVXZp4EqmaqRNuDrsacbLvZPLpSQccU=;\n\tb=fZUEzNbpJHvwkbsi496ugp1z9ZwF6hJnxGmE9JDIkobK9bdUMFMZt3ErscpRhG3hkP\n\tDdIveMPZ4aP9zezXiuLrXnRcZ2UIqoBrAg9zjCo4t4pBT+nFQSJdDtTdTWDLApD5uO4C\n\t99uXWdrQ13F3yLfkU2DZeG2+hS4NrZRz68YWWSXzKz8w+xOtiRH/2ul53MaqKe6M+Qa2\n\tyYBtq/yHHdTj17GE/L0JekBX5Y4547ApKNlEI2r/AItDfzBg9desJZU7hMYzRL2J3mPn\n\tEyebSmsA6f+VTzhGuRoL8aEMkLqUK7BZ+i937xg5DjAbEW4ec4R/FM4aOHf7uOv0YwJK\n\tyjYQ==","X-Gm-Message-State":"AOAM532KEblvg2Uqtwg/016sSOarVsjBjr0OMLoBR84nuue5Bvvr2mU8\n\tlIt5ehGKwdSoLfmaXE6a4PsM3IN5h74etxj9z69R2gv8hLGZUg==","X-Google-Smtp-Source":"ABdhPJwaq4ebhtPV69JMbSUFVh1FqdoAyNyTpOJ8uf/O9V7dGc8tgpGs6oujmiQSRv6oDu18DlFqmdNb+q6n9T869+g=","X-Received":"by 2002:a4a:84c9:: with SMTP id o9mr21711174oog.28.1608021473478;\n\tTue, 15 Dec 2020 00:37:53 -0800 (PST)","MIME-Version":"1.0","References":"<20201126145005.8838-1-david.plowman@raspberrypi.com>\n\t\n\t<20201130103012.lx4ldjepwj52yc6i@uno.localdomain>\n\t\n\t\n\t","In-Reply-To":"","From":"\"david.plowman\" ","Date":"Tue, 15 Dec 2020 08:37:43 +0000","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v2 0/2] Digital gain control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]