{"id":10501,"url":"https://patchwork.libcamera.org/api/covers/10501/?format=json","web_url":"https://patchwork.libcamera.org/cover/10501/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201126123203.19105-1-david.plowman@raspberrypi.com>","date":"2020-11-26T12:31:59","name":"[libcamera-devel,v2,0/4] Raspberry Pi AGC improvements","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/10501/mbox/","series":[{"id":1483,"url":"https://patchwork.libcamera.org/api/series/1483/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1483","date":"2020-11-26T12:31:59","name":"Raspberry Pi AGC improvements","version":2,"mbox":"https://patchwork.libcamera.org/series/1483/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/10501/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7F9CBE176\n\tfor ;\n\tThu, 26 Nov 2020 12:32:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B32463458;\n\tThu, 26 Nov 2020 13:32:11 +0100 (CET)","from mail-ej1-x635.google.com (mail-ej1-x635.google.com\n\t[IPv6:2a00:1450:4864:20::635])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D48463408\n\tfor ;\n\tThu, 26 Nov 2020 13:32:10 +0100 (CET)","by mail-ej1-x635.google.com with SMTP id bo9so2622735ejb.13\n\tfor ;\n\tThu, 26 Nov 2020 04:32:09 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tu5sm3064354edp.5.2020.11.26.04.32.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 26 Nov 2020 04:32:08 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"H/ZVG6Oj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=K9F4kZm0BYI5FUUYu1qyevSvG07MqDw41hWu7qjkLZo=;\n\tb=H/ZVG6Ojfn7J/Sp4YqiW4hmYt4BaTsuvyXmkoUDyfXtb9tk67TSf3WZTvJdBljWCDO\n\t5CkSuasFeG2xVkYqbBzbuEbzDEK+eCkSlEszfjku6wUdSMJ6pa9Y64wwbBdBu/XOy/vt\n\tlqh1/CJEDWftMSgLYfEtx9TtxeUWi2XfCUDppp8H51JfG0SbFzuxDksyPZJD1JG2T2Yp\n\txdRs3h9OgvnOB0gTnuyFPrWJ8j+QxgkZvG4V9KL5zoA/zN3pKI2zJoLZow6RQ652E2E2\n\t/oIYwwpz85EJPebURNpNr4pqDYgoLWloztKBPm06/AOpS4uA/r1HAxOt2B7QQE6doX5f\n\tGliA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=K9F4kZm0BYI5FUUYu1qyevSvG07MqDw41hWu7qjkLZo=;\n\tb=QEXGxlAzcFGxEp4h2t0+YSTX7dfMh5bb7IPWg1SuLow1eaSIvd5N/WuFv2nQ64vfkV\n\tpofJJXMZG8vqiwBQUGs+bK9+VHB5DrChOMSCGj1kLSze0vdDcTguxYGIgYwxEaC7KUyY\n\tVk7kiXPUb3S1vR5UknRQmZXt6oxTcpb/5Mk6eAX1aqgSG4W9RJm2BpaROjPof3s5xa7c\n\tRf7FKt+CAU48gUNTQGpPS5vip1bIztoSsNmad0DWXsmpcLJqWAHWPhF3BGYHAunR/YjU\n\t+hSVxuZJku2dlmiIYzTYiqoQgTL5s/yuX5A6+1BMeeHnMK7Hx3eiXorfz/bC4Z24nfK1\n\tNQPA==","X-Gm-Message-State":"AOAM530LAOAiis3JtPgtkCOY5LPym2zq3WgQFBuO29p8WOSwKBVrF7Do\n\t6ApGyjdFkTv4flfGCtHWcdYM2vP9ky7QiWx7","X-Google-Smtp-Source":"ABdhPJzqRwADZBEaXTSW72rzkuzPbn8ifgp2rVtIVNroaktFdl7mGH8ypDHHVmxRlyyL4U7N8Lybmg==","X-Received":"by 2002:a17:906:38cc:: with SMTP id\n\tr12mr2441625ejd.277.1606393929248; \n\tThu, 26 Nov 2020 04:32:09 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 26 Nov 2020 12:31:59 +0000","Message-Id":"<20201126123203.19105-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 0/4] Raspberry Pi AGC improvements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi\n\nThanks for the comments. This revised set turns the middle patch into\ntwo, implementing Naush's suggestion. The first of these gives AGC a\ncustom implementation of pause/resume, making the subsequent patch\nsimpler. Functionally nothing is changed, and the other patches\nunrelated to this are untouched.\n\nBest regards\nDavid\n\nDavid Plowman (4):\n src: ipa: raspberrypi: Avoid AGC filtering when both gain and shutter\n specified\n src: ipa: raspberrypi: agc: Make AGC handle Pause/Resume for itself\n src: ipa: raspberrypi: Improve behaviour when AE disabled\n src: ipa: raspberrypi: Fix initial AGC oscillation for imx219 sensor\n\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 31 +++++++++++++++++++++-\n src/ipa/raspberrypi/controller/rpi/agc.hpp | 5 ++++\n src/ipa/raspberrypi/data/imx219.json | 4 +--\n src/ipa/raspberrypi/raspberrypi.cpp | 9 +------\n 4 files changed, 38 insertions(+), 11 deletions(-)"}