[{"id":13807,"web_url":"https://patchwork.libcamera.org/comment/13807/","msgid":"<2db4ae6d-ad00-fdae-f302-5b0004819df4@collabora.com>","date":"2020-11-19T16:41:19","subject":"Re: [libcamera-devel] [PATCH 0/1]\n\tpipeline-rkisp1-Fix-sensor-ISP-format-mismatch","submitter":{"id":46,"url":"https://patchwork.libcamera.org/api/people/46/","name":"Dafna Hirschfeld","email":"dafna.hirschfeld@collabora.com"},"content":"Hi,\nThanks!\n\nAm 19.11.20 um 14:13 schrieb Sebastian Fricke:\n> This patch fixes a mismatch of image formats during the pipeline\n> creation of the RkISP1. The mismatch happens because the current code\n> does not check if the configured format exceeded the maximum viable\n> resolution of the ISP.\n> This patch fixes the issue by first setting the ISP, checking if the\n> given resolution was taken and searching for another viable format that\n> is lower or equal to the ISP maximum.\n> \n> Here are a couple of test runs:\n> 1. Without stream configuration\n> 2. With a normal stream configuration\n> 3. With a stream configuration that exceeds the maximum of the ISP\n> 4. With a very small resolution stream configuration\n> 5. With a configuration that is closer to the upper than to the lower\n\nAre all those commands succeed?\nthe idea is to make an effort to match the sensor output and isp input\nso that streaming succeed as much as possible.\n\nThanks,\nDafna\n\n> resolution\n> \n> ----\n> \n> 1. LIBCAMERA_LOG_LEVELS=0 cam -c 1 --capture=3\n> \n> [8:05:49.668381732] [9973] DEBUG Camera camera.cpp:771 streams configuration: (0) 1920x1920-NV12\n> [8:05:49.669108269] [9973] INFO Camera camera.cpp:830 configuring streams: (0) 1920x1920-NV12\n> ...\n> [8:05:49.670965005] [9974] DEBUG RkISP1 rkisp1.cpp:687 Configuring sensor with 4224x3136-SBGGR10_1X10\n> [8:05:49.671126004] [9974] DEBUG RkISP1 rkisp1.cpp:694 ISP configured with 4032x3024-SBGGR10_1X10\n> [8:05:49.671233045] [9974] INFO RkISP1 rkisp1.cpp:697 Configured resolution is greater than the maximum resolution for the ISP, trying to re-configure to a smaller valid sensor format\n> [8:05:49.671378294] [9974] DEBUG RkISP1 rkisp1.cpp:716 ISP re-configured with 2112x1568-SBGGR10_1X10\n> [8:05:49.671510710] [9974] DEBUG RkISP1 rkisp1.cpp:724 Sensor configured with 2112x1568-SBGGR10_1X10\n> [8:05:49.671676667] [9974] DEBUG RkISP1 rkisp1.cpp:731 ISP input pad configured with 2112x1568-SBGGR10_1X10\n> [8:05:49.671787791] [9974] DEBUG RkISP1 rkisp1.cpp:735 Configuring ISP output pad with 2112x1568-YUYV8_2X8\n> [8:05:49.671894540] [9974] DEBUG RkISP1 rkisp1.cpp:741 ISP output pad configured with 800x600-YUYV8_2X8\n> [8:05:49.672107747] [9974] DEBUG RkISP1 rkisp1_path.cpp:120 Configured main resizer input pad with 800x600-YUYV8_2X8\n> [8:05:49.672226163] [9974] DEBUG RkISP1 rkisp1_path.cpp:126 Configuring main resizer output pad with 1920x1920-YUYV8_2X8\n> [8:05:49.672341662] [9974] DEBUG RkISP1 rkisp1_path.cpp:144 Configured main resizer output pad with 1920x1920-YUYV8_1_5X8\n> \n> 2. LIBCAMERA_LOG_LEVELS=0 cam -c 1 --capture=3 -s width=900,height=600,pixelformat=NV12,role=video\n> \n> [8:07:05.725799205] [9977] DEBUG Camera camera.cpp:771 streams configuration: (0) 1920x1920-NV12\n> [8:07:05.726242535] [9977] INFO Camera camera.cpp:830 configuring streams: (0) 900x600-NV12\n> ...\n> [8:07:05.727718025] [9978] DEBUG RkISP1 rkisp1.cpp:687 Configuring sensor with 2112x1568-SBGGR10_1X10\n> [8:07:05.727873482] [9978] DEBUG RkISP1 rkisp1.cpp:694 ISP configured with 2112x1568-SBGGR10_1X10\n> [8:07:05.728056356] [9978] DEBUG RkISP1 rkisp1.cpp:724 Sensor configured with 2112x1568-SBGGR10_1X10\n> [8:07:05.728233104] [9978] DEBUG RkISP1 rkisp1.cpp:731 ISP input pad configured with 2112x1568-SBGGR10_1X10\n> [8:07:05.728340437] [9978] DEBUG RkISP1 rkisp1.cpp:735 Configuring ISP output pad with 2112x1568-YUYV8_2X8\n> [8:07:05.728448353] [9978] DEBUG RkISP1 rkisp1.cpp:741 ISP output pad configured with 800x600-YUYV8_2X8\n> [8:07:05.728567352] [9978] DEBUG RkISP1 rkisp1_path.cpp:120 Configured main resizer input pad with 800x600-YUYV8_2X8\n> [8:07:05.728673809] [9978] DEBUG RkISP1 rkisp1_path.cpp:126 Configuring main resizer output pad with 900x600-YUYV8_2X8\n> [8:07:05.728785517] [9978] DEBUG RkISP1 rkisp1_path.cpp:144 Configured main resizer output pad with 900x600-YUYV8_1_5X8\n> \n> 3. LIBCAMERA_LOG_LEVELS=0 cam -c 1 --capture=3 -s width=4500,height=3500,pixelformat=NV12,role=video\n> \n> [8:08:02.372820979] [9981] DEBUG Camera camera.cpp:771 streams configuration: (0) 1920x1920-NV12\n> [8:08:02.373280350] [9981] DEBUG RkISP1 rkisp1_path.cpp:100 Adjusting format from 4500x3500-NV12 to 4416x3312-NV12\n> [8:08:02.373534098] [9981] DEBUG RkISP1 rkisp1_path.cpp:100 Adjusting format from 4500x3500-NV12 to 1920x1920-NV12\n> [8:08:02.373767722] [9981] DEBUG RkISP1 rkisp1_path.cpp:100 Adjusting format from 4500x3500-NV12 to 4416x3312-NV12\n> [8:08:02.374010095] [9981] DEBUG CameraSensor camera_sensor.cpp:408 'ov13850 1-0010': No supported format or size found\n> Camera configuration adjusted\n> [8:08:02.374449634] [9981] DEBUG CameraSensor camera_sensor.cpp:408 'ov13850 1-0010': No supported format or size found\n> [8:08:02.374591091] [9981] INFO Camera camera.cpp:830 configuring streams: (0) 4416x3312-NV12\n> ...\n> [8:08:02.376301704] [9982] DEBUG RkISP1 rkisp1.cpp:687 Configuring sensor with 4224x3136-0x0000\n> [8:08:02.376469994] [9982] DEBUG RkISP1 rkisp1.cpp:694 ISP configured with 4032x3024-SRGGB10_1X10\n> [8:08:02.376576160] [9982] INFO RkISP1 rkisp1.cpp:697 Configured resolution is greater than the maximum resolution for the ISP, trying to re-configure to a smaller valid sensor format\n> [8:08:02.376710909] [9982] DEBUG RkISP1 rkisp1.cpp:716 ISP re-configured with 2112x1568-SBGGR10_1X10\n> [8:08:02.376839241] [9982] DEBUG RkISP1 rkisp1.cpp:724 Sensor configured with 2112x1568-SBGGR10_1X10\n> [8:08:02.377001115] [9982] DEBUG RkISP1 rkisp1.cpp:731 ISP input pad configured with 2112x1568-SBGGR10_1X10\n> [8:08:02.377104364] [9982] DEBUG RkISP1 rkisp1.cpp:735 Configuring ISP output pad with 2112x1568-YUYV8_2X8\n> [8:08:02.377208780] [9982] DEBUG RkISP1 rkisp1.cpp:741 ISP output pad configured with 800x600-YUYV8_2X8\n> [8:08:02.377324863] [9982] DEBUG RkISP1 rkisp1_path.cpp:120 Configured main resizer input pad with 800x600-YUYV8_2X8\n> [8:08:02.377425779] [9982] DEBUG RkISP1 rkisp1_path.cpp:126 Configuring main resizer output pad with 4416x3312-YUYV8_2X8\n> [8:08:02.377533695] [9982] DEBUG RkISP1 rkisp1_path.cpp:144 Configured main resizer output pad with 4416x3312-YUYV8_1_5X8\n> \n> 4. LIBCAMERA_LOG_LEVELS=0 cam -c 1 --capture=3 -s width=40,height=30,pixelformat=NV12,role=video\n> \n> [8:10:41.140561164] [9989] DEBUG Camera camera.cpp:771 streams configuration: (0) 1920x1920-NV12\n> [8:10:41.141348367] [9989] INFO Camera camera.cpp:830 configuring streams: (0) 40x30-NV12\n> ...\n> [8:10:41.143016688] [9990] DEBUG RkISP1 rkisp1.cpp:687 Configuring sensor with 2112x1568-SBGGR10_1X10\n> [8:10:41.143161062] [9990] DEBUG RkISP1 rkisp1.cpp:694 ISP configured with 2112x1568-SBGGR10_1X10\n> [8:10:41.143283561] [9990] DEBUG RkISP1 rkisp1.cpp:724 Sensor configured with 2112x1568-SBGGR10_1X10\n> [8:10:41.143442810] [9990] DEBUG RkISP1 rkisp1.cpp:731 ISP input pad configured with 2112x1568-SBGGR10_1X10\n> [8:10:41.143544893] [9990] DEBUG RkISP1 rkisp1.cpp:735 Configuring ISP output pad with 2112x1568-YUYV8_2X8\n> [8:10:41.143644934] [9990] DEBUG RkISP1 rkisp1.cpp:741 ISP output pad configured with 800x600-YUYV8_2X8\n> [8:10:41.143756058] [9990] DEBUG RkISP1 rkisp1_path.cpp:120 Configured main resizer input pad with 800x600-YUYV8_2X8\n> [8:10:41.143854640] [9990] DEBUG RkISP1 rkisp1_path.cpp:126 Configuring main resizer output pad with 40x30-YUYV8_2X8\n> [8:10:41.143960223] [9990] DEBUG RkISP1 rkisp1_path.cpp:144 Configured main resizer output pad with 40x30-YUYV8_1_5X8\n> \n> 5. LIBCAMERA_LOG_LEVELS=0 cam -c 1 --capture=3 -s width=3450,height=2456,pixelformat=NV12,role=video\n> \n> [8:11:40.321895811] [9992] DEBUG Camera camera.cpp:771 streams configuration: (0) 1920x1920-NV12\n> [8:11:40.322697014] [9992] INFO Camera camera.cpp:830 configuring streams: (0) 3450x2456-NV12\n> ...\n> [8:11:40.324431543] [9993] DEBUG RkISP1 rkisp1.cpp:687 Configuring sensor with 4224x3136-SBGGR10_1X10\n> [8:11:40.324579125] [9993] DEBUG RkISP1 rkisp1.cpp:694 ISP configured with 4032x3024-SBGGR10_1X10\n> [8:11:40.324680041] [9993] INFO RkISP1 rkisp1.cpp:697 Configured resolution is greater than the maximum resolution for the ISP, trying to re-configure to a smaller valid sensor format\n> [8:11:40.324815082] [9993] DEBUG RkISP1 rkisp1.cpp:716 ISP re-configured with 2112x1568-SBGGR10_1X10\n> [8:11:40.324946039] [9993] DEBUG RkISP1 rkisp1.cpp:724 Sensor configured with 2112x1568-SBGGR10_1X10\n> [8:11:40.325111121] [9993] DEBUG RkISP1 rkisp1.cpp:731 ISP input pad configured with 2112x1568-SBGGR10_1X10\n> [8:11:40.325216121] [9993] DEBUG RkISP1 rkisp1.cpp:735 Configuring ISP output pad with 2112x1568-YUYV8_2X8\n> [8:11:40.325323453] [9993] DEBUG RkISP1 rkisp1.cpp:741 ISP output pad configured with 800x600-YUYV8_2X8\n> [8:11:40.325441286] [9993] DEBUG RkISP1 rkisp1_path.cpp:120 Configured main resizer input pad with 800x600-YUYV8_2X8\n> [8:11:40.325547451] [9993] DEBUG RkISP1 rkisp1_path.cpp:126 Configuring main resizer output pad with 3450x2456-YUYV8_2X8\n> [8:11:40.325660909] [9993] DEBUG RkISP1 rkisp1_path.cpp:144 Configured main resizer output pad with 3450x2456-YUYV8_1_5X8\n> \n> ----\n> \n> Sebastian Fricke (1):\n> pipeline: rkisp1: Fix sensor-ISP format mismatch\n> \n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 36 ++++++++++++++++++++++--\n> 1 file changed, 33 insertions(+), 3 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B9AEBE176\n\tfor ;\n\tThu, 19 Nov 2020 16:41:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 29708615B2;\n\tThu, 19 Nov 2020 17:41:25 +0100 (CET)","from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 584F060D4B\n\tfor ;\n\tThu, 19 Nov 2020 17:41:23 +0100 (CET)","from [IPv6:2003:c7:cf41:a700:4100:38e3:ac80:b823]\n\t(p200300c7cf41a700410038e3ac80b823.dip0.t-ipconnect.de\n\t[IPv6:2003:c7:cf41:a700:4100:38e3:ac80:b823])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: dafna)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 8515E1F441FE;\n\tThu, 19 Nov 2020 16:41:22 +0000 (GMT)"],"To":"Sebastian Fricke ","References":"<20201119131331.30847-1-sebastian.fricke.linux@gmail.com>","From":"Dafna Hirschfeld ","Message-ID":"<2db4ae6d-ad00-fdae-f302-5b0004819df4@collabora.com>","Date":"Thu, 19 Nov 2020 17:41:19 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201119131331.30847-1-sebastian.fricke.linux@gmail.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 0/1]\n\tpipeline-rkisp1-Fix-sensor-ISP-format-mismatch","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13810,"web_url":"https://patchwork.libcamera.org/comment/13810/","msgid":"<20201119181159.ffgdg53gaae55jrm@basti.Speedport_W_724V_Typ_A_05011603_06_001>","date":"2020-11-19T18:11:59","subject":"Re: [libcamera-devel] [PATCH 0/1]\n\tpipeline-rkisp1-Fix-sensor-ISP-format-mismatch","submitter":{"id":73,"url":"https://patchwork.libcamera.org/api/people/73/","name":"Sebastian Fricke","email":"sebastian.fricke.linux@gmail.com"},"content":"On 19.11.2020 17:41, Dafna Hirschfeld wrote:\n>Hi,\n>Thanks!\n\nHi Dafna,\n\n>\n>Am 19.11.20 um 14:13 schrieb Sebastian Fricke:\n>>This patch fixes a mismatch of image formats during the pipeline\n>>creation of the RkISP1. The mismatch happens because the current code\n>>does not check if the configured format exceeded the maximum viable\n>>resolution of the ISP.\n>>This patch fixes the issue by first setting the ISP, checking if the\n>>given resolution was taken and searching for another viable format that\n>>is lower or equal to the ISP maximum.\n>>\n>>Here are a couple of test runs:\n>>1. Without stream configuration\n>>2. With a normal stream configuration\n>>3. With a stream configuration that exceeds the maximum of the ISP\n>>4. With a very small resolution stream configuration\n>>5. With a configuration that is closer to the upper than to the lower\n>\n>Are all those commands succeed?\n>the idea is to make an effort to match the sensor output and isp input\n>so that streaming succeed as much as possible.\n\nYes all of those commands worked, but I still have a few warnings\nwithing the log, which are unrelated to the format matching like:\n\nERROR V4L2 v4l2_subdevice.cpp:285 'ov13850 1-0010': Unable to get\nrectangle 1 on pad 0: Inappropriate ioctl for device\nERROR CameraSensor camera_sensor.cpp:513 'ov13850 1-0010':\nFailed to construct camera sensor info: the camera sensor does not report the active area\nWARN RkISP1 rkisp1.cpp:936 Camera sensor information not available\nWARN Timeline timeline.cpp:120 Action scheduled too late 12:27:38.176723000, run now 12:27:38.192436740\nERROR RkISP1 rkisp1.cpp:394 Parameters not ready on time for frame 5\n\n>\n>Thanks,\n>Dafna\n\nThanks for the review!\nSebastian\n>\n>>resolution\n>>\n>>----\n>>\n>>1. LIBCAMERA_LOG_LEVELS=0 cam -c 1 --capture=3\n>>\n>>[8:05:49.668381732] [9973] DEBUG Camera camera.cpp:771 streams configuration: (0) 1920x1920-NV12\n>>[8:05:49.669108269] [9973] INFO Camera camera.cpp:830 configuring streams: (0) 1920x1920-NV12\n>>...\n>>[8:05:49.670965005] [9974] DEBUG RkISP1 rkisp1.cpp:687 Configuring sensor with 4224x3136-SBGGR10_1X10\n>>[8:05:49.671126004] [9974] DEBUG RkISP1 rkisp1.cpp:694 ISP configured with 4032x3024-SBGGR10_1X10\n>>[8:05:49.671233045] [9974] INFO RkISP1 rkisp1.cpp:697 Configured resolution is greater than the maximum resolution for the ISP, trying to re-configure to a smaller valid sensor format\n>>[8:05:49.671378294] [9974] DEBUG RkISP1 rkisp1.cpp:716 ISP re-configured with 2112x1568-SBGGR10_1X10\n>>[8:05:49.671510710] [9974] DEBUG RkISP1 rkisp1.cpp:724 Sensor configured with 2112x1568-SBGGR10_1X10\n>>[8:05:49.671676667] [9974] DEBUG RkISP1 rkisp1.cpp:731 ISP input pad configured with 2112x1568-SBGGR10_1X10\n>>[8:05:49.671787791] [9974] DEBUG RkISP1 rkisp1.cpp:735 Configuring ISP output pad with 2112x1568-YUYV8_2X8\n>>[8:05:49.671894540] [9974] DEBUG RkISP1 rkisp1.cpp:741 ISP output pad configured with 800x600-YUYV8_2X8\n>>[8:05:49.672107747] [9974] DEBUG RkISP1 rkisp1_path.cpp:120 Configured main resizer input pad with 800x600-YUYV8_2X8\n>>[8:05:49.672226163] [9974] DEBUG RkISP1 rkisp1_path.cpp:126 Configuring main resizer output pad with 1920x1920-YUYV8_2X8\n>>[8:05:49.672341662] [9974] DEBUG RkISP1 rkisp1_path.cpp:144 Configured main resizer output pad with 1920x1920-YUYV8_1_5X8\n>>\n>>2. LIBCAMERA_LOG_LEVELS=0 cam -c 1 --capture=3 -s width=900,height=600,pixelformat=NV12,role=video\n>>\n>>[8:07:05.725799205] [9977] DEBUG Camera camera.cpp:771 streams configuration: (0) 1920x1920-NV12\n>>[8:07:05.726242535] [9977] INFO Camera camera.cpp:830 configuring streams: (0) 900x600-NV12\n>>...\n>>[8:07:05.727718025] [9978] DEBUG RkISP1 rkisp1.cpp:687 Configuring sensor with 2112x1568-SBGGR10_1X10\n>>[8:07:05.727873482] [9978] DEBUG RkISP1 rkisp1.cpp:694 ISP configured with 2112x1568-SBGGR10_1X10\n>>[8:07:05.728056356] [9978] DEBUG RkISP1 rkisp1.cpp:724 Sensor configured with 2112x1568-SBGGR10_1X10\n>>[8:07:05.728233104] [9978] DEBUG RkISP1 rkisp1.cpp:731 ISP input pad configured with 2112x1568-SBGGR10_1X10\n>>[8:07:05.728340437] [9978] DEBUG RkISP1 rkisp1.cpp:735 Configuring ISP output pad with 2112x1568-YUYV8_2X8\n>>[8:07:05.728448353] [9978] DEBUG RkISP1 rkisp1.cpp:741 ISP output pad configured with 800x600-YUYV8_2X8\n>>[8:07:05.728567352] [9978] DEBUG RkISP1 rkisp1_path.cpp:120 Configured main resizer input pad with 800x600-YUYV8_2X8\n>>[8:07:05.728673809] [9978] DEBUG RkISP1 rkisp1_path.cpp:126 Configuring main resizer output pad with 900x600-YUYV8_2X8\n>>[8:07:05.728785517] [9978] DEBUG RkISP1 rkisp1_path.cpp:144 Configured main resizer output pad with 900x600-YUYV8_1_5X8\n>>\n>>3. LIBCAMERA_LOG_LEVELS=0 cam -c 1 --capture=3 -s width=4500,height=3500,pixelformat=NV12,role=video\n>>\n>>[8:08:02.372820979] [9981] DEBUG Camera camera.cpp:771 streams configuration: (0) 1920x1920-NV12\n>>[8:08:02.373280350] [9981] DEBUG RkISP1 rkisp1_path.cpp:100 Adjusting format from 4500x3500-NV12 to 4416x3312-NV12\n>>[8:08:02.373534098] [9981] DEBUG RkISP1 rkisp1_path.cpp:100 Adjusting format from 4500x3500-NV12 to 1920x1920-NV12\n>>[8:08:02.373767722] [9981] DEBUG RkISP1 rkisp1_path.cpp:100 Adjusting format from 4500x3500-NV12 to 4416x3312-NV12\n>>[8:08:02.374010095] [9981] DEBUG CameraSensor camera_sensor.cpp:408 'ov13850 1-0010': No supported format or size found\n>>Camera configuration adjusted\n>>[8:08:02.374449634] [9981] DEBUG CameraSensor camera_sensor.cpp:408 'ov13850 1-0010': No supported format or size found\n>>[8:08:02.374591091] [9981] INFO Camera camera.cpp:830 configuring streams: (0) 4416x3312-NV12\n>>...\n>>[8:08:02.376301704] [9982] DEBUG RkISP1 rkisp1.cpp:687 Configuring sensor with 4224x3136-0x0000\n>>[8:08:02.376469994] [9982] DEBUG RkISP1 rkisp1.cpp:694 ISP configured with 4032x3024-SRGGB10_1X10\n>>[8:08:02.376576160] [9982] INFO RkISP1 rkisp1.cpp:697 Configured resolution is greater than the maximum resolution for the ISP, trying to re-configure to a smaller valid sensor format\n>>[8:08:02.376710909] [9982] DEBUG RkISP1 rkisp1.cpp:716 ISP re-configured with 2112x1568-SBGGR10_1X10\n>>[8:08:02.376839241] [9982] DEBUG RkISP1 rkisp1.cpp:724 Sensor configured with 2112x1568-SBGGR10_1X10\n>>[8:08:02.377001115] [9982] DEBUG RkISP1 rkisp1.cpp:731 ISP input pad configured with 2112x1568-SBGGR10_1X10\n>>[8:08:02.377104364] [9982] DEBUG RkISP1 rkisp1.cpp:735 Configuring ISP output pad with 2112x1568-YUYV8_2X8\n>>[8:08:02.377208780] [9982] DEBUG RkISP1 rkisp1.cpp:741 ISP output pad configured with 800x600-YUYV8_2X8\n>>[8:08:02.377324863] [9982] DEBUG RkISP1 rkisp1_path.cpp:120 Configured main resizer input pad with 800x600-YUYV8_2X8\n>>[8:08:02.377425779] [9982] DEBUG RkISP1 rkisp1_path.cpp:126 Configuring main resizer output pad with 4416x3312-YUYV8_2X8\n>>[8:08:02.377533695] [9982] DEBUG RkISP1 rkisp1_path.cpp:144 Configured main resizer output pad with 4416x3312-YUYV8_1_5X8\n>>\n>>4. LIBCAMERA_LOG_LEVELS=0 cam -c 1 --capture=3 -s width=40,height=30,pixelformat=NV12,role=video\n>>\n>>[8:10:41.140561164] [9989] DEBUG Camera camera.cpp:771 streams configuration: (0) 1920x1920-NV12\n>>[8:10:41.141348367] [9989] INFO Camera camera.cpp:830 configuring streams: (0) 40x30-NV12\n>>...\n>>[8:10:41.143016688] [9990] DEBUG RkISP1 rkisp1.cpp:687 Configuring sensor with 2112x1568-SBGGR10_1X10\n>>[8:10:41.143161062] [9990] DEBUG RkISP1 rkisp1.cpp:694 ISP configured with 2112x1568-SBGGR10_1X10\n>>[8:10:41.143283561] [9990] DEBUG RkISP1 rkisp1.cpp:724 Sensor configured with 2112x1568-SBGGR10_1X10\n>>[8:10:41.143442810] [9990] DEBUG RkISP1 rkisp1.cpp:731 ISP input pad configured with 2112x1568-SBGGR10_1X10\n>>[8:10:41.143544893] [9990] DEBUG RkISP1 rkisp1.cpp:735 Configuring ISP output pad with 2112x1568-YUYV8_2X8\n>>[8:10:41.143644934] [9990] DEBUG RkISP1 rkisp1.cpp:741 ISP output pad configured with 800x600-YUYV8_2X8\n>>[8:10:41.143756058] [9990] DEBUG RkISP1 rkisp1_path.cpp:120 Configured main resizer input pad with 800x600-YUYV8_2X8\n>>[8:10:41.143854640] [9990] DEBUG RkISP1 rkisp1_path.cpp:126 Configuring main resizer output pad with 40x30-YUYV8_2X8\n>>[8:10:41.143960223] [9990] DEBUG RkISP1 rkisp1_path.cpp:144 Configured main resizer output pad with 40x30-YUYV8_1_5X8\n>>\n>>5. LIBCAMERA_LOG_LEVELS=0 cam -c 1 --capture=3 -s width=3450,height=2456,pixelformat=NV12,role=video\n>>\n>>[8:11:40.321895811] [9992] DEBUG Camera camera.cpp:771 streams configuration: (0) 1920x1920-NV12\n>>[8:11:40.322697014] [9992] INFO Camera camera.cpp:830 configuring streams: (0) 3450x2456-NV12\n>>...\n>>[8:11:40.324431543] [9993] DEBUG RkISP1 rkisp1.cpp:687 Configuring sensor with 4224x3136-SBGGR10_1X10\n>>[8:11:40.324579125] [9993] DEBUG RkISP1 rkisp1.cpp:694 ISP configured with 4032x3024-SBGGR10_1X10\n>>[8:11:40.324680041] [9993] INFO RkISP1 rkisp1.cpp:697 Configured resolution is greater than the maximum resolution for the ISP, trying to re-configure to a smaller valid sensor format\n>>[8:11:40.324815082] [9993] DEBUG RkISP1 rkisp1.cpp:716 ISP re-configured with 2112x1568-SBGGR10_1X10\n>>[8:11:40.324946039] [9993] DEBUG RkISP1 rkisp1.cpp:724 Sensor configured with 2112x1568-SBGGR10_1X10\n>>[8:11:40.325111121] [9993] DEBUG RkISP1 rkisp1.cpp:731 ISP input pad configured with 2112x1568-SBGGR10_1X10\n>>[8:11:40.325216121] [9993] DEBUG RkISP1 rkisp1.cpp:735 Configuring ISP output pad with 2112x1568-YUYV8_2X8\n>>[8:11:40.325323453] [9993] DEBUG RkISP1 rkisp1.cpp:741 ISP output pad configured with 800x600-YUYV8_2X8\n>>[8:11:40.325441286] [9993] DEBUG RkISP1 rkisp1_path.cpp:120 Configured main resizer input pad with 800x600-YUYV8_2X8\n>>[8:11:40.325547451] [9993] DEBUG RkISP1 rkisp1_path.cpp:126 Configuring main resizer output pad with 3450x2456-YUYV8_2X8\n>>[8:11:40.325660909] [9993] DEBUG RkISP1 rkisp1_path.cpp:144 Configured main resizer output pad with 3450x2456-YUYV8_1_5X8\n>>\n>>----\n>>\n>>Sebastian Fricke (1):\n>> pipeline: rkisp1: Fix sensor-ISP format mismatch\n>>\n>> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 36 ++++++++++++++++++++++--\n>> 1 file changed, 33 insertions(+), 3 deletions(-)\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F7E1BE176\n\tfor ;\n\tThu, 19 Nov 2020 18:12:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9481E615B2;\n\tThu, 19 Nov 2020 19:12:03 +0100 (CET)","from mail-wm1-x342.google.com (mail-wm1-x342.google.com\n\t[IPv6:2a00:1450:4864:20::342])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1B9060D4B\n\tfor ;\n\tThu, 19 Nov 2020 19:12:02 +0100 (CET)","by mail-wm1-x342.google.com with SMTP id p22so8077856wmg.3\n\tfor ;\n\tThu, 19 Nov 2020 10:12:02 -0800 (PST)","from localhost\n\t(p200300d1ff000d0083023bfe18317ada.dip0.t-ipconnect.de.\n\t[2003:d1:ff00:d00:8302:3bfe:1831:7ada])\n\tby smtp.gmail.com with ESMTPSA id\n\te5sm894750wrs.84.2020.11.19.10.12.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 19 Nov 2020 10:12:01 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CLbnv7sV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:reply-to:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=SP0ab4BPZ2IMsawq5GSpi/7gjUOwN3xE7SoS96drSsE=;\n\tb=CLbnv7sVHB10Uf51r5y1jizqFan/5ZPBOYD9loGlrIbNkH/xngo1GxQxZ9yPGNZkAI\n\tkUOYhfV5Z9VvkvI/4KTV/o39Ub6Bvx62KEoGKo/DxQ5LSjdET7bxffl8wVtR6TPK05E6\n\tanGOdLoQaVhzT8I2LciHJ9QAkalynhs63ByPFg7ovbYu5hC9hPPlHz12vjKOMhiJGL76\n\tfRPmdDUY5hUKqTfoxivjyNihD6yz6DtJNbT1thbjd8DAZkBjsksG6Ocq16sEvdsyAnUk\n\tX+Vj2Gc8Rz0FpsaYYizGIpNjn3IHdLH7PoB/ReWWGoDxm36hI58g171mUA7VgQUd5dUF\n\tgL+A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to\n\t:references:mime-version:content-disposition:in-reply-to:user-agent; \n\tbh=SP0ab4BPZ2IMsawq5GSpi/7gjUOwN3xE7SoS96drSsE=;\n\tb=RlNMMh7mo39pmRVAbSeMJJidvThW8RmW9l8UJIkc3yJpPOZ4wHzuPmAWucqIyLT3Pg\n\tqqDR7uqYqeHDzqg6TC/N+hAmZbzoRfwoZrQ3R2ipWhq1nvpvV8SPNLsU5ZmQ1ItXDpLo\n\thvpqYsbsU16MY6F5g/NvbESn2vaY/voz016cfbIJ+woOaoIJ48DtPkrbnTwzT31xIWRL\n\t3su48rfyWOOY7CAdwRpuw4FlCIG8HmkZnOOcIO19S68+msgdIlBNJGd3G6PcSMwCYzap\n\tQw3qp7ZmDKnE14ycDGVj9I8Ej0JpNUHZ9l5seGAmKA4HMn4oPrBAGI2RnsgVrOoPG1cU\n\tkLCw==","X-Gm-Message-State":"AOAM533t44RAAdLbsX5vdqnibz7BljOfoloR22yur6JrBh/p0t1+WFMd\n\taHO6mpkosTismLUVa3A1z7r74+LrEuA=","X-Google-Smtp-Source":"ABdhPJzRT5DAQ9LQqrjbhGs/yhCihkLPYyh6eNmyzpmEm1BbWwZovJexHSKoeEu0I0iEJGLEgdaveQ==","X-Received":"by 2002:a1c:190:: with SMTP id 138mr5509278wmb.113.1605809522411;\n\tThu, 19 Nov 2020 10:12:02 -0800 (PST)","Date":"Thu, 19 Nov 2020 19:11:59 +0100","From":"Sebastian Fricke ","To":"Dafna Hirschfeld ","Message-ID":"<20201119181159.ffgdg53gaae55jrm@basti.Speedport_W_724V_Typ_A_05011603_06_001>","References":"<20201119131331.30847-1-sebastian.fricke.linux@gmail.com>\n\t<2db4ae6d-ad00-fdae-f302-5b0004819df4@collabora.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<2db4ae6d-ad00-fdae-f302-5b0004819df4@collabora.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 0/1]\n\tpipeline-rkisp1-Fix-sensor-ISP-format-mismatch","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"Sebastian Fricke ","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]