[{"id":13662,"web_url":"https://patchwork.libcamera.org/comment/13662/","msgid":"","date":"2020-11-10T10:11:12","subject":"Re: [libcamera-devel] [PATCH 0/2] media-libs/libcamera: Small fixes\n\tfor IPA builds","submitter":{"id":9,"url":"https://patchwork.libcamera.org/api/people/9/","name":"Tomasz Figa","email":"tfiga@chromium.org"},"content":"Hi Niklas,\n\nOn Mon, Nov 9, 2020 at 10:17 AM Niklas Söderlund\n wrote:\n>\n> Hi Tomasz,\n>\n> This small series fix two issues I have when building libcamera for\n> CrOS. I'm unsure how to best submit them \"correctly\" for upstream so I\n> send them to you. If you wish me to resubmit thru some other channel\n> just let me know.\n>\n> Patch 1/2 I have had in my tree for quiet some time and deals with that\n> the android option was turned into a meson feature instead of a boolean.\n> Patch 2/2 is a recent find that deals with how libcamera signs its IPA\n> modules and how CrOS build system strips binaries.\n>\n> Niklas Söderlund (2):\n> media-libs/libcamera: Android support is a feature not a boolean\n> media-libs/libcamera: Do not strip IPA binaries\n>\n> media-libs/libcamera/libcamera-9999.ebuild | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n\nThanks for the patches. I replied to each of them individually.\n\nIn general, changes to Chromium OS are submitted via Gerrit code review:\nhttps://chromium.googlesource.com/chromiumos/docs/+/master/contributing.md\n\nPlease follow that workflow in the future.\n\nBest regards,\nTomasz","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C38D6BE082\n\tfor ;\n\tTue, 10 Nov 2020 10:11:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 61F59630BE;\n\tTue, 10 Nov 2020 11:11:27 +0100 (CET)","from mail-ej1-x643.google.com (mail-ej1-x643.google.com\n\t[IPv6:2a00:1450:4864:20::643])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5F33630BA\n\tfor ;\n\tTue, 10 Nov 2020 11:11:25 +0100 (CET)","by mail-ej1-x643.google.com with SMTP id oq3so16698860ejb.7\n\tfor ;\n\tTue, 10 Nov 2020 02:11:25 -0800 (PST)","from mail-wm1-f41.google.com (mail-wm1-f41.google.com.\n\t[209.85.128.41]) by smtp.gmail.com with ESMTPSA id\n\tl27sm882191eja.20.2020.11.10.02.11.24\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 10 Nov 2020 02:11:24 -0800 (PST)","by mail-wm1-f41.google.com with SMTP id p19so1670523wmg.0\n\tfor ;\n\tTue, 10 Nov 2020 02:11:24 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"fjZJ2Ej1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=KqoW0piUa1ygS3t/wRYfrueH4vFTDf0GKgp5LWGHIos=;\n\tb=fjZJ2Ej15nlzX2uab0xxZmhCi//8RRjfn8quCTWiCH0fj3qqa2TLbykZfTUe43RSw9\n\t5088bFoj7GKf1rQSVc9uHoqCz7Ty+U6ZrV21TFIwE+nBrqIApmTw1J/nJUhSt+ob1V1o\n\tQSu6EHplFlyfhTZnWjM/3qvCKbLzppjs4SOZ0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=KqoW0piUa1ygS3t/wRYfrueH4vFTDf0GKgp5LWGHIos=;\n\tb=DHMJAbgDIyY2dwCUU0MYNubqAgLQxPwZ+s4cvkCDSK0cQzQFXqxS29mefXWxaV5TKr\n\tOC2cmB3XFq4FLvZaL/f/9QDjSfkEXVt05LcwbYhAoQ6Pc3Jdv4jQXsz4Xa1VNGkupjX8\n\t/YT1ybIT0DZ5eFPEWaNXxrq8lDPEVIMkvVz5y/848LTXNp5H75CmzZcFv2xF6MGi6DCD\n\tnbNVgf/9PW+J084Hesx4iC1CgH2ibxcH4n2EsuJyQYPEf3upsSSo7+T6sC8bHlHzt+wG\n\tpUWRRcH8uJv80S0oqyhoV3OlmRUVe+EOykruopWcDM6YGD3Y6VHgHG3SfTTBKfVjCEiT\n\tGvoQ==","X-Gm-Message-State":"AOAM532T5yN9kMnxWKB35cxMVCBCajmNd86uA+RtTmnY5hfB4zJ1pTFm\n\tcrKVnPrjCRlJwPLwrrsxE+3c5V2aV82xQI2C","X-Google-Smtp-Source":"ABdhPJxOtVi/7tLfF/pNPK4+BMx1tePWQJO8DBZBpsIJGq3/EB1IxQ5u+V5bL0C7VXwM4XrDz/n2tQ==","X-Received":["by 2002:a17:907:9e3:: with SMTP id\n\tce3mr19605390ejc.4.1605003085086; \n\tTue, 10 Nov 2020 02:11:25 -0800 (PST)","by 2002:a1c:208f:: with SMTP id\n\tg137mr3839570wmg.116.1605003083614; \n\tTue, 10 Nov 2020 02:11:23 -0800 (PST)"],"MIME-Version":"1.0","References":"<20201109011656.2560957-1-niklas.soderlund@ragnatech.se>","In-Reply-To":"<20201109011656.2560957-1-niklas.soderlund@ragnatech.se>","From":"Tomasz Figa ","Date":"Tue, 10 Nov 2020 19:11:12 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","Subject":"Re: [libcamera-devel] [PATCH 0/2] media-libs/libcamera: Small fixes\n\tfor IPA builds","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]