{"id":10312,"url":"https://patchwork.libcamera.org/api/covers/10312/?format=json","web_url":"https://patchwork.libcamera.org/cover/10312/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201103010251.14689-1-laurent.pinchart@ideasonboard.com>","date":"2020-11-03T01:02:47","name":"[libcamera-devel,v3,0/4] libcamera: Implement d-pointer design pattern","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/10312/mbox/","series":[{"id":1437,"url":"https://patchwork.libcamera.org/api/series/1437/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1437","date":"2020-11-03T01:02:47","name":"libcamera: Implement d-pointer design pattern","version":3,"mbox":"https://patchwork.libcamera.org/series/1437/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/10312/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E5634BDB1E\n\tfor ;\n\tTue, 3 Nov 2020 01:03:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7389C60345;\n\tTue, 3 Nov 2020 02:03:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 674EC60345\n\tfor ;\n\tTue, 3 Nov 2020 02:03:43 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E3C9E332\n\tfor ;\n\tTue, 3 Nov 2020 02:03:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kmYeOTG5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604365423;\n\tbh=Nq0sZbagtqaUmgPe7gZKxM6QpmN7xgapARNBYf+IO2w=;\n\th=From:To:Subject:Date:From;\n\tb=kmYeOTG5NAQSLBqkyGnq0L4cbOaPQOKTU2Pc2jKQ0xAWO/FZK4VIkCZFBGMxGDdwO\n\t8wV5gD6VgvhcZNtD4L/ylDFv14BnmMbRrya1zjT83thgZSfK76WheDz0zHCUaUBrBF\n\tFG2GMbJQVXHfqbB3gPYzy21OZEpXen5nrEy+0ENs=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 3 Nov 2020 03:02:47 +0200","Message-Id":"<20201103010251.14689-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 0/4] libcamera: Implement d-pointer\n\tdesign pattern","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThis patch series implements the d-pointer design pattern in a base\nclass, generalizing the custom implementations from the Camera and\nCameraManager classes. This was mostly developed as a base for the\nreprocessing API (the reworked camera configuration API will make use of\nd-pointers), but I believe it makes sense on its own.\n\nThe series is quite straightforward. Patch 1/4 adds a formatter to\ncheckstyle.py to ensure consistent naming of variables related to this\ndesign pattern. This stems from patch 2/4, which implements the\nframework, not hiding variable declarations in the LIBCAMERA_D_PTR() and\nLIBCAMERA_O_PTR() macros anymore. Patches 4/5 and 5/5 replace the manual\nimplementations. Please see individual patches for details.\n\nLaurent Pinchart (4):\n utils: checkstyle.py: Add d-pointer formatter\n libcamera: Add a base class to implement the d-pointer design pattern\n libcamera: camera_manager: Inherit from Extensible\n libcamera: camera: Inherit from Extensible\n\n include/libcamera/camera.h | 9 +-\n include/libcamera/camera_manager.h | 7 +-\n include/libcamera/extensible.h | 87 +++++++++++++++++++\n include/libcamera/meson.build | 1 +\n src/libcamera/camera.cpp | 123 +++++++++++++++-----------\n src/libcamera/camera_manager.cpp | 55 +++++++-----\n src/libcamera/extensible.cpp | 134 +++++++++++++++++++++++++++++\n src/libcamera/meson.build | 1 +\n utils/checkstyle.py | 32 +++++++\n 9 files changed, 373 insertions(+), 76 deletions(-)\n create mode 100644 include/libcamera/extensible.h\n create mode 100644 src/libcamera/extensible.cpp"}