[{"id":13498,"web_url":"https://patchwork.libcamera.org/comment/13498/","msgid":"<20201026232937.GL3756@pendragon.ideasonboard.com>","date":"2020-10-26T23:29:37","subject":"Re: [libcamera-devel] [PATCH v6 0/6] Digital zoom","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nOn Mon, Oct 26, 2020 at 05:19:02PM +0000, David Plowman wrote:\n> Hi everyone\n> \n> Thanks for all the reviews and comments. I believe I've got all those\n> suggestions into this latest version of the patch set now. The main\n> changes are:\n> \n> 1, 2, and 3. No or very minor changes.\n> \n> 4. The Point class has acquired operator==/operator!= and toString\n> methods, mainly to support the new unit tests, but they seem like a\n> reasonable thing anyway.\n> \n> 5. The scalerCrop_ that we report in metadata is updated only when it\n> changes.\n> \n> 6. An additional patch that provides some unit tests for those\n> geometry helper functions.\n> \n> Hope that's all clear!\n\nVery ! Thank you for your work.\n\nI've reviewed the patches, I only have a handful of tiny comments that\nI'll address when applying. There's one of them, though, in patch 5/6,\nfor which I'd like you to confirm if the proposed change is fine.\n\nLooks like we won't need a v7 :-)\n\n> David Plowman (6):\n> libcamera: Add ScalerCrop control\n> libcamera: Add SensorCropMaximum property\n> libcamera: raspberrypi: Initialise the SensorCropMaximum property\n> libcamera: Add geometry helper functions\n> libcamera: pipeline: raspberrypi: Implementation of digital zoom\n> test: geometry: Add unit tests for new geometry helper functions\n> \n> include/libcamera/geometry.h | 67 ++++\n> include/libcamera/ipa/raspberrypi.h | 1 +\n> src/ipa/raspberrypi/raspberrypi.cpp | 5 +\n> src/libcamera/control_ids.yaml | 13 +\n> src/libcamera/geometry.cpp | 328 ++++++++++++++++++\n> .../pipeline/raspberrypi/raspberrypi.cpp | 99 +++++-\n> src/libcamera/property_ids.yaml | 15 +\n> test/geometry.cpp | 258 +++++++++++++-\n> 8 files changed, 765 insertions(+), 21 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8EEAEBDB1E\n\tfor ;\n\tMon, 26 Oct 2020 23:30:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A97462064;\n\tTue, 27 Oct 2020 00:30:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B9BE62061\n\tfor ;\n\tTue, 27 Oct 2020 00:30:25 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B527881;\n\tTue, 27 Oct 2020 00:30:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mwSK+/Jm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603755024;\n\tbh=MJBRIXkBsTwt0AiFZD172bo1NW3cCAGpj2UZ1JUu34Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mwSK+/JmDN6xfDtw2Xm3uRt5KWIhDXiEj5TjS45BJ+b2VrXiIsS9aau15zxVyHRA2\n\tw01uhmsEX2zOBVYbvGX/b9iLd7a50ZuEYgzNkmjuc25GS4g1Qz80ICRoptvgq6Nq3y\n\t4GAYu9xXUxR/e4xPBQGS6rHB5XLwn5bexrEhzzqo=","Date":"Tue, 27 Oct 2020 01:29:37 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"<20201026232937.GL3756@pendragon.ideasonboard.com>","References":"<20201026171908.21463-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201026171908.21463-1-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v6 0/6] Digital zoom","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]