{"id":10204,"url":"https://patchwork.libcamera.org/api/covers/10204/?format=json","web_url":"https://patchwork.libcamera.org/cover/10204/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201023051021.16389-1-laurent.pinchart@ideasonboard.com>","date":"2020-10-23T05:10:18","name":"[libcamera-devel,0/3] libcamera: Miscellaneous constructors and destructors cleanups","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/10204/mbox/","series":[{"id":1405,"url":"https://patchwork.libcamera.org/api/series/1405/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1405","date":"2020-10-23T05:10:18","name":"libcamera: Miscellaneous constructors and destructors cleanups","version":1,"mbox":"https://patchwork.libcamera.org/series/1405/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/10204/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37BC2BDB13\n\tfor ;\n\tFri, 23 Oct 2020 05:11:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BCA26615DA;\n\tFri, 23 Oct 2020 07:11:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFF746034E\n\tfor ;\n\tFri, 23 Oct 2020 07:11:11 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 55DB8B26\n\tfor ;\n\tFri, 23 Oct 2020 07:11:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QUgr8qMI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603429871;\n\tbh=yE65HMc/PBPrcDBu/sLOQDHFo9GTjY0jGBZZZs0fils=;\n\th=From:To:Subject:Date:From;\n\tb=QUgr8qMIcEUHWBMzq29oOjOsOj8DLlB0hvO/cUKzQRMzVgLRLxweYTKZTwAD79FMj\n\tqNGQcmTMowRWLjvDwX+lNunZ86AV8fK0aF+LFHQMROI1dUZVcbEnXqzFaw6CPlp1mA\n\tLCG994xnuPqTZ/Z49Py+cV6ruzv+bbwgU4oiFQdI=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 23 Oct 2020 08:10:18 +0300","Message-Id":"<20201023051021.16389-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 0/3] libcamera: Miscellaneous constructors\n\tand destructors cleanups","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nWhile reviewing Kieran's copy/move disabling series (\"[libcamera-devel]\n[PATCH 0/5] Delete Copy-Move-Assign\"), I noticed a few minor issues in\nseveral classes the needlessly define custom empty default constructors\nand destructors. This patch series fixes it.\n\nLaurent Pinchart (3):\n libcamera: media_object: Remove unneeded destructors\n libcamera: Drop unneeded empty default constructors and destructors\n libcamera: Declare empty virtual destructors as defaulted\n\n include/libcamera/bound_method.h | 4 ++--\n include/libcamera/internal/control_validator.h | 2 +-\n include/libcamera/internal/ipa_proxy.h | 2 +-\n include/libcamera/internal/media_object.h | 5 +----\n include/libcamera/internal/pipeline_handler.h | 4 ++--\n include/libcamera/ipa/ipa_interface.h | 2 +-\n include/libcamera/signal.h | 1 -\n src/android/jpeg/encoder.h | 2 +-\n src/android/post_processor.h | 2 +-\n src/cam/options.h | 2 +-\n src/libcamera/media_object.cpp | 18 ------------------\n src/libcamera/pipeline/rkisp1/timeline.h | 4 ++--\n src/qcam/viewfinder.h | 2 +-\n test/media_device/media_device_print_test.cpp | 4 ----\n 14 files changed, 14 insertions(+), 40 deletions(-)"}