{"id":10177,"url":"https://patchwork.libcamera.org/api/covers/10177/?format=json","web_url":"https://patchwork.libcamera.org/cover/10177/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201021154148.511505-1-kieran.bingham@ideasonboard.com>","date":"2020-10-21T15:41:33","name":"[libcamera-devel,v4,00/15] Shadowed Variables","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/10177/mbox/","series":[{"id":1401,"url":"https://patchwork.libcamera.org/api/series/1401/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1401","date":"2020-10-21T15:41:33","name":"Shadowed Variables","version":4,"mbox":"https://patchwork.libcamera.org/series/1401/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/10177/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4D516BDB13\n\tfor ;\n\tWed, 21 Oct 2020 15:41:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 126E060BE7;\n\tWed, 21 Oct 2020 17:41:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E6B8603F9\n\tfor ;\n\tWed, 21 Oct 2020 17:41:52 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F235292;\n\tWed, 21 Oct 2020 17:41:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vFKA+33x\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603294912;\n\tbh=NAJdwAi0Tpx3h5Fp82Lz/SxTPqLZxMsXbaQKBrAXp+I=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=vFKA+33xYda47ZlO32olWxYXgI3Zd/Rqund2i3lM6vg71TTac38hV3CDDcH0JrJW9\n\t291r1YU5sIUdRuOzLiHH4M7kBNbUNqQ5FtuE55n0aXdBSwT+djaB0sOOlfJqMvOrJD\n\tc1+je9w+vERJWuIFpaWsIWNxc3CzFkCwzk5k2Jcc=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 21 Oct 2020 16:41:33 +0100","Message-Id":"<20201021154148.511505-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 00/15] Shadowed Variables","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Final spin of the shadowed variables series. (hopefully)\n\nSo a few more additions crept in to this series to cover the\nV4L2 layer, and updates that have been made in the android layer.\n\nHopefully this is 'done' ;-)\n\n\nKieran Bingham (15):\n libcamera: thread: Prevent shadowing of signal name\n libcamera: pipeline: Prevent variable shadowing\n libcamera: pipeline: Use existing variable definitions\n libcamera: pipeline: rpi_stream: Explicitly name requestBuffer\n libcamera: v4l2_videodevice: Prevent shadowing of V4L2BufferCache\n members\n ipa: raspberrypi: Re-use iterator variable\n android: camera_device: Use existing variable definitions\n android: camera_device: use member style on Camera3RequestDescriptor\n android: camera_device: Rename shadowed variable\n android: metadata: Disable -Wshadow\n v4l2: camera: Prevent shadowing within V4L2Camera::Buffer\n cam: options: Rename optional arg to prevent shadowing\n qcam: main_window: Explicitly name raw buffer\n test: v4l2_videodevice: Prevent variable shadowing of format\n meson: Enable shadowed variable warning\n\n include/libcamera/internal/v4l2_videodevice.h | 4 +-\n meson.build | 1 +\n src/android/camera_device.cpp | 64 +++++++++----------\n src/android/camera_device.h | 10 +--\n src/android/meson.build | 1 +\n src/cam/options.cpp | 10 +--\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 6 +-\n .../pipeline/raspberrypi/raspberrypi.cpp | 8 +--\n .../pipeline/raspberrypi/rpi_stream.cpp | 8 +--\n src/libcamera/pipeline/simple/converter.cpp | 8 +--\n src/libcamera/pipeline/simple/simple.cpp | 8 +--\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 4 +-\n src/libcamera/thread.cpp | 8 +--\n src/libcamera/v4l2_videodevice.cpp | 12 ++--\n src/qcam/main_window.cpp | 8 +--\n src/v4l2/v4l2_camera.h | 6 +-\n src/v4l2/v4l2_camera_proxy.cpp | 4 +-\n test/v4l2_videodevice/formats.cpp | 6 +-\n 18 files changed, 89 insertions(+), 87 deletions(-)"}