{"id":9962,"url":"https://patchwork.libcamera.org/api/1.1/patches/9962/?format=json","web_url":"https://patchwork.libcamera.org/patch/9962/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201005104649.10812-16-laurent.pinchart@ideasonboard.com>","date":"2020-10-05T10:46:49","name":"[libcamera-devel,15/15] android: camera_device: Clear streams_ at stop time","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"dac320b60160eb42ee7ff02a2e1a46f7877e950e","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9962/mbox/","series":[{"id":1349,"url":"https://patchwork.libcamera.org/api/1.1/series/1349/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1349","date":"2020-10-05T10:46:34","name":"CameraStream refactoring","version":1,"mbox":"https://patchwork.libcamera.org/series/1349/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9962/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9962/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8AB2C3B5F\n\tfor ;\n\tMon, 5 Oct 2020 10:47:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF4F663C74;\n\tMon, 5 Oct 2020 12:47:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 80AF163BD5\n\tfor ;\n\tMon, 5 Oct 2020 12:47:39 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1925859E;\n\tMon, 5 Oct 2020 12:47:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fLAHW+OU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601894859;\n\tbh=9fnEmf+uRGJAlayAfulaFQMZza6rsz9bQhIEF1SdMX4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fLAHW+OUmIMFxM5TpH5t3+B2wnmU2r9Dba+0EYCUoSNKv/LaXMFVDjvuBEheI8CXZ\n\tolgu4vDL9ZP+gI+DjbJlDd4b6jfRf3mPokpihkUm4qs9DeIiHW081zQXFoaPmHt+uw\n\thqgC2z9vuy4kaHBaWiPdYLZiQF1l/EAL9ES2PMjo=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 5 Oct 2020 13:46:49 +0300","Message-Id":"<20201005104649.10812-16-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201005104649.10812-1-laurent.pinchart@ideasonboard.com>","References":"<20201005104649.10812-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 15/15] android: camera_device: Clear\n\tstreams_ at stop time","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Jacopo Mondi \n\nWhen the CameraDevice is stopped, we need to clear the vector\nof CameraStream instances to make sure they get deleted and all the\nresources they have acquired get released.\n\nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 1a9af2e34340..6bbdfcc4a28b 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -517,6 +517,8 @@ int CameraDevice::open(const hw_module_t *hardwareModule)\n \n void CameraDevice::close()\n {\n+\tstreams_.clear();\n+\n \tcamera_->stop();\n \tcamera_->release();\n \n","prefixes":["libcamera-devel","15/15"]}