{"id":9942,"url":"https://patchwork.libcamera.org/api/1.1/patches/9942/?format=json","web_url":"https://patchwork.libcamera.org/patch/9942/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201002143154.468162-35-paul.elder@ideasonboard.com>","date":"2020-10-02T14:31:50","name":"[libcamera-devel,v3,34/38] tests: ipa_interface_test: Update to use new createIPA","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a989b1b37f7d66199726a4f19910610904825d99","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9942/mbox/","series":[{"id":1348,"url":"https://patchwork.libcamera.org/api/1.1/series/1348/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1348","date":"2020-10-02T14:31:16","name":"IPA isolation implementation","version":3,"mbox":"https://patchwork.libcamera.org/series/1348/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9942/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9942/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB7C4C3B5C\n\tfor ;\n\tFri, 2 Oct 2020 14:33:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9CCAA63BE8;\n\tFri, 2 Oct 2020 16:33:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B1FE63B98\n\tfor ;\n\tFri, 2 Oct 2020 16:33:28 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 92673528;\n\tFri, 2 Oct 2020 16:33:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LryNyTSF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601649208;\n\tbh=H2JIAoSUznJO114Svyw/DBrw9YK4KvJqqZMj1g8baek=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=LryNyTSFK6lj92IIxviRDFfKWzn50dXHW2prmSm3nIYI1Fpj0juldeGV1+Wt/Nzma\n\tCziDFGAN/2kPAqMELVMo1+mzO6cfH4oa2o0M2X38QHWnth8ywluA2Zk4zvnt5l9vxZ\n\tDEhnnRbbzJPlfInwM/82wDc74IbEMWMJgXAmm2XA=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Oct 2020 23:31:50 +0900","Message-Id":"<20201002143154.468162-35-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201002143154.468162-1-paul.elder@ideasonboard.com>","References":"<20201002143154.468162-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 34/38] tests: ipa_interface_test:\n\tUpdate to use new createIPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Update the IPA interface test to use the new createIPA function from\nIPAManager. Also declare ProcessManager, as it is not longer globally\ndefined. Update meson.build to depend on the generated IPA interface\nheaders.\n\nSigned-off-by: Paul Elder \n\n---\nChanges in v3:\n- declare ProcessManager\n- add libcamera_generated_headers as dependency to meson\n - otherwise test might build before the generated IPA headers and\n #include will fail\n\nNew in v2\n---\n test/ipa/ipa_interface_test.cpp | 10 +++++++---\n test/ipa/meson.build | 2 +-\n 2 files changed, 8 insertions(+), 4 deletions(-)","diff":"diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\nindex 1bc93a63..db95a9e5 100644\n--- a/test/ipa/ipa_interface_test.cpp\n+++ b/test/ipa/ipa_interface_test.cpp\n@@ -14,13 +14,15 @@\n \n #include \n #include \n-#include \n+#include \n+#include \n #include \n \n #include \"libcamera/internal/device_enumerator.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/ipa_module.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n+#include \"libcamera/internal/process.h\"\n #include \"libcamera/internal/thread.h\"\n \n #include \"test.h\"\n@@ -95,7 +97,7 @@ protected:\n \t\tEventDispatcher *dispatcher = thread()->eventDispatcher();\n \t\tTimer timer;\n \n-\t\tipa_ = IPAManager::createIPA(pipe_.get(), 0, 0);\n+\t\tipa_ = IPAManager::createIPA(pipe_.get(), 0, 0);\n \t\tif (!ipa_) {\n \t\t\tcerr << \"Failed to create VIMC IPA interface\" << endl;\n \t\t\treturn TestFail;\n@@ -163,8 +165,10 @@ private:\n \t\t}\n \t}\n \n+\tProcessManager processManager_;\n+\n \tstd::shared_ptr pipe_;\n-\tstd::unique_ptr ipa_;\n+\tstd::unique_ptr ipa_;\n \tstd::unique_ptr ipaManager_;\n \tenum IPAOperationCode trace_;\n \tEventNotifier *notifier_;\ndiff --git a/test/ipa/meson.build b/test/ipa/meson.build\nindex b25bfcf4..928987db 100644\n--- a/test/ipa/meson.build\n+++ b/test/ipa/meson.build\n@@ -7,7 +7,7 @@ ipa_test = [\n ]\n \n foreach t : ipa_test\n- exe = executable(t[0], t[1],\n+ exe = executable(t[0], [t[1], libcamera_generated_headers],\n dependencies : libcamera_dep,\n link_with : test_libraries,\n include_directories : test_includes_internal)\n","prefixes":["libcamera-devel","v3","34/38"]}