{"id":9903,"url":"https://patchwork.libcamera.org/api/1.1/patches/9903/?format=json","web_url":"https://patchwork.libcamera.org/patch/9903/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201002093309.109180-6-naush@raspberrypi.com>","date":"2020-10-02T09:33:09","name":"[libcamera-devel,5/5] DNI: qcam: Simple test to pass controls on camera::start()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b947d50b9463a79b7edee3197dcde78937c312a5","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9903/mbox/","series":[{"id":1345,"url":"https://patchwork.libcamera.org/api/1.1/series/1345/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1345","date":"2020-10-02T09:33:04","name":"RFQ: Pass controls on camera:start()","version":1,"mbox":"https://patchwork.libcamera.org/series/1345/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9903/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9903/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A320C3B5B\n\tfor ;\n\tFri, 2 Oct 2020 09:33:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5446563B27;\n\tFri, 2 Oct 2020 11:33:20 +0200 (CEST)","from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC51163B32\n\tfor ;\n\tFri, 2 Oct 2020 11:33:17 +0200 (CEST)","by mail-wr1-x435.google.com with SMTP id s12so1008193wrw.11\n\tfor ;\n\tFri, 02 Oct 2020 02:33:17 -0700 (PDT)","from naushir-VirtualBox.pitowers.org\n\t([2a00:1098:3142:14:a00:27ff:fe4d:f6a2])\n\tby smtp.gmail.com with ESMTPSA id\n\tt203sm1101145wmg.43.2020.10.02.02.33.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 02 Oct 2020 02:33:16 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"kYCteFNK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=zWOIeY/4BBoHvefHC8wdDNSshs9CTSgjzBE6ohOV7Po=;\n\tb=kYCteFNKCsoNjTQRTVQfDiOe2mE7ifjtyBVaTX6XkzuWhoqaNxTWsI5obuJGOwoCIe\n\tv2B6TvGZoscLItj9fCT1e5I5QFa1AnN0Ax4f1yTTtI86RL0PQn7yzZAbf9o0OiAH4rIt\n\tDQtN+7MsNIABFBbLPgwu5QGrmkKjlak6+LnvM2QZWDJbsOiWkgtVt6ngaOlZLmDLz98L\n\t2RjaFKyxzyC2kbtIWizUrT4bH1mXYG6/84Xbpfv8Nri34Hmtqn0xhflW4qEGwXLmKQ9M\n\taj1/G8yGxhOJ+XH8Le4XNXvrwhlpDszaIi2lSp1hKn1I/4sJ4ZJ+bNnjYvaDzxREAipu\n\tpmYA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=zWOIeY/4BBoHvefHC8wdDNSshs9CTSgjzBE6ohOV7Po=;\n\tb=ZUFA+c7/3GspFJ6365P2b5jlw9HDIihi7H3fkPUt7tN0dxnP1jJjY3r4pMLiPmDb4s\n\tWUAMYq0LCTElLw+6QdQZHlJRyW42UoDFZGcq4t53rtJc9LtFRsMMBwJc3R3rx1Ikazyu\n\t3MAuSlKJIWt14lUHRDWpcuy1owCUjkhNJNBSrB9F1qyfBHTeEnrrPiFcqzlP4Y66e+Zv\n\t9BOPq+YZLsro27sevcgcdngClmdDJMchEiZyb/vmCvgBi/+agyyAoZZNfoaGWrEKD7KH\n\tD7IdllK3AlD7eTqOG1PXTxpdWnG6xvnRUmJKOz6f1e06jiQzNiXv8IcImu4oeohvtrmv\n\tG8GA==","X-Gm-Message-State":"AOAM531WuFk0NsobHaj8qQDyH2dt9CHkyVYOB+RGFSoCJGeGJUiUPLj1\n\tC5S6Nmqlm6FF2bkjvKUYt0u+Zjo5C/ZHfg==","X-Google-Smtp-Source":"ABdhPJzbndcOy5YoDEM3TDY/0Ji46Iz16tub26wcO0Tygnbj1bQjbpBBf2kP9qL6/P3qixX3PIAjxQ==","X-Received":"by 2002:adf:ffd0:: with SMTP id\n\tx16mr2019933wrs.104.1601631197311; \n\tFri, 02 Oct 2020 02:33:17 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Oct 2020 10:33:09 +0100","Message-Id":"<20201002093309.109180-6-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201002093309.109180-1-naush@raspberrypi.com>","References":"<20201002093309.109180-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 5/5] DNI: qcam: Simple test to pass\n\tcontrols on camera::start()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"DO NOT MERGE\n---\n src/qcam/main_window.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex ecb9dd66..cb24eb11 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -25,6 +25,7 @@\n #include \n \n #include \n+#include \n #include \n \n #include \"dng_writer.h\"\n@@ -367,6 +368,7 @@ void MainWindow::toggleCapture(bool start)\n int MainWindow::startCapture()\n {\n \tStreamRoles roles = StreamKeyValueParser::roles(options_[OptStream]);\n+\tControlList controls(libcamera::controls::controls);\n \tstd::vector requests;\n \tint ret;\n \n@@ -509,7 +511,10 @@ int MainWindow::startCapture()\n \tframesCaptured_ = 0;\n \tlastBufferTime_ = 0;\n \n-\tret = camera_->start();\n+\tcontrols.set(libcamera::controls::AeEnable, false);\n+\tcontrols.set(libcamera::controls::ExposureTime, 60000);\n+\tcontrols.set(libcamera::controls::AnalogueGain, 6.0);\n+\tret = camera_->start(&controls);\n \tif (ret) {\n \t\tqInfo() << \"Failed to start capture\";\n \t\tgoto error;\n","prefixes":["libcamera-devel","5/5"]}