{"id":9896,"url":"https://patchwork.libcamera.org/api/1.1/patches/9896/?format=json","web_url":"https://patchwork.libcamera.org/patch/9896/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201002004349.13258-1-laurent.pinchart@ideasonboard.com>","date":"2020-10-02T00:43:49","name":"[libcamera-devel] utils: hooks: pre-push: Accept Acked-by in addition to Reviewed-by","commit_ref":"ef4bc8d101d1958fc50c1cc84b607a0edd7f621f","pull_url":null,"state":"accepted","archived":false,"hash":"02aecb77a309b3621b23fd23e8d9234b347920c7","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9896/mbox/","series":[{"id":1343,"url":"https://patchwork.libcamera.org/api/1.1/series/1343/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1343","date":"2020-10-02T00:43:49","name":"[libcamera-devel] utils: hooks: pre-push: Accept Acked-by in addition to Reviewed-by","version":1,"mbox":"https://patchwork.libcamera.org/series/1343/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9896/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9896/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7FF7C3B5C\n\tfor ;\n\tFri, 2 Oct 2020 00:44:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6CE7060BCD;\n\tFri, 2 Oct 2020 02:44:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9042F60363\n\tfor ;\n\tFri, 2 Oct 2020 02:44:30 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 201F9255\n\tfor ;\n\tFri, 2 Oct 2020 02:44:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wCpDrZkf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601599470;\n\tbh=UsmdvHxi8u4xXoaAqhVF+vYWmbalzyIgOW4Lc/BCJWI=;\n\th=From:To:Subject:Date:From;\n\tb=wCpDrZkfXazpyIUwrpZk1ZD4uIHTuusRJB0XiP8oJkuQL66MsKOujsIbwbAht8KU7\n\ti8dnAN6nbpwB6WNa0yf6d+umj3gAQqh0s9RnZjVriecR2oPNBS5IqjB1NSPwNYzk+v\n\thQbsHqwY5LpegtT/T8/R3oCWAHFfFUm3Ij5toBG0=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Oct 2020 03:43:49 +0300","Message-Id":"<20201002004349.13258-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] utils: hooks: pre-push: Accept Acked-by\n\tin addition to Reviewed-by","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Allow pushing commits that have no Reviewed-by tag but have at least one\nAcked-by tag.\n\nSigned-off-by: Laurent Pinchart \n---\n utils/hooks/pre-push | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/utils/hooks/pre-push b/utils/hooks/pre-push\nindex 5dc8addabeb6..2417d379db4c 100755\n--- a/utils/hooks/pre-push\n+++ b/utils/hooks/pre-push\n@@ -57,10 +57,10 @@ do\n \t\t\terrors=$((errors+1))\n \t\tfi\n \n-\t\t# 3. A Reviewed-by is required.\n-\t\tif ! echo \"$msg\" | grep -q '^Reviewed-by: '\n+\t\t# 3. A Reviewed-by or Acked-by is required.\n+\t\tif ! echo \"$msg\" | grep -q '^\\(Reviewed\\|Acked\\)-by: '\n \t\tthen\n-\t\t\techo >&2 \"No Reviewed-by in commit $commit\"\n+\t\t\techo >&2 \"No Reviewed-by or Acked-by in commit $commit\"\n \t\t\terrors=$((errors+1))\n \t\tfi\n \tdone\n","prefixes":["libcamera-devel"]}