{"id":9875,"url":"https://patchwork.libcamera.org/api/1.1/patches/9875/?format=json","web_url":"https://patchwork.libcamera.org/patch/9875/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200930132707.19367-4-jacopo@jmondi.org>","date":"2020-09-30T13:27:01","name":"[libcamera-devel,v4,3/9] libcamera: frame_buffer_allocator: Add freeAll()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ad20df2866245a5573849cc3ca25fc10c5a34038","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9875/mbox/","series":[{"id":1340,"url":"https://patchwork.libcamera.org/api/1.1/series/1340/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1340","date":"2020-09-30T13:26:58","name":"android: camera_device: Add support for internal buffers","version":4,"mbox":"https://patchwork.libcamera.org/series/1340/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9875/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9875/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E430C3B5E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 30 Sep 2020 13:23:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0ADAE6238E;\n\tWed, 30 Sep 2020 15:23:23 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CDC2760364\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 30 Sep 2020 15:23:21 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 5408FC000A;\n\tWed, 30 Sep 2020 13:23:20 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 30 Sep 2020 15:27:01 +0200","Message-Id":"<20200930132707.19367-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200930132707.19367-1-jacopo@jmondi.org>","References":"<20200930132707.19367-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 3/9] libcamera: frame_buffer_allocator:\n\tAdd freeAll()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"hanlinchen@chromium.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Add a freeAll() method to the FrameBufferAllocator class that\nfrees all the buffers previously reserved by the allocator.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/framebuffer_allocator.h | 1 +\n src/libcamera/framebuffer_allocator.cpp   | 8 ++++++++\n 2 files changed, 9 insertions(+)","diff":"diff --git a/include/libcamera/framebuffer_allocator.h b/include/libcamera/framebuffer_allocator.h\nindex a96aaeae58ce..3394e9923584 100644\n--- a/include/libcamera/framebuffer_allocator.h\n+++ b/include/libcamera/framebuffer_allocator.h\n@@ -28,6 +28,7 @@ public:\n \n \tint allocate(Stream *stream);\n \tint free(Stream *stream);\n+\tvoid freeAll();\n \n \tbool allocated() const { return !buffers_.empty(); }\n \tconst std::vector<std::unique_ptr<FrameBuffer>> &buffers(Stream *stream) const;\ndiff --git a/src/libcamera/framebuffer_allocator.cpp b/src/libcamera/framebuffer_allocator.cpp\nindex 2fbba37a1b0b..8dbe94ad1ce6 100644\n--- a/src/libcamera/framebuffer_allocator.cpp\n+++ b/src/libcamera/framebuffer_allocator.cpp\n@@ -125,6 +125,14 @@ int FrameBufferAllocator::free(Stream *stream)\n \treturn 0;\n }\n \n+/**\n+ * \\brief Free all the buffers previously allocated\n+ */\n+void FrameBufferAllocator::freeAll()\n+{\n+\tbuffers_.clear();\n+}\n+\n /**\n  * \\fn FrameBufferAllocator::allocated()\n  * \\brief Check if the allocator has allocated buffers for any stream\n","prefixes":["libcamera-devel","v4","3/9"]}