{"id":9874,"url":"https://patchwork.libcamera.org/api/1.1/patches/9874/?format=json","web_url":"https://patchwork.libcamera.org/patch/9874/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200930132707.19367-3-jacopo@jmondi.org>","date":"2020-09-30T13:27:00","name":"[libcamera-devel,v4,2/9] android: camera_device: Add frame allocator","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"fc0ceeddb2107adcf646c70b95dc027358ef7745","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9874/mbox/","series":[{"id":1340,"url":"https://patchwork.libcamera.org/api/1.1/series/1340/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1340","date":"2020-09-30T13:26:58","name":"android: camera_device: Add support for internal buffers","version":4,"mbox":"https://patchwork.libcamera.org/series/1340/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9874/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9874/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0BD7AC3B5B\n\tfor ;\n\tWed, 30 Sep 2020 13:23:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB3736237A;\n\tWed, 30 Sep 2020 15:23:22 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F165622B5\n\tfor ;\n\tWed, 30 Sep 2020 15:23:20 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id BC660C000B;\n\tWed, 30 Sep 2020 13:23:18 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 30 Sep 2020 15:27:00 +0200","Message-Id":"<20200930132707.19367-3-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200930132707.19367-1-jacopo@jmondi.org>","References":"<20200930132707.19367-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 2/9] android: camera_device: Add frame\n\tallocator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a FrameBufferAllocator to the CameraDevice class to handle any\nallocations required to satisfy internal stream requirements.\n\nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \nReviewed-by: Niklas Söderlund \nReviewed-by: Hirokazu Honda \nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 4 ++--\n src/android/camera_device.h | 2 ++\n 2 files changed, 4 insertions(+), 2 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex e4ffbc02c2da..d8587647f831 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -211,8 +211,8 @@ CameraDevice::Camera3RequestDescriptor::~Camera3RequestDescriptor()\n */\n \n CameraDevice::CameraDevice(unsigned int id, const std::shared_ptr &camera)\n-\t: id_(id), running_(false), camera_(camera), staticMetadata_(nullptr),\n-\t facing_(CAMERA_FACING_FRONT), orientation_(0)\n+\t: id_(id), running_(false), camera_(camera), allocator_(camera),\n+\t staticMetadata_(nullptr), facing_(CAMERA_FACING_FRONT), orientation_(0)\n {\n \tcamera_->requestCompleted.connect(this, &CameraDevice::requestComplete);\n \ndiff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 17de963f5fc4..75e3305089d9 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -16,6 +16,7 @@\n \n #include \n #include \n+#include \n #include \n #include \n #include \n@@ -206,6 +207,7 @@ private:\n \tbool running_;\n \tstd::shared_ptr camera_;\n \tstd::unique_ptr config_;\n+\tlibcamera::FrameBufferAllocator allocator_;\n \n \tCameraMetadata *staticMetadata_;\n \tstd::map requestTemplates_;\n","prefixes":["libcamera-devel","v4","2/9"]}