{"id":9828,"url":"https://patchwork.libcamera.org/api/1.1/patches/9828/?format=json","web_url":"https://patchwork.libcamera.org/patch/9828/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200925140525.91943-1-tomi.valkeinen@iki.fi>","date":"2020-09-25T14:05:25","name":"[libcamera-devel] FrameBufferAllocator: fix non-copyability","commit_ref":"f517960c6a41d3098a2e23bdf490d86fad5aa395","pull_url":null,"state":"accepted","archived":false,"hash":"de1c0f187112250aaa00311fd3a99bdc2f2c4c43","submitter":{"id":70,"url":"https://patchwork.libcamera.org/api/1.1/people/70/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@iki.fi"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9828/mbox/","series":[{"id":1327,"url":"https://patchwork.libcamera.org/api/1.1/series/1327/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1327","date":"2020-09-25T14:05:25","name":"[libcamera-devel] FrameBufferAllocator: fix non-copyability","version":1,"mbox":"https://patchwork.libcamera.org/series/1327/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9828/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9828/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21E6EC3B5C\n\tfor ;\n\tFri, 25 Sep 2020 14:06:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 95A0363021;\n\tFri, 25 Sep 2020 16:06:24 +0200 (CEST)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B17F62FD8\n\tfor ;\n\tFri, 25 Sep 2020 16:06:23 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id y4so2578318ljk.8\n\tfor ;\n\tFri, 25 Sep 2020 07:06:23 -0700 (PDT)","from deskari.ti.com (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\tu20sm2329672lfo.156.2020.09.25.07.06.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 25 Sep 2020 07:06:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"uscEgmSd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=YDoFpj5E4PD0gmKE341p+jnjq57+qnDQJjf5B/pjoXA=;\n\tb=uscEgmSd0Bp9gTJ2USypHAJLZUxCd7KWq3UMJABw11fby5LsdtDuTBA/vKKbkhXBhZ\n\tdlSrXEJlDfPZut23LRkJKlBZlZ40NA1+NZ++xj61nMjrvNCyL4DEsvmn+oQd6mA8bOMI\n\tPGo50aunSUVVrgHwrg5Ttp5GrSIeXK7seCZm/bMgAvTp3fXS08VnY6M23T5NnAsomDqp\n\tXAr4xkIs3+TbioO5MKUBq1Oxava+X1hcZog9MVYV0MXnCyIqsGmlN1c1boVYWBWeRJr5\n\tuZ2ooQ0ZD4EiDIvo53DgA8PfF6dk6ONbhO57+1pq/ZUPuGrpPiACS6RUwJ+d+EcSIkQD\n\thE1Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:mime-version:content-transfer-encoding;\n\tbh=YDoFpj5E4PD0gmKE341p+jnjq57+qnDQJjf5B/pjoXA=;\n\tb=kP+rZh0Zal3CYMVwB8z06CGM0tQaQYU/XfS6JOQ+GcgEf6eLheqG60eoSQMAiNz3oK\n\tNVnI+iODLa7HajWeYimJsV1MoHJ7cxi6sKX3RoYUx8zvgBBSZyser4y0Pp81p7rECPNR\n\tepw9us7efp6wZR3OppVJep1FmnqF0yoCD6DQ/M/qqELlmz3YiDC1ypO280NtDAGialfQ\n\tblb5vZkkzc4Mvnu1RKOSQbDahkgt+ryKBckrdNjSAJv7obVljVqkABom+B+uSVZzbRj2\n\tkNvySsry/D4GmY5ubNurv6h2Up4NHCtmTjbEbYJf33oPjnMkz2MDwKv9Z1ujvorp61Vs\n\tlxVw==","X-Gm-Message-State":"AOAM5300+gnUu0Xl1gW1/u2UIONFelaf+028ARbLEAlisV/ZoCvIMQZl\n\tlIIZDA+Q5wYlJjecQjklkaPeUnhdlknBbg==","X-Google-Smtp-Source":"ABdhPJzLJPWIEdnPyWCH43K/oAzWYEEFtud25h7YY+TsufMBhiGKPwQDo1HPKdtlqyzi2/aCZTcjHg==","X-Received":"by 2002:a05:651c:107b:: with SMTP id\n\ty27mr1314974ljm.338.1601042782384; \n\tFri, 25 Sep 2020 07:06:22 -0700 (PDT)","From":"Tomi Valkeinen ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 25 Sep 2020 17:05:25 +0300","Message-Id":"<20200925140525.91943-1-tomi.valkeinen@iki.fi>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] FrameBufferAllocator: fix non-copyability","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Tomi Valkeinen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"FrameBufferAllocator is supposed to delete copy constructor and\ncopy-assignment operator. It doesn't do that as it uses Camera as a\nparameter instead of FrameBufferAllocator.\n\nSigned-off-by: Tomi Valkeinen \n---\n include/libcamera/framebuffer_allocator.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/framebuffer_allocator.h b/include/libcamera/framebuffer_allocator.h\nindex 78f1353..a96aaea 100644\n--- a/include/libcamera/framebuffer_allocator.h\n+++ b/include/libcamera/framebuffer_allocator.h\n@@ -21,8 +21,8 @@ class FrameBufferAllocator\n {\n public:\n \tFrameBufferAllocator(std::shared_ptr camera);\n-\tFrameBufferAllocator(const Camera &) = delete;\n-\tFrameBufferAllocator &operator=(const Camera &) = delete;\n+\tFrameBufferAllocator(const FrameBufferAllocator &) = delete;\n+\tFrameBufferAllocator &operator=(const FrameBufferAllocator &) = delete;\n \n \t~FrameBufferAllocator();\n \n","prefixes":["libcamera-devel"]}