{"id":9793,"url":"https://patchwork.libcamera.org/api/1.1/patches/9793/?format=json","web_url":"https://patchwork.libcamera.org/patch/9793/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200924145143.117733-3-jacopo@jmondi.org>","date":"2020-09-24T14:51:42","name":"[libcamera-devel,2/3] libcamera: ipu3: Remove dead code check","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a37217cb6aecd31829e77acbbb588a2d9e4b6bfb","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9793/mbox/","series":[{"id":1323,"url":"https://patchwork.libcamera.org/api/1.1/series/1323/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1323","date":"2020-09-24T14:51:40","name":"libcamera: ipu3: Fix RAW+YUV capture","version":1,"mbox":"https://patchwork.libcamera.org/series/1323/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9793/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9793/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1F7EC3B5B\n\tfor ;\n\tThu, 24 Sep 2020 14:47:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 64AE663009;\n\tThu, 24 Sep 2020 16:47:58 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A201860367\n\tfor ;\n\tThu, 24 Sep 2020 16:47:56 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 42E1924000B;\n\tThu, 24 Sep 2020 14:47:56 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 24 Sep 2020 16:51:42 +0200","Message-Id":"<20200924145143.117733-3-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200924145143.117733-1-jacopo@jmondi.org>","References":"<20200924145143.117733-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/3] libcamera: ipu3: Remove dead code\n\tcheck","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Since the re-implementation of the IPU3 pipeline handler\nconfiguration procedure, the main output is always assigned in\ncase any YUV stream is requested.\n\nRemove a dead code block that checks for the main output to be\nvalid.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 6 ------\n 1 file changed, 6 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 9cea6c7e9611..477f85a45755 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -501,12 +501,6 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \t * the configuration of the active one for that purpose (there should\n \t * be at least one active stream in the configuration request).\n \t */\n-\tif (!mainCfg) {\n-\t\tret = imgu->configureOutput(*vfCfg, &outputFormat);\n-\t\tif (ret)\n-\t\t\treturn ret;\n-\t}\n-\n \tif (!vfCfg) {\n \t\tret = imgu->configureViewfinder(*mainCfg, &outputFormat);\n \t\tif (ret)\n","prefixes":["libcamera-devel","2/3"]}