{"id":9786,"url":"https://patchwork.libcamera.org/api/1.1/patches/9786/?format=json","web_url":"https://patchwork.libcamera.org/patch/9786/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200924100201.353624-1-kieran.bingham@ideasonboard.com>","date":"2020-09-24T10:02:01","name":"[libcamera-devel,RFC] ipa: rpi: Make boost optional","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"2d7df351a92b577d66aa331efee7fa26b6587200","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/1.1/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/9786/mbox/","series":[{"id":1320,"url":"https://patchwork.libcamera.org/api/1.1/series/1320/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1320","date":"2020-09-24T10:02:01","name":"[libcamera-devel,RFC] ipa: rpi: Make boost optional","version":1,"mbox":"https://patchwork.libcamera.org/series/1320/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9786/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9786/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0503C3B5B\n\tfor ;\n\tThu, 24 Sep 2020 10:02:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6023C62FDA;\n\tThu, 24 Sep 2020 12:02:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8F4A60363\n\tfor ;\n\tThu, 24 Sep 2020 12:02:05 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 45C612FD;\n\tThu, 24 Sep 2020 12:02:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DSlgRgrb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600941725;\n\tbh=1SUOL2WDm9p2n2YsG+jKWNLd4tjBULuxJuhEDmTsENY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=DSlgRgrbpO1hZMqtE6swNyzt8g3Q5tRK6M6B7WdlhrCdyxdDtDBk/vH1qw/Epa5GE\n\tYbyeex3YplhJZMziV2o5R2Z+h/39qhRQkr/YxunZtWStvy/kswoq31FUY3Zr0IK26+\n\tRtAFuh+fB7QOKoPP/Xy6Z4vAFku/x2XTwqnjmtCU=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Thu, 24 Sep 2020 11:02:01 +0100","Message-Id":"<20200924100201.353624-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC PATCH] ipa: rpi: Make boost optional","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"By default the Raspberry Pi pipeline handler is enabled when\nconfiguring the build.\n\nThe Raspberry Pi IPA currently depends upon 'boost' which is a large\ndependency to bring in.\n\nMake the IPA compilation dependant upon the availabilty of the boost\nlibrary, but display a warning when the pipeline is enabled and the\ndependency is not found.\n\nSigned-off-by: Kieran Bingham \n---\n\nThis is mostly posted to promote discussion on this topic.\n\nThe requirement for boost is really heavy (+100MB package for a few\nheaders), and is only used for the RPi IPA.\n\nThis patch automatically disables the IPA while printing a message if it\nwas selected if the boost library is not available.\n\nDoing all of this in a clean way seems quite difficult because of the\nway the meson options works ... so ... \n\n3 ... 2 ... 1 ....\n\n Discuss...\n\n\n src/ipa/raspberrypi/meson.build | 40 +++++++++++++++++++--------------\n 1 file changed, 23 insertions(+), 17 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build\nindex 9445cd097df5..b284378c9621 100644\n--- a/src/ipa/raspberrypi/meson.build\n+++ b/src/ipa/raspberrypi/meson.build\n@@ -2,9 +2,11 @@\n \n ipa_name = 'ipa_rpi'\n \n+boost = dependency('boost', required : false)\n+\n rpi_ipa_deps = [\n libcamera_dep,\n- dependency('boost'),\n+ boost,\n libatomic,\n ]\n \n@@ -41,22 +43,26 @@ rpi_ipa_sources = files([\n 'controller/pwl.cpp',\n ])\n \n-mod = shared_module(ipa_name,\n- rpi_ipa_sources,\n- name_prefix : '',\n- include_directories : rpi_ipa_includes,\n- dependencies : rpi_ipa_deps,\n- link_with : libipa,\n- install : true,\n- install_dir : ipa_install_dir)\n-\n-if ipa_sign_module\n- custom_target(ipa_name + '.so.sign',\n- input : mod,\n- output : ipa_name + '.so.sign',\n- command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],\n- install : false,\n- build_by_default : true)\n+if boost.found()\n+ mod = shared_module(ipa_name,\n+ rpi_ipa_sources,\n+ name_prefix : '',\n+ include_directories : rpi_ipa_includes,\n+ dependencies : rpi_ipa_deps,\n+ link_with : libipa,\n+ install : true,\n+ install_dir : ipa_install_dir)\n+\n+ if ipa_sign_module\n+ custom_target(ipa_name + '.so.sign',\n+ input : mod,\n+ output : ipa_name + '.so.sign',\n+ command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],\n+ install : false,\n+ build_by_default : true)\n+ endif\n+else\n+ warning('The Raspberry Pi pipeline is enabled, but dependency \"boost\" was not found')\n endif\n \n subdir('data')\n","prefixes":["libcamera-devel","RFC"]}