{"id":9722,"url":"https://patchwork.libcamera.org/api/1.1/patches/9722/?format=json","web_url":"https://patchwork.libcamera.org/patch/9722/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200922133537.258098-19-paul.elder@ideasonboard.com>","date":"2020-09-22T13:35:17","name":"[libcamera-devel,18/38] libcamera: IPAProxy: Remove stop() override","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9048e78e3804a130af1623ccc0fbbfa8c2b84715","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9722/mbox/","series":[{"id":1309,"url":"https://patchwork.libcamera.org/api/1.1/series/1309/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1309","date":"2020-09-22T13:34:59","name":"IPA isolation implementation","version":1,"mbox":"https://patchwork.libcamera.org/series/1309/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9722/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9722/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B316DBF01C\n\tfor ;\n\tTue, 22 Sep 2020 13:38:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 808AB62FEC;\n\tTue, 22 Sep 2020 15:38:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACA8460576\n\tfor ;\n\tTue, 22 Sep 2020 15:38:00 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 796B32D7;\n\tTue, 22 Sep 2020 15:37:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VEBmUZVv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600781876;\n\tbh=2zbh3OLBAi3Nh9A8++GRcAPjNOtBVkeKZRVj7/n87Kc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=VEBmUZVvBdFoyOck8BoZtMUthdDMXlvrw3x6dz/3P6rhC8zqkHUDAgL4UPqfHk/Mi\n\t4F8U3HB0YuwMNy6mo1yTqT+I/Tb+q5SL/USuj90oVx2z/RNw3tLMfbKjMpMD5yFGCy\n\tHYQro8OSWgUVAG0GuB0QEqkxnsTRieaXIdyQmYqc=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 22 Sep 2020 22:35:17 +0900","Message-Id":"<20200922133537.258098-19-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200922133537.258098-1-paul.elder@ideasonboard.com>","References":"<20200922133537.258098-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 18/38] libcamera: IPAProxy: Remove stop()\n\toverride","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Since stop() is part of the IPA interface, and the IPA interface is now\ngenerated based on the data definition file per pipeline, this no longer\nneeds to be overrided by the base IPAProxy. Remove it.\n\nSigned-off-by: Paul Elder \nReviewed-by: Niklas Söderlund \n\n---\nChanges in v2:\n- remove documentation\n---\n include/libcamera/internal/ipa_proxy.h | 2 --\n src/libcamera/ipa_proxy.cpp | 10 ----------\n 2 files changed, 12 deletions(-)","diff":"diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\nindex b429ce5a..aec8f04f 100644\n--- a/include/libcamera/internal/ipa_proxy.h\n+++ b/include/libcamera/internal/ipa_proxy.h\n@@ -27,8 +27,6 @@ public:\n \n \tstd::string configurationFile(const std::string &file) const;\n \n-\tvoid stop() override = 0;\n-\n protected:\n \tstd::string resolvePath(const std::string &file) const;\n \ndiff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\nindex ff4d7fd1..23be24ad 100644\n--- a/src/libcamera/ipa_proxy.cpp\n+++ b/src/libcamera/ipa_proxy.cpp\n@@ -145,16 +145,6 @@ std::string IPAProxy::configurationFile(const std::string &name) const\n \treturn std::string();\n }\n \n-/**\n- * \\fn IPAProxy::stop()\n- * \\brief Stop the IPA proxy\n- *\n- * This function stops the IPA and releases all the resources acquired by the\n- * proxy in start(). Calling stop() when the IPA proxy hasn't been started or\n- * has already been stopped is valid, the proxy shall treat this as a no-op and\n- * shall not forward the call to the IPA.\n- */\n-\n /**\n * \\brief Find a valid full path for a proxy worker for a given executable name\n * \\param[in] file File name of proxy worker executable\n","prefixes":["libcamera-devel","18/38"]}