{"id":972,"url":"https://patchwork.libcamera.org/api/1.1/patches/972/?format=json","web_url":"https://patchwork.libcamera.org/patch/972/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190414013506.10515-4-niklas.soderlund@ragnatech.se>","date":"2019-04-14T01:34:58","name":"[libcamera-devel,RFC,03/11] libcamera: media_device: Only read device information in populate()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2229f1b9db780ac3c1895c12d6d8164a49a5a128","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/972/mbox/","series":[{"id":249,"url":"https://patchwork.libcamera.org/api/1.1/series/249/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=249","date":"2019-04-14T01:34:55","name":"libcamerea: Add support for exclusive access to cameras between processes","version":1,"mbox":"https://patchwork.libcamera.org/series/249/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/972/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/972/checks/","tags":{},"headers":{"Return-Path":"","Received":["from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C23E60DC0\n\tfor ;\n\tSun, 14 Apr 2019 03:35:16 +0200 (CEST)","from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 8dc58b34-5e55-11e9-8e2c-005056917f90;\n\tSun, 14 Apr 2019 03:35:15 +0200 (CEST)"],"X-Halon-ID":"8dc58b34-5e55-11e9-8e2c-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 14 Apr 2019 03:34:58 +0200","Message-Id":"<20190414013506.10515-4-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190414013506.10515-1-niklas.soderlund@ragnatech.se>","References":"<20190414013506.10515-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC 03/11] libcamera: media_device: Only read\n\tdevice information in populate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 14 Apr 2019 01:35:17 -0000"},"content":"There is no reason to reread the MEDIA_IOC_DEVICE_INFO information every\ntime the media device is opened. Move it populate() where it will be\nread once together the other information about the media device.\n\nSigned-off-by: Niklas Söderlund \n---\n src/libcamera/media_device.cpp | 31 ++++++++++++++-----------------\n 1 file changed, 14 insertions(+), 17 deletions(-)","diff":"diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\nindex ecb00a1d5abffe80..54706bb73a7591d5 100644\n--- a/src/libcamera/media_device.cpp\n+++ b/src/libcamera/media_device.cpp\n@@ -131,9 +131,6 @@ bool MediaDevice::acquire()\n * with the device node associated with the media device, the device node must\n * be opened.\n *\n- * This function also retrieves media device information from the device node,\n- * which can be queried through driver().\n- *\n * If the device is already open the function returns -EBUSY.\n *\n * \\return 0 on success or a negative error code otherwise\n@@ -155,20 +152,6 @@ int MediaDevice::open()\n \t}\n \tfd_ = ret;\n \n-\tstruct media_device_info info = { };\n-\tret = ioctl(fd_, MEDIA_IOC_DEVICE_INFO, &info);\n-\tif (ret) {\n-\t\tret = -errno;\n-\t\tLOG(MediaDevice, Error)\n-\t\t\t<< \"Failed to get media device info \"\n-\t\t\t<< \": \" << strerror(-ret);\n-\t\treturn ret;\n-\t}\n-\n-\tdriver_ = info.driver;\n-\tmodel_ = info.model;\n-\tversion_ = info.media_version;\n-\n \treturn 0;\n }\n \n@@ -224,6 +207,20 @@ int MediaDevice::populate()\n \tif (ret)\n \t\treturn ret;\n \n+\tstruct media_device_info info = {};\n+\tret = ioctl(fd_, MEDIA_IOC_DEVICE_INFO, &info);\n+\tif (ret) {\n+\t\tret = -errno;\n+\t\tLOG(MediaDevice, Error)\n+\t\t\t<< \"Failed to get media device info \"\n+\t\t\t<< \": \" << strerror(-ret);\n+\t\tgoto err_out;\n+\t}\n+\n+\tdriver_ = info.driver;\n+\tmodel_ = info.model;\n+\tversion_ = info.media_version;\n+\n \t/*\n \t * Keep calling G_TOPOLOGY until the version number stays stable.\n \t */\n","prefixes":["libcamera-devel","RFC","03/11"]}