{"id":9708,"url":"https://patchwork.libcamera.org/api/1.1/patches/9708/?format=json","web_url":"https://patchwork.libcamera.org/patch/9708/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200922133537.258098-4-paul.elder@ideasonboard.com>","date":"2020-09-22T13:35:02","name":"[libcamera-devel,03/38] libcamera: PipelineHandler: Move printing pipeline names to CameraManager","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0b5f6b8c3baefa1b913f86373c9f91d96b945f11","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9708/mbox/","series":[{"id":1309,"url":"https://patchwork.libcamera.org/api/1.1/series/1309/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1309","date":"2020-09-22T13:34:59","name":"IPA isolation implementation","version":1,"mbox":"https://patchwork.libcamera.org/series/1309/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9708/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9708/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60EE3C3B5B\n\tfor ;\n\tTue, 22 Sep 2020 13:36:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D03062FD6;\n\tTue, 22 Sep 2020 15:36:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1DE986036A\n\tfor ;\n\tTue, 22 Sep 2020 15:36:13 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 733FA2D7;\n\tTue, 22 Sep 2020 15:36:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pSyCYZ4c\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600781768;\n\tbh=pp/pxil0BH0CrkK/Y8RZWQxxKMwA6N0SaS2i4+QVlIM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pSyCYZ4cPzvFynQdzKjS8qw2x4LMne1CfDuhePsrDtWSKXFxuojqfHIIFw9lLG4Bb\n\tsFeVyzKtIjGe7xwwededIruYvu1QxGLkvMPxDspuJbIbZlAvEkHSe3ioL1I94ArpIS\n\tonbBWO3qhCu+VTp3XoaD91eaCV/GBWBIsbF5eFFw=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 22 Sep 2020 22:35:02 +0900","Message-Id":"<20200922133537.258098-4-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200922133537.258098-1-paul.elder@ideasonboard.com>","References":"<20200922133537.258098-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 03/38] libcamera: PipelineHandler: Move\n\tprinting pipeline names to CameraManager","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Since pipeline registration is done with declaring static factory\nobjects, there is a risk that pipeline factories will be constructed\nbefore libcamera facilities are ready. For example, logging in the\nconstructor of a pipeline handler factory may cause a segfault if\nthreading isn't ready yet. Avoid this issue by moving printing the\nregistration of the pipeline handler to the camera manager.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \n\n---\nCosmetic changes in v2\n---\n src/libcamera/camera_manager.cpp | 3 +++\n src/libcamera/pipeline_handler.cpp | 3 ---\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex b8d3ccc8..756f5b2b 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -142,6 +142,9 @@ void CameraManager::Private::createPipelineHandlers()\n \t\tPipelineHandlerFactory::factories();\n \n \tfor (PipelineHandlerFactory *factory : factories) {\n+\t\tLOG(Camera, Debug)\n+\t\t\t<< \"Found registered pipeline handler '\"\n+\t\t\t<< factory->name() << \"'\";\n \t\t/*\n \t\t * Try each pipeline handler until it exhaust\n \t\t * all pipelines it can provide.\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 918aea1e..894200ee 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -689,9 +689,6 @@ void PipelineHandlerFactory::registerType(PipelineHandlerFactory *factory)\n \tstd::vector &factories = PipelineHandlerFactory::factories();\n \n \tfactories.push_back(factory);\n-\n-\tLOG(Pipeline, Debug)\n-\t\t<< \"Registered pipeline handler \\\"\" << factory->name() << \"\\\"\";\n }\n \n /**\n","prefixes":["libcamera-devel","03/38"]}