{"id":9652,"url":"https://patchwork.libcamera.org/api/1.1/patches/9652/?format=json","web_url":"https://patchwork.libcamera.org/patch/9652/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200918094233.5273-8-naush@raspberrypi.com>","date":"2020-09-18T09:42:28","name":"[libcamera-devel,v8,07/12] libcamera: pipeline: raspberrypi: Fix bug in passing configuration to IPA","commit_ref":"45430e12ee74a92a46d8f6b92ba6bb647868ba3f","pull_url":null,"state":"accepted","archived":false,"hash":"ef49a90f1640831fa6144d3171847607fbe9e2bd","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9652/mbox/","series":[{"id":1295,"url":"https://patchwork.libcamera.org/api/1.1/series/1295/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1295","date":"2020-09-18T09:42:21","name":"Zero-copy RAW stream work","version":8,"mbox":"https://patchwork.libcamera.org/series/1295/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9652/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9652/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F655C3B5B\n\tfor ;\n\tFri, 18 Sep 2020 09:44:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 044CC62FC7;\n\tFri, 18 Sep 2020 11:44:04 +0200 (CEST)","from mail-wr1-x442.google.com (mail-wr1-x442.google.com\n\t[IPv6:2a00:1450:4864:20::442])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A955062FB9\n\tfor ;\n\tFri, 18 Sep 2020 11:44:01 +0200 (CEST)","by mail-wr1-x442.google.com with SMTP id c18so4930986wrm.9\n\tfor ;\n\tFri, 18 Sep 2020 02:44:01 -0700 (PDT)","from naushir-VirtualBox.pitowers.org\n\t([2a00:1098:3142:14:a00:27ff:fe4d:f6a2])\n\tby smtp.gmail.com with ESMTPSA id\n\tn2sm4792472wma.29.2020.09.18.02.44.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 18 Sep 2020 02:44:00 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Tv1R8ciq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=N8jhUK8hBWFefqL29hZIlulkNawiu+/q5f/uuUe0Gpk=;\n\tb=Tv1R8ciq9xfZYfw4VPgmcfudWhOXAzF3SwJHeczooTJq/P5pYZbbAutpvV2IL+u6lX\n\tgTg91ihlliTpHB0qMybupRXvrOZg+OROBFr8A602vacK+9q/X2wvHQ3W3mwqgtzq8p7z\n\tmCc+vCCHMNgKyhi/44yfB2cYoHvjxnld5CJODLxJZJYdpJhcYkObGuB11TJlu94cxeIe\n\tyu+uvQVh84qoWQsEQxWxLPFQ6C6BmyUm/ADt2dwk/zNNu9+E/a2DpOocwTsLVeaIzb47\n\tNGq0cv0TYrtk/w8JqAL93biL++p3UDUJIC5jWZFI1zu5mv/p30OKOY/9uehLeAZ5pMQy\n\tS7wQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=N8jhUK8hBWFefqL29hZIlulkNawiu+/q5f/uuUe0Gpk=;\n\tb=BubyjqmFURN6okik0LhxXiRZYlJLTzrzNct6ERfmcXgid8g7Vm1eG9sppCvKYcuFBK\n\tcp8XLhysEzAO1rqC7YkcJWgdxHAPAgHaLUU0u5BDKR9nL61DDs5f/vGs7GWcpVhkzLdr\n\t5RdYfg06J02+DLadyEWPlHxDxRml+H0CkRn7b/ruuHPcCQUkV2SUOOZUtJHheNXv5siX\n\tyvvnnkCWjO3f47j6xXSFzBNioOWw6J6o3rq/LyyTHyvv8l27pK7SlBMqIfsI0IBfRRck\n\t+IU9Krd+rGfcjgwgJBnQ72EUBzRsqT9lYj+Av8124w0cnMUJlb8OR4Fqf+J84kFQv7Oz\n\t9e+Q==","X-Gm-Message-State":"AOAM530F2LvJJwlM9uP7acaYE7DgefdLyfpJGy2Jp3I7/jk3qZq5sDcs\n\tziQP5DdFbKst3fS5keFh4J8SDwnenV8DyA==","X-Google-Smtp-Source":"ABdhPJzMel5UH0bBaLkZgRYC1iBdn9vpcujhV6Wr/25ZclsVYSctca1WbG1i89nF/wmSfSul7CkbhA==","X-Received":"by 2002:adf:f843:: with SMTP id\n\td3mr39601463wrq.226.1600422241064; \n\tFri, 18 Sep 2020 02:44:01 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 18 Sep 2020 10:42:28 +0100","Message-Id":"<20200918094233.5273-8-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200918094233.5273-1-naush@raspberrypi.com>","References":"<20200918094233.5273-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v8 07/12] libcamera: pipeline:\n\traspberrypi: Fix bug in passing configuration to IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The counter was not incremented, so multiple streams would only pass the\nlast stream config to the IPA.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Niklas Söderlund \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \nTested-by: David Plowman \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 9fbe5089..3caf3655 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -992,12 +992,13 @@ int RPiCameraData::configureIPA()\n \tunsigned int i = 0;\n \tfor (auto const &stream : isp_) {\n \t\tif (stream.isExternal()) {\n-\t\t\tstreamConfig[i] = {\n+\t\t\tstreamConfig[i++] = {\n \t\t\t\t.pixelFormat = stream.configuration().pixelFormat,\n \t\t\t\t.size = stream.configuration().size\n \t\t\t};\n \t\t}\n \t}\n+\n \tentityControls.emplace(0, unicam_[Unicam::Image].dev()->controls());\n \tentityControls.emplace(1, isp_[Isp::Input].dev()->controls());\n \n","prefixes":["libcamera-devel","v8","07/12"]}