{"id":9648,"url":"https://patchwork.libcamera.org/api/1.1/patches/9648/?format=json","web_url":"https://patchwork.libcamera.org/patch/9648/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200918094233.5273-4-naush@raspberrypi.com>","date":"2020-09-18T09:42:24","name":"[libcamera-devel,v8,03/12] libcamera: pipeline: raspberrypi: Add some debug logging","commit_ref":"dd0a9cf2b19083bbab327fa41892182cd142351a","pull_url":null,"state":"accepted","archived":false,"hash":"de544592e7fa6a43a39eef27a7b629daa441a268","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9648/mbox/","series":[{"id":1295,"url":"https://patchwork.libcamera.org/api/1.1/series/1295/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1295","date":"2020-09-18T09:42:21","name":"Zero-copy RAW stream work","version":8,"mbox":"https://patchwork.libcamera.org/series/1295/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9648/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9648/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C8C6C3B5B\n\tfor ;\n\tFri, 18 Sep 2020 09:44:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49B3B62FB6;\n\tFri, 18 Sep 2020 11:44:01 +0200 (CEST)","from mail-wm1-x343.google.com (mail-wm1-x343.google.com\n\t[IPv6:2a00:1450:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B075162FAF\n\tfor ;\n\tFri, 18 Sep 2020 11:43:57 +0200 (CEST)","by mail-wm1-x343.google.com with SMTP id x23so4667622wmi.3\n\tfor ;\n\tFri, 18 Sep 2020 02:43:57 -0700 (PDT)","from naushir-VirtualBox.pitowers.org\n\t([2a00:1098:3142:14:a00:27ff:fe4d:f6a2])\n\tby smtp.gmail.com with ESMTPSA id\n\tn2sm4792472wma.29.2020.09.18.02.43.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 18 Sep 2020 02:43:56 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"jZXR4TXX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=7z1YhK/QItKgF24LCdggoTXw9ex8XokQHsbkI0ox0fs=;\n\tb=jZXR4TXXdKVf2OrxYWPsAFx2q2uSThoujCNFvYjGMRTiAwmQhZ5npsvATrs0AlCtIg\n\tfmBRzdqPpdPuFjXdTtxsr6yidC2bqHW9lsfcWMQRd2dZexvIHVhYvO22Ud71Oh/iCSKb\n\twrz1tIVcazUL7DoaV6Viz/ErO383ZqIQANnC1PtmVLwWl8e0sghVtWziDyNrX8jwRNzy\n\tHMDaAXrfF7cdTC7saf6sdV12VJG38PAcW24sMUi4eh0PbBh+EYlEtemZKzGufjuQUPU9\n\tJj8QhXRJnwW4F5jc6Vd1oHmlHXTsx8Gibt47ygquV3UX20bhPQPOK582Scuviuocfh4G\n\tW5ag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=7z1YhK/QItKgF24LCdggoTXw9ex8XokQHsbkI0ox0fs=;\n\tb=QwrETdBXdo1ESYgFLuxF9iru87roFXQXPr+65Cp4zKladYK27F+J6flnACQGsdO74w\n\t9X7ULXzuYnNNBsKY57tXzQLjhtclxwJLUP7t9NCsiRkCvyERJkm1SxjfKac/rsMsWjbL\n\tN6gm+R7RpytV03DkXz1IDieXyF6LlV6eEzwFwIEdc1FtcIMo3foYU8kY8r45+gxGOZfl\n\t38DQnySUn1D/LyxC0t4LCKUbmyG4HUrxgsDa0pDzxCY3Y5DIEkvmyrwcFCB5Z+psc909\n\tyyFuibcDFoYSqpvuvS/IyGT7pxnTcWJ9fwwgAPXDAhqYFFDhL1hustmef3iTQ7oBr3F2\n\tC8Tw==","X-Gm-Message-State":"AOAM532idK1+R/OaKtr/9LeBzFnrgbBQRuk0Eb1SCxta6LA8OuyT1GNE\n\tPP7BbMAvSSUvPGk09QMPCQo+8NWZbkyf6w==","X-Google-Smtp-Source":"ABdhPJzF66pZ9vlWw/d8U0e6CapAefqWpJLVoy7sTVvhrn3RV9EmSKCSOHlnrOynEB3fgkWVTP2mug==","X-Received":"by 2002:a05:600c:414e:: with SMTP id\n\th14mr14296194wmm.2.1600422237108; \n\tFri, 18 Sep 2020 02:43:57 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 18 Sep 2020 10:42:24 +0100","Message-Id":"<20200918094233.5273-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200918094233.5273-1-naush@raspberrypi.com>","References":"<20200918094233.5273-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v8 03/12] libcamera: pipeline:\n\traspberrypi: Add some debug logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"No functional changes, only added some more trace points.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Niklas Söderlund \nReviewed-by: Kieran Bingham \nTested-by: David Plowman \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 4c878003..f15345ea 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1162,6 +1162,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n \tif (state_ == State::Stopped)\n \t\treturn;\n \n+\tLOG(RPI, Debug) << \"Stream ISP Input buffer complete\"\n+\t\t\t<< \", buffer id \" << buffer->cookie()\n+\t\t\t<< \", timestamp: \" << buffer->metadata().timestamp;\n+\n+\t/* The ISP input buffer gets re-queued into Unicam. */\n \thandleStreamBuffer(buffer, &unicam_[Unicam::Image]);\n \thandleState();\n }\n@@ -1464,7 +1469,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t\n \t\tif (b->metadata().timestamp < timestamp) {\n \t\t\tq.pop();\n \t\t\tdev->queueBuffer(b);\n-\t\t\tLOG(RPI, Error) << \"Dropping input frame!\";\n+\t\t\tLOG(RPI, Warning) << \"Dropping input frame!\";\n \t\t} else if (b->metadata().timestamp == timestamp) {\n \t\t\t/* The calling function will pop the item from the queue. */\n \t\t\treturn b;\n","prefixes":["libcamera-devel","v8","03/12"]}