{"id":9561,"url":"https://patchwork.libcamera.org/api/1.1/patches/9561/?format=json","web_url":"https://patchwork.libcamera.org/patch/9561/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200909155457.153907-5-jacopo@jmondi.org>","date":"2020-09-09T15:54:53","name":"[libcamera-devel,4/8] android: camera_device: Clear allocator at configureStream","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"be8ad081ac0e5c16f83ae612a3ab1dd91877cc3a","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9561/mbox/","series":[{"id":1282,"url":"https://patchwork.libcamera.org/api/1.1/series/1282/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1282","date":"2020-09-09T15:54:49","name":"android: camera_device: Allocate internal buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/1282/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9561/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9561/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27F3BBDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  9 Sep 2020 15:51:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 04CC362D5E;\n\tWed,  9 Sep 2020 17:51:24 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B2A862D04\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  9 Sep 2020 17:51:22 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 16E301BF20C;\n\tWed,  9 Sep 2020 15:51:20 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed,  9 Sep 2020 17:54:53 +0200","Message-Id":"<20200909155457.153907-5-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200909155457.153907-1-jacopo@jmondi.org>","References":"<20200909155457.153907-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 4/8] android: camera_device: Clear\n\tallocator at configureStream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"hanlinchen@chromium.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The configureStream operation might be called by the Android framework\nin two successive capture session without going through a close().\n\nClear all the allocated buffers before configuring the camera streams.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 98cfa3d5aa59..d35c6b93b654 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1187,6 +1187,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t */\n \tstreams_.clear();\n \tstreams_.reserve(stream_list->num_streams);\n+\tallocator_.clear();\n \n \t/* First handle all non-MJPEG streams. */\n \tcamera3_stream_t *jpegStream = nullptr;\n","prefixes":["libcamera-devel","4/8"]}