{"id":9534,"url":"https://patchwork.libcamera.org/api/1.1/patches/9534/?format=json","web_url":"https://patchwork.libcamera.org/patch/9534/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200908134142.27470-4-jacopo@jmondi.org>","date":"2020-09-08T13:41:34","name":"[libcamera-devel,v3,03/11] android: camera_device: Add debug to stream initialization","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"cc6e9c7fcb41d4990fece57f4ed13d3ae689659f","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9534/mbox/","series":[{"id":1274,"url":"https://patchwork.libcamera.org/api/1.1/series/1274/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1274","date":"2020-09-08T13:41:31","name":"android: camera_device: Fix JPEG/RAW sizes","version":3,"mbox":"https://patchwork.libcamera.org/series/1274/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9534/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9534/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12B98BDB1D\n\tfor ;\n\tTue, 8 Sep 2020 13:38:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E226D62C30;\n\tTue, 8 Sep 2020 15:38:10 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A6A162C66\n\tfor ;\n\tTue, 8 Sep 2020 15:38:08 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 1DFF31C0002;\n\tTue, 8 Sep 2020 13:38:06 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 8 Sep 2020 15:41:34 +0200","Message-Id":"<20200908134142.27470-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200908134142.27470-1-jacopo@jmondi.org>","References":"<20200908134142.27470-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 03/11] android: camera_device: Add\n\tdebug to stream initialization","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add debug printouts to the CameraDevice::initializeStreamConfigurations()\nfunction that help to follow the process of building the stream\nconfigurations map.\n\nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 23 ++++++++++++++++++++++-\n 1 file changed, 22 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 1b2e12d6d33c..17b5fd5f59eb 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -363,12 +363,19 @@ int CameraDevice::initializeStreamConfigurations()\n \t\tconst std::vector &libcameraFormats =\n \t\t\tcamera3Format.libcameraFormats;\n \n+\t\tLOG(HAL, Debug) << \"Trying to map Android format \"\n+\t\t\t\t<< camera3Format.name;\n+\n \t\t/*\n \t\t * JPEG is always supported, either produced directly by the\n \t\t * camera, or encoded in the HAL.\n \t\t */\n \t\tif (androidFormat == HAL_PIXEL_FORMAT_BLOB) {\n \t\t\tformatsMap_[androidFormat] = formats::MJPEG;\n+\t\t\tLOG(HAL, Debug) << \"Mapped Android format \"\n+\t\t\t\t\t<< camera3Format.name << \" to \"\n+\t\t\t\t\t<< formats::MJPEG.toString()\n+\t\t\t\t\t<< \" (fixed mapping)\";\n \t\t\tcontinue;\n \t\t}\n \n@@ -379,6 +386,8 @@ int CameraDevice::initializeStreamConfigurations()\n \t\tPixelFormat mappedFormat;\n \t\tfor (const PixelFormat &pixelFormat : libcameraFormats) {\n \n+\t\t\tLOG(HAL, Debug) << \"Testing \" << pixelFormat.toString();\n+\n \t\t\t/*\n \t\t\t * The stream configuration size can be adjusted,\n \t\t\t * not the pixel format.\n@@ -414,14 +423,26 @@ int CameraDevice::initializeStreamConfigurations()\n \t\t * stream configurations map, by testing the image resolutions.\n \t\t */\n \t\tformatsMap_[androidFormat] = mappedFormat;\n+\t\tLOG(HAL, Debug) << \"Mapped Android format \"\n+\t\t\t\t<< camera3Format.name << \" to \"\n+\t\t\t\t<< mappedFormat.toString();\n \n \t\tfor (const Size &res : cameraResolutions) {\n \t\t\tcfg.pixelFormat = mappedFormat;\n \t\t\tcfg.size = res;\n \n+\t\t\tstd::stringstream ss;\n+\t\t\tss << \"Testing \" << cfg.toString();\n+\n \t\t\tCameraConfiguration::Status status = cameraConfig->validate();\n-\t\t\tif (status != CameraConfiguration::Valid)\n+\t\t\tif (status != CameraConfiguration::Valid) {\n+\t\t\t\tss << \" not supported\";\n+\t\t\t\tLOG(HAL, Debug) << ss.str();\n \t\t\t\tcontinue;\n+\t\t\t}\n+\n+\t\t\tss << \" supported\";\n+\t\t\tLOG(HAL, Debug) << ss.str();\n \n \t\t\tstreamConfigurations_.push_back({ res, androidFormat });\n \n","prefixes":["libcamera-devel","v3","03/11"]}