{"id":9519,"url":"https://patchwork.libcamera.org/api/1.1/patches/9519/?format=json","web_url":"https://patchwork.libcamera.org/patch/9519/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200908074913.109244-4-naush@raspberrypi.com>","date":"2020-09-08T07:49:03","name":"[libcamera-devel,v7,03/12] libcamera: pipeline: raspberrypi: Add some debug logging","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"de544592e7fa6a43a39eef27a7b629daa441a268","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9519/mbox/","series":[{"id":1271,"url":"https://patchwork.libcamera.org/api/1.1/series/1271/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1271","date":"2020-09-08T07:49:00","name":"Zero-copy RAW stream work","version":7,"mbox":"https://patchwork.libcamera.org/series/1271/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9519/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9519/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 773EABDB1C\n\tfor ;\n\tTue, 8 Sep 2020 07:49:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EEFA362C01;\n\tTue, 8 Sep 2020 09:49:22 +0200 (CEST)","from mail-wm1-x343.google.com (mail-wm1-x343.google.com\n\t[IPv6:2a00:1450:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A1AC262931\n\tfor ;\n\tTue, 8 Sep 2020 09:49:21 +0200 (CEST)","by mail-wm1-x343.google.com with SMTP id b79so16132342wmb.4\n\tfor ;\n\tTue, 08 Sep 2020 00:49:21 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tq15sm32534502wrr.8.2020.09.08.00.49.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 08 Sep 2020 00:49:20 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"RPpVGnLH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=7z1YhK/QItKgF24LCdggoTXw9ex8XokQHsbkI0ox0fs=;\n\tb=RPpVGnLHnwjNVgW5lQ8QI0Xj8zAdQdLY8BbrhJ2Fim4zZsIjIspx/DtCWRTSYqAWkJ\n\tiY1pUYt+XT3EVsiydR8qWxfj6mi+aHZfd6iYWrpupCvUTtPy8DQe+zCjHhLNReugqMlW\n\t6gn/eESoeKRhqGZCkmX+7o+IFthJm6/Eb+d/JHvx69wQYOxC/BVP3gSEa4GE7X8hxo5N\n\tEiRUfdxhuNxwsxa+nMtwB7ADYV/UbzJ5Fr/WnRsltXa1HtjJ8V9DBzP/H73UtBiuGei4\n\tuaSOq2P5idSfRGXyRJckyBawL2Wj6XieadBsYqCgUgsZpWGhFsj+0xTy2RpDFtrYU9yX\n\t2WCg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=7z1YhK/QItKgF24LCdggoTXw9ex8XokQHsbkI0ox0fs=;\n\tb=kKBxyV5jJQ9lcUjTV1K4LRHospTYilLLP66joq5aMEZrAC3rvl6uvwAlQtG5kzOJWo\n\t08BH7ne8WYftIqncBXvUOJIB9GQIDylEpfks4ePzGtS7TbnoqZlHJNs+/85gTORPEp2E\n\tJvAL9huS413DWVUc0EbQ0ndwddLvE/JY/f3npOwIeelXubVBtd4QDR3/5zatSGw9Ciie\n\tDZHQFCLPxgtpe6pGq74kxoeniuhiTngpL07d6gu4hdZ8X0VDirJz0EvclnYRgNfINehf\n\t2DvMIZTb9BLqYOEyaOqCK1fJFrIW8hk8Re6hdQ8mZoJqaXqpMqu5B/NVBXOT6KQIuYyF\n\tOlEg==","X-Gm-Message-State":"AOAM533EKb/H1W1VGm+AGPh50Sp8G8WvHXmxWjc0QtMF4REXcZOqoX/L\n\tOMGnzaBSkiK0QGBo2frcmImeGCPgZ9buLg==","X-Google-Smtp-Source":"ABdhPJxqg3KhnoF5g1Ljl+P7o6u2Chz+i3zBjtU21OA2TUuw5uA7N1sAtDkYYm3AjJAARWlC3LHjgQ==","X-Received":"by 2002:a7b:c210:: with SMTP id x16mr2890062wmi.76.1599551361089;\n\tTue, 08 Sep 2020 00:49:21 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 8 Sep 2020 08:49:03 +0100","Message-Id":"<20200908074913.109244-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200908074913.109244-1-naush@raspberrypi.com>","References":"<20200908074913.109244-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v7 03/12] libcamera: pipeline:\n\traspberrypi: Add some debug logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"No functional changes, only added some more trace points.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Niklas Söderlund \nReviewed-by: Kieran Bingham \nTested-by: David Plowman \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 4c878003..f15345ea 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1162,6 +1162,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n \tif (state_ == State::Stopped)\n \t\treturn;\n \n+\tLOG(RPI, Debug) << \"Stream ISP Input buffer complete\"\n+\t\t\t<< \", buffer id \" << buffer->cookie()\n+\t\t\t<< \", timestamp: \" << buffer->metadata().timestamp;\n+\n+\t/* The ISP input buffer gets re-queued into Unicam. */\n \thandleStreamBuffer(buffer, &unicam_[Unicam::Image]);\n \thandleState();\n }\n@@ -1464,7 +1469,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t\n \t\tif (b->metadata().timestamp < timestamp) {\n \t\t\tq.pop();\n \t\t\tdev->queueBuffer(b);\n-\t\t\tLOG(RPI, Error) << \"Dropping input frame!\";\n+\t\t\tLOG(RPI, Warning) << \"Dropping input frame!\";\n \t\t} else if (b->metadata().timestamp == timestamp) {\n \t\t\t/* The calling function will pop the item from the queue. */\n \t\t\treturn b;\n","prefixes":["libcamera-devel","v7","03/12"]}