{"id":9440,"url":"https://patchwork.libcamera.org/api/1.1/patches/9440/?format=json","web_url":"https://patchwork.libcamera.org/patch/9440/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200902104730.43451-4-jacopo@jmondi.org>","date":"2020-09-02T10:47:28","name":"[libcamera-devel,3/5] android: camera_device: Add debug to stream initialization","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9d478f4e24d0e77cfb0de9151cf1e3ac8ca9239d","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9440/mbox/","series":[{"id":1255,"url":"https://patchwork.libcamera.org/api/1.1/series/1255/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1255","date":"2020-09-02T10:47:25","name":"android: camera_device: List JPEG/RAW correct resolutions","version":1,"mbox":"https://patchwork.libcamera.org/series/1255/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9440/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9440/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DADB8BF019\n\tfor ;\n\tWed, 2 Sep 2020 10:43:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6D73629BF;\n\tWed, 2 Sep 2020 12:43:59 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B0E1628EE\n\tfor ;\n\tWed, 2 Sep 2020 12:43:58 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 3E46640009;\n\tWed, 2 Sep 2020 10:43:57 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 2 Sep 2020 12:47:28 +0200","Message-Id":"<20200902104730.43451-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200902104730.43451-1-jacopo@jmondi.org>","References":"<20200902104730.43451-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 3/5] android: camera_device: Add debug to\n\tstream initialization","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"tfiga@google.com, hiroh@google.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add debug printouts to the CameraDevice::initializeStreamConfigurations()\nfunction that helps to follow the process of building the stream\nconfigurations map.\n\nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 26 +++++++++++++++++++++++++-\n 1 file changed, 25 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 8a8072123961..493d6cecde72 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -363,6 +363,9 @@ int CameraDevice::initializeStreamConfigurations()\n \t\tconst std::vector &libcameraFormats =\n \t\t\tcamera3Format.libcameraFormats;\n \n+\t\tLOG(HAL, Debug) << \"Testing Android format: \"\n+\t\t\t\t<< camera3Format.name;\n+\n \t\t/*\n \t\t * Fixed format mapping for JPEG.\n \t\t *\n@@ -375,6 +378,10 @@ int CameraDevice::initializeStreamConfigurations()\n \t\t */\n \t\tif (androidFormat == HAL_PIXEL_FORMAT_BLOB) {\n \t\t\tformatsMap_[androidFormat] = formats::MJPEG;\n+\t\t\tLOG(HAL, Debug) << \"Mapped Android format: \"\n+\t\t\t\t\t<< camera3Format.name << \" to: \"\n+\t\t\t\t\t<< formats::MJPEG.toString()\n+\t\t\t\t\t<< \" (fixed mapping)\";\n \t\t\tcontinue;\n \t\t}\n \n@@ -385,6 +392,10 @@ int CameraDevice::initializeStreamConfigurations()\n \t\tPixelFormat mappedFormat;\n \t\tfor (const PixelFormat &pixelFormat : libcameraFormats) {\n \n+\t\t\tLOG(HAL, Debug) << \"Testing Android format: \"\n+\t\t\t\t\t<< camera3Format.name << \" with: \"\n+\t\t\t\t\t<< pixelFormat.toString();\n+\n \t\t\t/*\n \t\t\t * The stream configuration size can be adjusted,\n \t\t\t * not the pixel format.\n@@ -420,14 +431,27 @@ int CameraDevice::initializeStreamConfigurations()\n \t\t * stream configurations map, by testing the image resolutions.\n \t\t */\n \t\tformatsMap_[androidFormat] = mappedFormat;\n+\t\tLOG(HAL, Debug) << \"Mapped Android format: \"\n+\t\t\t\t<< camera3Format.name << \" to: \"\n+\t\t\t\t<< mappedFormat.toString();\n \n \t\tfor (const Size &res : cameraResolutions) {\n \t\t\tcfg.pixelFormat = mappedFormat;\n \t\t\tcfg.size = res;\n \n+\t\t\tstd::stringstream ss;\n+\t\t\tss << \"Testing (\" << res.toString() << \")[\"\n+\t\t\t << mappedFormat.toString() << \"]: \";\n+\n \t\t\tCameraConfiguration::Status status = cameraConfig->validate();\n-\t\t\tif (status != CameraConfiguration::Valid)\n+\t\t\tif (status != CameraConfiguration::Valid) {\n+\t\t\t\tss << \" not supported\";\n+\t\t\t\tLOG(HAL, Debug) << ss.str();\n \t\t\t\tcontinue;\n+\t\t\t}\n+\n+\t\t\tss << \" supported\";\n+\t\t\tLOG(HAL, Debug) << ss.str();\n \n \t\t\tstreamConfigurations_.push_back({ res, androidFormat });\n \n","prefixes":["libcamera-devel","3/5"]}