{"id":9424,"url":"https://patchwork.libcamera.org/api/1.1/patches/9424/?format=json","web_url":"https://patchwork.libcamera.org/patch/9424/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200828155136.541696-2-jacopo@jmondi.org>","date":"2020-08-28T15:51:35","name":"[libcamera-devel,v2,2/3] libcamera: raspberrypi: dmaheaps: Add isValid()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e26768b99b7911614d02ac9efb7e44c5620f8b0d","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9424/mbox/","series":[{"id":1251,"url":"https://patchwork.libcamera.org/api/1.1/series/1251/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1251","date":"2020-08-28T15:51:34","name":"[libcamera-devel,v2,1/3] libcamera: raspberrypi: dmaheaps: Improve device open","version":2,"mbox":"https://patchwork.libcamera.org/series/1251/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9424/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9424/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE7D8BF019\n\tfor ;\n\tFri, 28 Aug 2020 15:48:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 898596291F;\n\tFri, 28 Aug 2020 17:48:00 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C7CF61EA0\n\tfor ;\n\tFri, 28 Aug 2020 17:47:58 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 075E5200002;\n\tFri, 28 Aug 2020 15:47:57 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 28 Aug 2020 17:51:35 +0200","Message-Id":"<20200828155136.541696-2-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200828155136.541696-1-jacopo@jmondi.org>","References":"<20200828155136.541696-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 2/3] libcamera: raspberrypi: dmaheaps:\n\tAdd isValid()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add isValid() method to verify the allocator device has been open\ncorrectly.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/raspberrypi/dma_heaps.h | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/dma_heaps.h b/src/libcamera/pipeline/raspberrypi/dma_heaps.h\nindex ae6be1135f17..119abd26ed31 100644\n--- a/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n+++ b/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n@@ -18,6 +18,7 @@ class DmaHeap\n public:\n \tDmaHeap();\n \t~DmaHeap();\n+\tint isValid() const { return dmaHeapHandle_ > -1; }\n \tFileDescriptor alloc(const char *name, std::size_t size);\n \n private:\n","prefixes":["libcamera-devel","v2","2/3"]}