{"id":9318,"url":"https://patchwork.libcamera.org/api/1.1/patches/9318/?format=json","web_url":"https://patchwork.libcamera.org/patch/9318/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200813223722.4050835-3-niklas.soderlund@ragnatech.se>","date":"2020-08-13T22:37:17","name":"[libcamera-devel,v4,2/7] libcamera: utils: Add method to strip Unicode characters","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c2931218f38361180d25ca016b6f023a33166cd8","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":{"id":16,"url":"https://patchwork.libcamera.org/api/1.1/users/16/?format=json","username":"neg","first_name":"Niklas","last_name":"Söderlund","email":"niklas.soderlund@ragnatech.se"},"mbox":"https://patchwork.libcamera.org/patch/9318/mbox/","series":[{"id":1219,"url":"https://patchwork.libcamera.org/api/1.1/series/1219/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1219","date":"2020-08-13T22:37:15","name":"libcamera: Allow for user-friendly names in applications","version":4,"mbox":"https://patchwork.libcamera.org/series/1219/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9318/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9318/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8622BBD87D\n\tfor ;\n\tThu, 13 Aug 2020 22:37:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE09F61696;\n\tFri, 14 Aug 2020 00:37:37 +0200 (CEST)","from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B101C613B4\n\tfor ;\n\tFri, 14 Aug 2020 00:37:35 +0200 (CEST)","from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 95099a14-ddb5-11ea-a39b-005056917f90;\n\tFri, 14 Aug 2020 00:37:34 +0200 (CEST)"],"X-Halon-ID":"95099a14-ddb5-11ea-a39b-005056917f90","Authorized-sender":"niklas.soderlund@fsdn.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 14 Aug 2020 00:37:17 +0200","Message-Id":"<20200813223722.4050835-3-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200813223722.4050835-1-niklas.soderlund@ragnatech.se>","References":"<20200813223722.4050835-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 2/7] libcamera: utils: Add method to\n\tstrip Unicode characters","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add method that strips non-ASCII characters from a string.\n\nSigned-off-by: Niklas Söderlund \n---\n* Changes since v3\n- Fix spelling in comment.\n- Rename to toAscii()\n---\n include/libcamera/internal/utils.h | 2 ++\n src/libcamera/utils.cpp | 21 +++++++++++++++++++++\n 2 files changed, 23 insertions(+)","diff":"diff --git a/include/libcamera/internal/utils.h b/include/libcamera/internal/utils.h\nindex 45cd6f120c51586b..b27f5a2323552058 100644\n--- a/include/libcamera/internal/utils.h\n+++ b/include/libcamera/internal/utils.h\n@@ -197,6 +197,8 @@ private:\n \n details::StringSplitter split(const std::string &str, const std::string &delim);\n \n+std::string toAscii(const std::string &str);\n+\n std::string libcameraBuildPath();\n std::string libcameraSourcePath();\n \ndiff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\nindex 615df46ac142a2a9..726b84bfbae53ff2 100644\n--- a/src/libcamera/utils.cpp\n+++ b/src/libcamera/utils.cpp\n@@ -342,6 +342,27 @@ details::StringSplitter split(const std::string &str, const std::string &delim)\n \treturn details::StringSplitter(str, delim);\n }\n \n+/**\n+ * \\brief Strip all Unicode characters from a string\n+ * \\param[in] str The string to strip\n+ *\n+ * Strip all non-ASCII characters form a string. A Unicode character that spans\n+ * multiple bytes (and therefore is not also an ASCII character) may be\n+ * identified by the fact that its most significant bit is always set.\n+ *\n+ * \\todo When switching to C++ 20 use std::remove_if.\n+ *\n+ * \\return An ASCII string\n+ */\n+std::string toAscii(const std::string &str)\n+{\n+\tstd::string ret;\n+\tfor (const char &c : str)\n+\t\tif (!(c & 0x80))\n+\t\t\tret += c;\n+\treturn ret;\n+}\n+\n /**\n * \\brief Check if libcamera is installed or not\n *\n","prefixes":["libcamera-devel","v4","2/7"]}