{"id":9237,"url":"https://patchwork.libcamera.org/api/1.1/patches/9237/?format=json","web_url":"https://patchwork.libcamera.org/patch/9237/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200805151507.227503-11-kieran.bingham@ideasonboard.com>","date":"2020-08-05T15:15:04","name":"[libcamera-devel,v4,10/13] android: camera_device: Report configuration changes from validate()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"973e020150169c291803d14c30e64dbbfa288460","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9237/mbox/","series":[{"id":1198,"url":"https://patchwork.libcamera.org/api/1.1/series/1198/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1198","date":"2020-08-05T15:14:54","name":"android: JPEG support","version":4,"mbox":"https://patchwork.libcamera.org/series/1198/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9237/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9237/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4BD7FBD87B\n\tfor ;\n\tWed, 5 Aug 2020 15:15:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1488F60901;\n\tWed, 5 Aug 2020 17:15:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 871D9605C0\n\tfor ;\n\tWed, 5 Aug 2020 17:15:16 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F3BFA304;\n\tWed, 5 Aug 2020 17:15:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DS0CsY5f\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596640516;\n\tbh=Zj/gCjWtOnbMkj33ENuOYRQrWswY1/duO6JA/MbRItU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DS0CsY5fg3z/gBzgzbYkWQ8SmIIlOOO6mr+QP4/Ts3fimUwKCfIRaosBECH5weeyo\n\tB85kbOqZedk89tszPFk8nScmYGiwtkhhGBMg3RulKzv29klcVKQignhePm9wgViY+C\n\toPE8RkZSOwkDiTgSf/DEkb8iGrv9f5vYRqzdkA04=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 5 Aug 2020 16:15:04 +0100","Message-Id":"<20200805151507.227503-11-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200805151507.227503-1-kieran.bingham@ideasonboard.com>","References":"<20200805151507.227503-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 10/13] android: camera_device: Report\n\tconfiguration changes from validate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When we call validate on a configuration, if there are any adjustments\non the configuration, we fail without showing why.\n\nDisplay the stream configuration after the validate stage to aid\ndebugging stream startup failures.\n\nReviewed-by: Jacopo Mondi \nReviewed-by: Laurent Pinchart \nSigned-off-by: Kieran Bingham \n---\n\nv4\n - hyphenate instead.\n---\n src/android/camera_device.cpp | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex a5c135ce03eb..397161a9ab12 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1084,6 +1084,10 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t\tbreak;\n \tcase CameraConfiguration::Adjusted:\n \t\tLOG(HAL, Info) << \"Camera configuration adjusted\";\n+\n+\t\tfor (const StreamConfiguration &cfg : *config_)\n+\t\t\tLOG(HAL, Info) << \" - \" << cfg.toString();\n+\n \t\tconfig_.reset();\n \t\treturn -EINVAL;\n \tcase CameraConfiguration::Invalid:\n","prefixes":["libcamera-devel","v4","10/13"]}